From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: nomadik: fix clocksource warning
Date: Fri, 31 May 2013 17:49:28 +0200 [thread overview]
Message-ID: <41518453.ApMFpK6n11@wuerfel> (raw)
The clocksource API has changed slightly, which causes a harmless
warning:
/git/arm-soc/drivers/clocksource/nomadik-mtu.c:259:28: warning: 'nmdk_timer_match' defined but not used [-Wunused-variable]
static struct of_device_id nmdk_timer_match[] __initconst = {
^
Fortunately, the same API change also lets us simplify the code
while removing the warning.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
I've applied this patch on top of next/dt to remove the warning introduced
by Linus' patch.
diff --git a/drivers/clocksource/nomadik-mtu.c b/drivers/clocksource/nomadik-mtu.c
index 7982cb0..b9415b6 100644
--- a/drivers/clocksource/nomadik-mtu.c
+++ b/drivers/clocksource/nomadik-mtu.c
@@ -256,23 +256,13 @@ void __init nmdk_timer_init(void __iomem *base, int irq)
__nmdk_timer_init(base, irq, pclk0, clk0);
}
-static struct of_device_id nmdk_timer_match[] __initconst = {
- { .compatible = "st,nomadik-mtu" },
- {}
-};
-
-static void __init nmdk_timer_of_init(void)
+static void __init nmdk_timer_of_init(struct device_node *node)
{
- struct device_node *node;
struct clk *pclk;
struct clk *clk;
void __iomem *base;
int irq;
- node = of_find_matching_node(NULL, nmdk_timer_match);
- if (!node)
- panic("No timer node");
-
base = of_iomap(node, 0);
if (!base)
panic("Can't remap registers");
next reply other threads:[~2013-05-31 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 15:49 Arnd Bergmann [this message]
2013-06-01 6:47 ` [PATCH] ARM: nomadik: fix clocksource warning Olof Johansson
2013-06-03 18:55 ` Arnd Bergmann
2013-06-02 19:23 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41518453.ApMFpK6n11@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox