From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACC73C27C6E for ; Fri, 14 Jun 2024 04:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:CC:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=niPSulZ9xaDs+52fF0WA8MmxhdeH0ccH+0NjkyCEsKw=; b=YoTDmrUN2Vgz3lsYeu2KZqUD8z wa4Kf///VD+h1CpNMNqoqj9mvFfwV1uQrDw+J5lJEmfzeeKkx3kBpGMKHxbLvrh306CzwfdvggPKt cTS76HDglihsMYmR0nro4EZHv1KiJT6/MJ0M0gNxiKcn4JPCTC0qdW8KN4vsU/64SR7oj3xnF7Is4 KRgLE2+wC+JGi5t2f9T3Qqdpq6J9dWuL042aV88AItAXxeNgdYHs1XpBglWM+oH1G7xrk1Su5Ke4x sgqgt6TGFOWLKOF5zQz+xYuROIk4rLNqCylTcXm064Ej4wBVtUmLzC24POe67ue1b548nFXexTTcB XgYVSv3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHy7K-00000001LAg-1yYW; Fri, 14 Jun 2024 04:00:46 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHy7G-00000001L9u-2F1A for linux-arm-kernel@lists.infradead.org; Fri, 14 Jun 2024 04:00:44 +0000 Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4W0lnm0KRFzxQwN; Fri, 14 Jun 2024 11:56:28 +0800 (CST) Received: from kwepemd200013.china.huawei.com (unknown [7.221.188.133]) by mail.maildlp.com (Postfix) with ESMTPS id 5772C14066B; Fri, 14 Jun 2024 12:00:34 +0800 (CST) Received: from [10.67.110.108] (10.67.110.108) by kwepemd200013.china.huawei.com (7.221.188.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.34; Fri, 14 Jun 2024 12:00:32 +0800 Message-ID: <41702bd8-2a1f-90dd-d90e-fb5cba2fffa7@huawei.com> Date: Fri, 14 Jun 2024 12:00:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v3 1/8] arm64/sysreg: Add definitions for immediate versions of MSR ALLINT From: "Liao, Chang" To: Mark Brown CC: Mark Rutland , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20240415064758.3250209-1-liaochang1@huawei.com> <20240415064758.3250209-2-liaochang1@huawei.com> <9868a5ac-ae23-4481-afe6-ba3cd8dbfa47@sirena.org.uk> <3f9f0ef1-7290-21df-ef01-dc56b34a0195@huawei.com> In-Reply-To: <3f9f0ef1-7290-21df-ef01-dc56b34a0195@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.110.108] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemd200013.china.huawei.com (7.221.188.133) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240613_210042_990992_DE41E93F X-CRM114-Status: UNSURE ( 8.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Mark 在 2024/6/5 17:52, Liao, Chang 写道: > Hi, Mark > > 在 2024/6/4 21:29, Mark Brown 写道: >> On Mon, Jun 03, 2024 at 11:26:39AM +0800, Liao, Chang wrote: >> >>> Mark, Is your concern is that the series of pstate related macro name in >>> sysregs.h are lack of self-explanatory nature, which make it diffuclt to >>> understand their functionality and purpose? If so, I daft some alternative >>> macro names in the code below, looking forward to your feedback, or if you >>> have any proposal for making these helpers discoverable. >> >> ... >> >>> -#define SET_PSTATE(x, r) __emit_inst(0xd500401f | PSTATE_ ## r | ((!!x) << PSTATE_Imm_shift)) >>> +#define MSR_PSTATE_ENCODE(x, r) __emit_inst(0xd500401f | PSTATE_ ## r | ((!!x) << PSTATE_Imm_shift)) >> >> Possibly, yes? TBH I was thinking of a comment but that does have "MSR" >> in it so might come up in greps. Not sure what others would prefer. > > I am going to push revision v4 of the interrupt masking patchset, this revision > involves several improvements based on feedback and further testing: > Kindly ping, the new revsion is available at the link: https://lore.kernel.org/all/20240614034433.602622-1-liaochang1@huawei.com/ -- BR Liao, Chang