From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] pinctrl: rockchip: Define GPIO banks 7 and 8
Date: Sat, 12 Sep 2015 12:40:37 +0200 [thread overview]
Message-ID: <4186674.JafPHeXURU@diego> (raw)
In-Reply-To: <1442011005-4828-1-git-send-email-sjoerd.simons@collabora.co.uk>
Hi Sjoerd,
Am Samstag, 12. September 2015, 00:36:44 schrieb Sjoerd Simons:
> Rockchip RK3288 has 9 GPIO banks (0 to 8) add definitions for the last
> two.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> ---
>
> include/dt-bindings/pinctrl/rockchip.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/dt-bindings/pinctrl/rockchip.h
> b/include/dt-bindings/pinctrl/rockchip.h index 743e66a..efc57cf 100644
> --- a/include/dt-bindings/pinctrl/rockchip.h
> +++ b/include/dt-bindings/pinctrl/rockchip.h
> @@ -24,6 +24,8 @@
> #define RK_GPIO3 3
> #define RK_GPIO4 4
> #define RK_GPIO6 6
> +#define RK_GPIO7 7
> +#define RK_GPIO8 8
>
> #define RK_FUNC_GPIO 0
> #define RK_FUNC_1 1
I'm actually not sure about these. In retrospect the RK_GPIOx -> x defines do
not provide any additional value compared to just having the actual value in
the pinctrl-nodes, so we phased them out largely for the rk3288 boards.
While looking through some boards, I saw that some slipped in for stuff that
gets copy'n'paste treatment most of the time, but generally we're only using
the real numbers on boards - and I'd like to keep it that way and phase out
the RK_GPIOx constants in new boards.
Heiko
prev parent reply other threads:[~2015-09-12 10:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 22:36 [PATCH 1/2] pinctrl: rockchip: Define GPIO banks 7 and 8 Sjoerd Simons
2015-09-11 22:36 ` [PATCH 2/2] ARM: dts: rockchip: Add dtb for the Radxa Rock 2 Square board Sjoerd Simons
2015-09-13 16:47 ` Heiko Stübner
2015-09-13 16:59 ` Heiko Stübner
2015-09-13 23:00 ` Javier Martinez Canillas
2015-09-14 7:30 ` Sjoerd Simons
2015-09-14 7:50 ` Javier Martinez Canillas
2015-09-14 8:05 ` Sjoerd Simons
2015-09-14 8:47 ` Heiko Stübner
2015-09-12 10:40 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4186674.JafPHeXURU@diego \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).