From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] SoCFPGA updates for v4.2
Date: Tue, 12 May 2015 22:20:53 +0200 [thread overview]
Message-ID: <4187963.lx6hRMGsoN@wuerfel> (raw)
In-Reply-To: <1431371529-22593-2-git-send-email-dinguyen@opensource.altera.com>
On Monday 11 May 2015 14:12:09 dinguyen at opensource.altera.com wrote:
> SoCFPGA updates for v4.2
> - Add big endian support
> - Add earlyprintk support on UART1 that is used on Arria10
> - Remove the need to map uart_io_desc
>
The patches look almost ok, but please clarify a minor issue:
static void __init socfpga_map_io(void)
{
socfpga_scu_map_io();
- iotable_init(&uart_io_desc, 1);
- early_printk("Early printk initialized\n");
}
You have a map_io() function here, which means that the debug_ll_io_init()
function is not called. How does the debug_ll mapping get created then?
If it's not, I think the best solution is to remove the socfpga_map_io()
function entirely, and turn socfpga_scu_base_addr into a local variable
in arch/arm/mach-socfpga/platsmp.c that gets set using of_iomap().
Arn
next prev parent reply other threads:[~2015-05-12 20:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 19:12 [GIT PULL] SoCFPGA DTS updates for v4.2 dinguyen at opensource.altera.com
2015-05-11 19:12 ` [GIT PULL] SoCFPGA " dinguyen at opensource.altera.com
2015-05-12 20:20 ` Arnd Bergmann [this message]
2015-05-12 20:25 ` Arnd Bergmann
2015-05-12 22:05 ` Dinh Nguyen
2015-05-12 20:26 ` Dinh Nguyen
2015-05-12 15:23 ` [GIT PULL] SoCFPGA DTS " Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4187963.lx6hRMGsoN@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).