public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/3] Documentation: add devicetree bindings for Cavium Thunder SoC
Date: Mon, 24 Mar 2014 12:00:52 +0100	[thread overview]
Message-ID: <4189666.qlSmlZKNNW@wuerfel> (raw)
In-Reply-To: <1395652179-9216-4-git-send-email-mohun106@gmail.com>

On Monday 24 March 2014 14:39:39 mohun106 at gmail.com wrote:
> diff --git a/Documentation/devicetree/bindings/arm/cavium-thunder.txt b/Documentation/devicetree/bindings/arm/cavium-thunder.txt
> new file mode 100644
> index 0000000..6ea0a34
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/cavium-thunder.txt
> @@ -0,0 +1,9 @@
> +Cavium Thunder platform device tree bindings
> +---------------------------------------------
> +
> +Boards with Cavium's Thunder SoC shall have following properties.
> +
> +Root Node
> +---------
> +Required root node properties:
> +    - compatible = "cavium,thunder";
> diff --git a/Documentation/devicetree/bindings/arm/cpus.txt b/Documentation/devicetree/bindings/arm/cpus.txt
> index 333f4ae..f6cadf1 100644
> --- a/Documentation/devicetree/bindings/arm/cpus.txt
> +++ b/Documentation/devicetree/bindings/arm/cpus.txt
> @@ -163,6 +163,7 @@ nodes to be present and contain the properties described below.
>                             "arm,cortex-r4"
>                             "arm,cortex-r5"
>                             "arm,cortex-r7"
> +                           "cavium,thunder"
>                             "faraday,fa526"
>                             "intel,sa110"
>                             "intel,sa1100"


It seems very confusing to use the same name for both the SoC and the
CPU core. Can you guarantee that there will never be another SoC with
the same core, or a different CPU core in a SoC with the same name?

If not, please be more specific here and use the exact model names
rather than the product names.

	Arnd

  reply	other threads:[~2014-03-24 11:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-24  9:09 [PATCH v2 0/3] Add support for Cavium Thunder ARMv8 platform mohun106 at gmail.com
2014-03-24  9:09 ` [PATCH v2 1/3] arm64: Add Kconfig option for Cavium Thunder SoC Family mohun106 at gmail.com
2014-03-24  9:09 ` [PATCH v2 2/3] arm64: dts: Add initial dts for Cavium Thunder SoC mohun106 at gmail.com
2014-03-24  9:55   ` Arnd Bergmann
2014-03-25 11:04     ` Radha Mohan
2014-03-24 10:25   ` Mark Rutland
2014-03-25 11:29     ` Radha Mohan
2014-03-24  9:09 ` [PATCH v2 3/3] Documentation: add devicetree bindings " mohun106 at gmail.com
2014-03-24 11:00   ` Arnd Bergmann [this message]
2014-03-25 11:30     ` Radha Mohan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4189666.qlSmlZKNNW@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox