From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm: arm-hdlcd: remove DMA_CMA select
Date: Fri, 01 Jan 2016 15:09:10 +0100 [thread overview]
Message-ID: <4194408.X82ccDjh5X@wuerfel> (raw)
The newly added DRM_HDLCD driver tries to select DMA_CMA, but that is
not necessarily possible, as not all configurations contain HAVE_DMA_CONTIGUOUS:
warning: (DRM_HDLCD) selects DMA_CMA which has unmet direct dependencies (HAVE_DMA_CONTIGUOUS && CMA)
drivers/built-in.o: In function `dma_alloc_from_contiguous':
:(.text+0x1dee00): undefined reference to `cma_alloc'
drivers/built-in.o: In function `dma_release_from_contiguous':
:(.text+0x1dee24): undefined reference to `cma_release'
This removes the 'select' statement. It is not needed because CMA is meant
to transparently change the behavior of dma_alloc_coherent to make it succeed
for larger allocations, but there is no actual build-time dependency, and
the driver can still work without CMA in many cases.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 1561e558334d ("drm: Add support for ARM's HDLCD controller.")
---
Found on ARM randconfig builds with yesterday's linux-next
diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
index 5e8c8a86860b..2f4d3b7fb871 100644
--- a/drivers/gpu/drm/arm/Kconfig
+++ b/drivers/gpu/drm/arm/Kconfig
@@ -10,7 +10,6 @@ config DRM_HDLCD
depends on DRM_ARM
depends on COMMON_CLK
select COMMON_CLK_SCPI
- select DMA_CMA
select DRM_KMS_CMA_HELPER
select DRM_GEM_CMA_HELPER
help
next reply other threads:[~2016-01-01 14:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-01 14:09 Arnd Bergmann [this message]
2016-01-01 14:38 ` [PATCH 2/3] drm: arm-hdlcd: remove COMMON_CLK_SCPI select Arnd Bergmann
2016-01-04 8:26 ` Thierry Reding
2016-01-01 14:39 ` [PATCH 3/3] drm: arm-hdlcd: fix build warnings for !CONFIG_PM Arnd Bergmann
2016-01-04 8:24 ` Thierry Reding
2016-01-01 22:04 ` [PATCH 4/3] drm: arm-hdlcd: add explictit DRM dependency Arnd Bergmann
2016-01-04 8:24 ` Thierry Reding
2016-01-04 8:39 ` Arnd Bergmann
2016-01-11 11:12 ` Liviu Dudau
2016-01-11 12:18 ` Arnd Bergmann
2016-01-11 12:26 ` Liviu Dudau
2016-01-11 13:49 ` Arnd Bergmann
2016-01-11 14:14 ` Liviu Dudau
2016-01-04 8:27 ` [PATCH] drm: arm-hdlcd: remove DMA_CMA select Thierry Reding
2016-01-11 10:37 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4194408.X82ccDjh5X@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox