* [PATCH v3] phy: fsl-imx8mq-usb: fix tuning parameter name
@ 2024-08-01 12:46 Xu Yang
2024-08-01 12:53 ` Alexander Stein
2024-08-04 17:52 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Xu Yang @ 2024-08-01 12:46 UTC (permalink / raw)
To: vkoul, kishon, shawnguo, s.hauer, kernel, festevam,
alexander.stein
Cc: jun.li, xu.yang_2, linux-phy, imx, linux-arm-kernel, linux-kernel
According to fsl,imx8mq-usb-phy.yaml, this tuning parameter should be
fsl,phy-pcs-tx-deemph-3p5db-attenuation-db.
Fixes: 63c85ad0cd81 ("phy: fsl-imx8mp-usb: add support for phy tuning")
Cc: stable@vger.kernel.org
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
Changes in v2:
- add fixes
Changes in v3:
- correct fixes commit
---
drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
index 0b9a59d5b8f0..adc6394626ce 100644
--- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
+++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
@@ -176,7 +176,7 @@ static void imx8m_get_phy_tuning_data(struct imx8mq_usb_phy *imx_phy)
imx_phy->comp_dis_tune =
phy_comp_dis_tune_from_property(imx_phy->comp_dis_tune);
- if (device_property_read_u32(dev, "fsl,pcs-tx-deemph-3p5db-attenuation-db",
+ if (device_property_read_u32(dev, "fsl,phy-pcs-tx-deemph-3p5db-attenuation-db",
&imx_phy->pcs_tx_deemph_3p5db))
imx_phy->pcs_tx_deemph_3p5db = PHY_TUNE_DEFAULT;
else
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] phy: fsl-imx8mq-usb: fix tuning parameter name
2024-08-01 12:46 [PATCH v3] phy: fsl-imx8mq-usb: fix tuning parameter name Xu Yang
@ 2024-08-01 12:53 ` Alexander Stein
2024-08-04 17:52 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Stein @ 2024-08-01 12:53 UTC (permalink / raw)
To: vkoul, kishon, shawnguo, s.hauer, kernel, festevam, Xu Yang
Cc: jun.li, xu.yang_2, linux-phy, imx, linux-arm-kernel, linux-kernel
Hi,
Am Donnerstag, 1. August 2024, 14:46:42 CEST schrieb Xu Yang:
> According to fsl,imx8mq-usb-phy.yaml, this tuning parameter should be
> fsl,phy-pcs-tx-deemph-3p5db-attenuation-db.
>
> Fixes: 63c85ad0cd81 ("phy: fsl-imx8mp-usb: add support for phy tuning")
> Cc: stable@vger.kernel.org
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
Look good to me:
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Changes in v2:
> - add fixes
> Changes in v3:
> - correct fixes commit
> ---
> drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> index 0b9a59d5b8f0..adc6394626ce 100644
> --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> @@ -176,7 +176,7 @@ static void imx8m_get_phy_tuning_data(struct imx8mq_usb_phy *imx_phy)
> imx_phy->comp_dis_tune =
> phy_comp_dis_tune_from_property(imx_phy->comp_dis_tune);
>
> - if (device_property_read_u32(dev, "fsl,pcs-tx-deemph-3p5db-attenuation-db",
> + if (device_property_read_u32(dev, "fsl,phy-pcs-tx-deemph-3p5db-attenuation-db",
> &imx_phy->pcs_tx_deemph_3p5db))
> imx_phy->pcs_tx_deemph_3p5db = PHY_TUNE_DEFAULT;
> else
>
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] phy: fsl-imx8mq-usb: fix tuning parameter name
2024-08-01 12:46 [PATCH v3] phy: fsl-imx8mq-usb: fix tuning parameter name Xu Yang
2024-08-01 12:53 ` Alexander Stein
@ 2024-08-04 17:52 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2024-08-04 17:52 UTC (permalink / raw)
To: kishon, shawnguo, s.hauer, kernel, festevam, alexander.stein,
Xu Yang
Cc: jun.li, linux-phy, imx, linux-arm-kernel, linux-kernel
On Thu, 01 Aug 2024 20:46:42 +0800, Xu Yang wrote:
> According to fsl,imx8mq-usb-phy.yaml, this tuning parameter should be
> fsl,phy-pcs-tx-deemph-3p5db-attenuation-db.
>
>
Applied, thanks!
[1/1] phy: fsl-imx8mq-usb: fix tuning parameter name
commit: ce52c2532299c7ccfd34a52db8d071e890a78c59
Best regards,
--
Vinod Koul <vkoul@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-04 17:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-01 12:46 [PATCH v3] phy: fsl-imx8mq-usb: fix tuning parameter name Xu Yang
2024-08-01 12:53 ` Alexander Stein
2024-08-04 17:52 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).