From: Luiz Capitulino <luizcap@redhat.com>
To: Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ard Biesheuvel <ardb@kernel.org>,
Ryan Roberts <ryan.roberts@arm.com>
Cc: kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] arm64/mm: Fix Boot panic on Ampere Altra
Date: Thu, 27 Feb 2025 15:43:09 -0500 [thread overview]
Message-ID: <4196e42f-7b04-44a7-ac34-6ca2e9190c21@redhat.com> (raw)
In-Reply-To: <174052227763.2420464.2784848656225511807.b4-ty@kernel.org>
On 2025-02-27 13:50, Will Deacon wrote:
> On Tue, 25 Feb 2025 11:46:36 +0000, Ryan Roberts wrote:
>> When the range of present physical memory is sufficiently small enough
>> and the reserved address space for the linear map is sufficiently large
>> enough, The linear map base address is randomized in
>> arm64_memblock_init().
>>
>> Prior to commit 62cffa496aac ("arm64/mm: Override PARange for !LPA2 and
>> use it consistently"), we decided if the sizes were suitable with the
>> help of the raw mmfr0.parange. But the commit changed this to use the
>> sanitized version instead. But the function runs before the register has
>> been sanitized so this returns 0, interpreted as a parange of 32 bits.
>> Some fun wrapping occurs and the logic concludes that there is enough
>> room to randomize the linear map base address, when really there isn't.
>> So the top of the linear map ends up outside the reserved address space.
>>
>> [...]
>
> Applied the reduced version to arm64 (for-next/fixes), thanks!
>
> [1/1] arm64/mm: Fix Boot panic on Ampere Altra
> https://git.kernel.org/arm64/c/2b1283e1ea9b
Just in case:
Tested-by: Luiz Capitulino <luizcap@redhat.com>
prev parent reply other threads:[~2025-02-27 20:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 11:46 [PATCH v1] arm64/mm: Fix Boot panic on Ampere Altra Ryan Roberts
2025-02-25 16:57 ` Luiz Capitulino
2025-02-25 17:13 ` Ryan Roberts
2025-02-25 18:05 ` Ard Biesheuvel
2025-02-26 0:10 ` Will Deacon
2025-02-26 6:59 ` Ard Biesheuvel
2025-02-26 8:07 ` Ryan Roberts
2025-02-26 8:33 ` Ard Biesheuvel
2025-02-26 8:55 ` Ryan Roberts
2025-02-26 9:04 ` Ard Biesheuvel
2025-02-26 9:45 ` Ryan Roberts
2025-02-26 10:07 ` Ard Biesheuvel
2025-02-26 10:18 ` Ryan Roberts
2025-02-27 18:50 ` Will Deacon
2025-02-27 20:43 ` Luiz Capitulino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4196e42f-7b04-44a7-ac34-6ca2e9190c21@redhat.com \
--to=luizcap@redhat.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ryan.roberts@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox