From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36519C54747 for ; Wed, 28 Aug 2024 01:14:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: References:Message-ID:In-Reply-To:Subject:cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EObt5i50iGh4auejXy74Fkt2ypeznzZReVY2waYYP4A=; b=26/N04RwA2xM54xlJYxwhvWkN6 YxWaE4KMAr8s0cXRjfTy9cf/ucnIp9ZZrFISpwqcjJwS3vgF6THE5LAFtFxiAhJKyAtuy9jKxcU5G saC5TzbNAvsgQcuaRqIrHtS31DlIES5lvQt3g6gDa50/D23NWfYwbxR6wdymMMvOmyCGXEbyvGeD5 CqxRf3jBjDvm/xw5ngR+knEZOVWqh1DbRH3oYITdGwNv0Maql1YFEYg5ocuNlOOnp9Ji+hrnzHV9E yqKAJBGhSbcm5soAVdwM7xJEcTXexygb8ujBgz58MMDie0SsqTm7Czqu/cIiYGOYoORph/sQRTf+F aADVOiMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sj7Ga-0000000DJyU-3nYw; Wed, 28 Aug 2024 01:14:32 +0000 Received: from outbound-ip24b.ess.barracuda.com ([209.222.82.221]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sj7Fm-0000000DJsq-2Ybj for linux-arm-kernel@lists.infradead.org; Wed, 28 Aug 2024 01:13:44 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2046.outbound.protection.outlook.com [104.47.66.46]) by mx-outbound21-206.us-east-2b.ess.aws.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 28 Aug 2024 01:13:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mql1FYFDGnIUMNH6/P0NctMMaMmJgxRohdaQ8Ykt2KEkvf6pVy157JZofYL1EPsLY8mS4VvxP/6jyFLD56fuMLPzZtIOjnJPwIsbL4BpUxg7fNZMuaOO4T6t2AKpIq3h+t3fZoBvZexM7Z1ahTyLWuErxtjaVvO/pmWYbo3Cc1VQAmh3obTHdfBMgpcH5vXZDjHbkYh8sj1Hjpyhhwtta8u9W8mOgrh116YdFUsZ9DAjgQZav2R6wJYNGd7R6uonliF0ja4Cmdko1d4kWzOWzF7BLn/O8bpKgyWAUrj9kmWAXkDqeUBr6SuXiZ2SY600FddRx4SlXD9ebBK/D9SIog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EObt5i50iGh4auejXy74Fkt2ypeznzZReVY2waYYP4A=; b=X3+aDT1Eui1QfAx+QylI1gEjdNjE1pX3bci6Zhpxh9bR1KEbhGTG8dwXnIvJ6MOijxVbMxiV1lw93bJXnYS2mmLaNRPxyWHRZoJ0lHa/vqOQMh7HmhWlPyIXCBL6shoibvKYYfYTtsRJNz5LUayVFmbw+BT02o5q7sJM3kLNNbqO8iBuLoa2+9yux1drovFE1tgUj1qwEutb8p/HnAQP0zrWrUWKPe6k63VXLiBwiNdxp4EkIIGfzMRWfc6U9zTwoTVYpqVS+Y8e/tZqgqa0tykA/9+g9MPHeCeD5dUG9QU37M8QNJ76tX5hUjbis5vXM980yVme0V8uShxv3RrgUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=digi.com; dmarc=pass action=none header.from=digi.com; dkim=pass header.d=digi.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=digi.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EObt5i50iGh4auejXy74Fkt2ypeznzZReVY2waYYP4A=; b=Hu2pi4YDAMPuOGnJZhEpflu2rA2fbTEhEdEfyUy0ZKr2ej5hsuFUnPO9gsWR9Lko6wfUv/vXXd+npHhSiz0uTA6T8KO2QEdqVdw+UGXZ3ijLpYc3ht4TWWs2ckWBDmPT6UuozytUQR2Dk+SD8n64K6tycV4bwAm4Ul4bOyAr9AEOw+rCNn7z8gfr7RlZKfw6nNWMuPe86UcbbVmUB7kKZo8f/3k35kgVCaNCgJKs8wSmRrcBkkUlYHg96t7Kc8yvBDNssmFQwNe26rHtc32Ag4AvkuWuNRcs1kSEjpsSfKjh786bK+PqjzSnNbT0c631iFwyCOD//eaCv+8FT+1NTw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=digi.com; Received: from DS0PR10MB6918.namprd10.prod.outlook.com (2603:10b6:8:136::8) by PH0PR10MB4696.namprd10.prod.outlook.com (2603:10b6:510:3d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.18; Wed, 28 Aug 2024 01:13:28 +0000 Received: from DS0PR10MB6918.namprd10.prod.outlook.com ([fe80::3697:c0ef:caee:24ae]) by DS0PR10MB6918.namprd10.prod.outlook.com ([fe80::3697:c0ef:caee:24ae%5]) with mapi id 15.20.7918.017; Wed, 28 Aug 2024 01:13:28 +0000 Date: Wed, 28 Aug 2024 11:13:21 +1000 (AEST) From: David Leonard To: Frank Li cc: linux-arm-kernel@lists.infradead.org, Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Linus Walleij , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH 1/6] pinctrl: ls1012a: Add pinctrl driver support In-Reply-To: Message-ID: <41b62521-63ce-e1d1-065f-d84b17da2b58@digi.com> References: <8cd0b743-4fff-e17f-9543-d2d4d7879758@digi.com> Organization: Opengear Digi Content-Type: text/plain; charset=US-ASCII; format=flowed X-ClientProxiedBy: SY6PR01CA0012.ausprd01.prod.outlook.com (2603:10c6:10:e8::17) To DS0PR10MB6918.namprd10.prod.outlook.com (2603:10b6:8:136::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB6918:EE_|PH0PR10MB4696:EE_ X-MS-Office365-Filtering-Correlation-Id: e12664a4-a394-4c5f-d2e5-08dcc6fe9f9f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ZLQArqTUvgqwdZtXxLlJY5IjC1mOqXin2fLz4Sy3Bbs4Bx/ulFyPnEdJyzOh?= =?us-ascii?Q?t0W85WixwZOp5yJKbdHcZ8ydvB3UR8E6cIVTOqoQSBakZeBeWqLPls0G8DQu?= =?us-ascii?Q?jMHto6+hDJfOzQ4Jh7Ky2csyGtkCwnjG0wJ7hI4KR3qRHfoXM8Ft0a/GRwwx?= =?us-ascii?Q?ZtizCePZaHHdMtekc0ZrhxDrhl+xE/L3EN+OKYqNKLbzQDrOumaPejxZ1kVw?= =?us-ascii?Q?xgDWxxFFzVXtDLXoLEIjZv9jadGuPgD0jYzksGlvF30Y8/3lZSzyHw9tp9ln?= =?us-ascii?Q?WY6Fzk5kWe4tERIwzxrPeBMv+oKQ/DxFZlyMBCDS76EnfrAWXS+utQ36FobK?= =?us-ascii?Q?LDXqsW/OeGg3Ab2n65R39BTALPJTzh/lsGiLOQ1WFoH76i/gOksVEitSjsFh?= =?us-ascii?Q?8pQ28+92Md9QQYx4tpb3QfvrVm3OrlwiKGsY+NUDoeWznWwPEgKitPskoIC/?= =?us-ascii?Q?RJ+59kn94NxF3SL1EP9IfxcDMZIFBt8fQqi9IuyKJawZLbqhIVutWDggy0zp?= =?us-ascii?Q?lBgEWHIG+3TpFV+bk0dbQm5ZXc5EvqwufFH90T2vC1GCVzh/LrOLQwskZcjs?= =?us-ascii?Q?0VTIbSF+wk14nqb9jy0JY5lLRn2CEl1vBSOmcw/81e/1ASt18Z6pI57GEu0Z?= =?us-ascii?Q?dktTmPsH2MLSIbpPX2Q268fUGl2LOp0yROTaU3A5T+lhjlG+0RcCFmKPfeyV?= =?us-ascii?Q?dvZa7rtFXS4MyrCgmsHqhCOGUuhST9I6NFoaBaUXmhhBqMmv956+kOrYoP/e?= =?us-ascii?Q?BKZBd0mcN9Vd4zOID+HNCoe+cZ1jn8yyzPdZvXjcD129VlcSwtgARzKRovT4?= =?us-ascii?Q?PyC5jCTJ6+1HeWdzB0YZvCGG5Yd+c4rkkar11QfHOctmkF89pTYAOVD3/qto?= =?us-ascii?Q?viUvBcpicuz/YFw1XkhAlQEFpVAKE4wiKxevi48gutRhnNo4OE1s4r5YehZ5?= =?us-ascii?Q?k4tn5RpRTs268d8Kxc9MkqJIJUOyTZyuRWRHSn3Pi7/xsJKwxgb8Zrkxef3p?= =?us-ascii?Q?parypc0YHidsUg4BAqCXDnsLIHu7mYlvCVieE0sik7eMEkXMFRxTtyxc1CzW?= =?us-ascii?Q?MBh68qjEFZsKhIejeEkTUHKstBcx4+DlX4PzAHhuZ+flsH3eqld+77hUT65Q?= =?us-ascii?Q?RaHGKrpOgBta0MWeuh3Z2MSNZf6CkLEp+9AUB0mSmh7cUaGBWukHC9vMLbSK?= =?us-ascii?Q?awV5EXiGDOmb5mnH5L//WwCf4mDhyxEYVpyW9ocKAtyBGr0WzmwePUoqyTTV?= =?us-ascii?Q?/gnbk5MGiE+zEL2/8krn4G0zAluUbBw9qGsXVKTATMfJUDxxo4FOADDLFicO?= =?us-ascii?Q?bI68y49Yb0EcywZHm/845QxAkDJf4qPqmR2/lvsHOipJXA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB6918.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VZpO7kLP9QGZaSDnJIJxzg6CSR+BnhK/Y7o1c9FoUF+U9VtqNlIOsGtBS1AQ?= =?us-ascii?Q?qsIttESNNbg1L7gakRE0byB5DSm9z9+IIUyeXs1QaPm8L4aTf+DTBl8R/28V?= =?us-ascii?Q?0AnozgJScgmm9f8XxLk3mK2V+P0emTmAzCLBXu63WGwJQOBjEGzvsyFakxsv?= =?us-ascii?Q?9I3uBKUy3gO74MQkXsDW2eX7Q5Z4XZEwLI9A2lKWvx+H9mKWAk8MBAMdlBdO?= =?us-ascii?Q?PhreJDgb9stDph/LogAQSbUimJ0HLjnCaPRwhGi5wwDrKmaGV8gAiQLRiBN3?= =?us-ascii?Q?RyB+PmtimAJ8fzv5PacDSPGJN/Mynrl1oeQW7LNSOyeBabmLlEM4VZB83/pS?= =?us-ascii?Q?tUSGArII7hMN8nFhYwji9ZLreqFNC0WuqY31t20/qp0poKo65W07A0ZIkvlp?= =?us-ascii?Q?ZHtQiY8do2mjgZERYeD3q9x2S8dQMsM8XMMu5ZMkQ7twHddWoONlYfULg4Yt?= =?us-ascii?Q?F6p3MdF9oy4MQcfgUJFq3aAsAwcUYpS0+iD1AyBd+tBJocXzcYmbgc71TbnU?= =?us-ascii?Q?Rd5s2Rbv+5ks4Bd1H9bC9UWjmdmf8iojf7/gwzzrF6lvX6D+bdJthsbrtBT1?= =?us-ascii?Q?wymPUcsnxkVdGXI9wsgjB1TwoK9deEfpNS0DbP5IDl/v+9KkiB3oenXOZPY4?= =?us-ascii?Q?4HTXA6+/gBNsf7Y7TF1voOnYt2jFdKzip6HTOYVg2XJcvaHpYNOaj3nfE64t?= =?us-ascii?Q?Q4v2fIllTRvhxpdFhQ7ju5JbewMFRfrwC8dP+G4ofRQW15gsLuPNyOsg68uk?= =?us-ascii?Q?XWRCWuDVcpMH1tNXDEvy3Mc2gmoiKUzJmZVRZ1WEWRll7+vxw9yBaFlbLfiG?= =?us-ascii?Q?vChQGj/UG/iRq/W9QRCSeXLqoNcZU+Usv5tCAg3WB/GEVjM5/M3Ut7qYooQL?= =?us-ascii?Q?bxraHddOvu9vM1o4N+6KCUGmKVpsikIfow0nHUrGMJFTrMdM4pwo4+KOcd/3?= =?us-ascii?Q?Z6ADIRGeb1ya3NyV0pqzxq73gqhy57IcyrTY5uN74MKqZ8S54xDMzMkS2vLw?= =?us-ascii?Q?5AK68+EcuGRHDi3BBVz6VpF532Hnzj00dMhvpC86acJrumfdxYhM9EvCIA+w?= =?us-ascii?Q?WtZkProsFzpYDBcKjbwxoDkLIn72q3sq36k+zPJOknb/B7yK+wrhAVv9pmWg?= =?us-ascii?Q?mkgNiDN/lGi0GdkwcQZ75meLHT+SNTF8T+2M4gXOrSxtILyr107nbleAGmla?= =?us-ascii?Q?Na4dAVVaMIlVG8PxPXpKiKCpUq5/qZvhwwqTW7gs+vqgtCB3yqTAJsD5L+bH?= =?us-ascii?Q?Wf1U5ZfxrdgJmC3HeQySkI5XKghq//zmXOzPSa/+eJ7j6cnzWYkhToOJZhQl?= =?us-ascii?Q?9uev9y+rW1B67rlYNT3gvOcgDpUtpmaUE6uo4yV/MToffxSr0HWBkKmhus4z?= =?us-ascii?Q?Pq0Y8lYDSNbOpG/8461rjrLFc9Uxds8kcN/szYBDitkV5f8cafFnTmE0Yrpm?= =?us-ascii?Q?aAKtzCBUyBFFMGpjyZLrilr/fo/w08MvV96yLST6+n//amsX/2gm3e83GB+b?= =?us-ascii?Q?a61lKYMJ20I+m2TbAqO2F2klrcYrxo1dibzj0YV1dyvJLZNq8N5gAcWKC1fm?= =?us-ascii?Q?IlVsc0D5Ftbv6AIoT2xVCGVLghImSEav+fzzgfMyYDzxcjPU8JThQbknOAbQ?= =?us-ascii?Q?XapQahb2cAKuz0t4Z0pPU8qqzsRMmtx2WodIUefSVAdl?= X-OriginatorOrg: digi.com X-MS-Exchange-CrossTenant-Network-Message-Id: e12664a4-a394-4c5f-d2e5-08dcc6fe9f9f X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6918.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2024 01:13:28.3202 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: abb4cdb7-1b7e-483e-a143-7ebfd1184b9e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NwCUxQzhjfOv65SzQfzxLDxejknYgI0FfAhMyZwewvCoVpefBgL7hGazOJ2m1Yu3gNYQ3NWdf3Z/MD+bYpjU1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4696 X-BESS-ID: 1724807612-105582-4629-59963-1 X-BESS-VER: 2019.1_20240827.1824 X-BESS-Apparent-Source-IP: 104.47.66.46 X-BESS-Parts: H4sIAAAAAAACA4uuVkqtKFGyUioBkjpK+cVKVoYWJmZAVgZQ0NTMLM081cLYIi 0p0TTR0tjE2CQpLdEsJSUtNcnYIMlCqTYWAF/ot1lBAAAA X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.258643 [from cloudscan23-169.us-east-2b.ess.aws.cudaops.com] Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS112744 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status: 1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240827_181342_812748_9639CD62 X-CRM114-Status: GOOD ( 15.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 27 Aug 2024, Frank Li wrote: > On Tue, Aug 27, 2024 at 12:05:24PM +1000, David Leonard wrote: >> Add QorIQ LS1012A pinctrl driver, allowing i2c-core to exert >> GPIO control over the second I2C bus. >> >> Signed-off-by: David Leonard >> --- > > Why not use pinctrl-single ? > > You can ref arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > It did similar thing to use GPIO recover i2c bus. > > Just need change dts file. This is a great suggestion for the LS1046A and means I could withdraw the "fsl,ls1046a-pinctrl" driver, which I'll do. But I don't think it's suitable for use with the LS1012A. The reason is that the the LS1012A's pinmux register PMUXCR0 is more complicated. It has a global override bit, overriding the "backing" RCW configuration for 3 pingroups. In addition, when overriding, the PMUXCR0 can only supply a subset of the functions that RCW can. /* * LS1012A * Group: qspi_1 qspi_2 qspi_3 * ================== =========== ============= * Pin: 62 123 124 61 122 60 * ----- ------ ----- ----------- ------ ------ * i2c SCL SDA (RCW only) * spi SCK DATA0 * spi SCK DATA0 DATA1 * spi SCK DATA0 DATA1 DATA2 DATA3 * gpio GPIO4 GPIO11 GPIO5 * gpio GPIO12 * gpio GPIO13 GPIO14 * gpio_reset GPIO13 REQ_B (RCW only) */ In particular, when PMUXCR0 is overriding RCW, it can't provide "i2c" or "gpio_reset" functions for qspi_3. It can only provide "spi" and "gpio". The fsl,ls1012a-pinctrl driver recognises when you are asking for the configuration that the RCW can provide, and diables the override. Cheers, David