From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0AF5C43381 for ; Wed, 13 Mar 2019 11:34:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C15712147C for ; Wed, 13 Mar 2019 11:34:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DCMqUTgA"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="cryBTL3G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C15712147C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MlSkZLZYRpN93Mpz9QY3ujoPKsP/G5ZcL5oBfkEgqI8=; b=DCMqUTgAogOY4C ID+OjEG1bGZpVvc3ieXrABnRyxOJm9pQpAUXwBYNGF4UB4ZIrjSjW5sAXmGLayDkXH0+DnuaWOStd CknxWOMvbOaUj+bgzBhbryE4TlXa4fThX6RzLvVLqjdXRTXkFwMPcVXyL52viudZXwJrrjtR7vD8d JfRZYf/VLUtUig+Q19iFwOgvXbaynyp/AzIABvxjuiHSn9MVw7qp+13cstSZtzPb6kWTm5GdoQw07 4Urg91FXHbrqyMut2rBdjWrPxRw4Ko1vEr9tY2C3u08tgrQpipAFiG1yEcRtY6F7gGGkqcwW1pCcg 1RcBrwk60KzRKLeA0m1g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h429K-0004Cf-Nj; Wed, 13 Mar 2019 11:34:18 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h426y-0001AS-9b; Wed, 13 Mar 2019 11:31:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=lou3VngaPxxniip+Zkb6HNcgpVyCuqIy7Qq25J7WM7A=; b=cryBTL3G6zYQ2/Ch/OeaYB7MQT XBnj1k09U1+JfMpol3Jpf53fHsCCC4xLPhWdOlbtOmA7zON6h2WVhkePsheS+PG61l1eFTCLtOiDq MwrlHo+3tM//rA7cJDQi1rRR+cZOkQu2OK62NUn4F9arByvWEjgtBHBbwXuBnuHH1kdlVnBCj2/kh Wa8mKkt6ypp/C/XFAltVBlOhHin/trD+pMw3fgDg1uC558jDaojqqYO1xpx6ferQmDQ7hOFf7mLfV +kB3bnB/imKGiWtIQitR8Ro5Ca6y1XVb7T/quqmDhHj7s9Mqoj2J2JaFCs5coIGwikAI1hVUYSdEi 4m8IpT8w==; Received: from gloria.sntech.de ([185.11.138.130]) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3oQ9-000626-V4; Tue, 12 Mar 2019 20:54:47 +0000 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1h3oO7-0004nO-C5; Tue, 12 Mar 2019 21:52:39 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: David Summers Subject: Re: [PATCH v3 1/3] arm: dts: rk3288-tinker.dtsi: Fix SD card detection Date: Tue, 12 Mar 2019 21:52:38 +0100 Message-ID: <4202578.jOHf0ez5fE@diego> In-Reply-To: <4a1ad220-103d-543e-56d1-3c6d6ad906ec@davidjohnsummers.uk> References: <20190217121513.22965-1-beagleboard@davidjohnsummers.uk> <50094675.5IylMcgSg6@phil> <4a1ad220-103d-543e-56d1-3c6d6ad906ec@davidjohnsummers.uk> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190312_165446_133105_49B2B63E X-CRM114-Status: GOOD ( 32.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, ulf.hansson@linaro.org, Jonas Karlman , linux-mmc@vger.kernel.org, jh80.chung@samsung.com, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, frowand.list@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi David, Am Dienstag, 12. M=E4rz 2019, 21:34:00 CET schrieb David Summers: > On 12/03/2019 14:22, Heiko Stuebner wrote: > > Hi Jonas, > > = > > Am Samstag, 9. M=E4rz 2019, 16:39:21 CET schrieb David Summers: > >> The Problem: > >> = > >> On ASUS Tinker Board S, when booting from the eMMC, and there is card > >> in the sd slot, there are constant errors. > >> = > >> Also when warm reboot, uboot can not access the sd slot > >> = > >> Cause: > >> = > >> Identified by Robin Murphy @ ARM. The Card Detect on rk3288 > >> devices is pulled up by vccio-sd; so when the regulator powers this > >> off, card detect gives spurious errors. A second problem, is during > >> power down, vccio-sd apprears to be powered down. This causes a > >> problem when warm rebooting from the sd card. This was identified by > >> Jonas Karlman. > >> = > >> History: > >> = > >> A common fault on these rk3288 board, which impliment the reference > >> design. > >> = > >> When this arose before: > >> = > >> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-August/2811= 53. > >> html > >> = > >> And Ulf and Jaehoon clearly said this was a broken card detect design, > >> which should be solved via polling > >> = > >> Solution: > >> = > >> Hence broken-cd is set as a property. This cures the errors. The > >> powering down of vccio-sd during reboot is cured by adding > >> regulator-boot-on. > >> = > >> This solutions has been fairly widely reviewed and tested. > >> = > >> Signed-off-by: David Summers > >> Reviewed by: Robin Murphy > >> Reviewed by: Jonas Karlman > > = > > in v2, you gave a > > Tested-by: Jonas Karlman > > it seems, which somehow transformed into a reviewed-by in v3. > > = > > V3 did change a bit in its approach - for the better, but do you approve > > of adding that Reviewed-by above (and maybe also providing a Tested-by > > for the new approach)? > > = > > Thanks > > Heiko > = > Hi all, > = > Yes apologies for these signed-off lines etc wrong. Its still a learning > experiment for me! > = > Both Robin and Jonas added a lot to Patch, as explained in the write up. > Robin came up with the cause of the fault, and Jonas noticed a second > fault. So the question is to give these two their due. I think what they > both added was important. > = > Thanks Robin for the official "Reviewed-by". > = > Jonas tested the second version, which kept power on vccio-sd all the > time, whereas v1 and v3 cured the problem with broken-cd. So although > both fixed the problem, they way performed is different. So don't think > I can say Jonas Tested-by v3. We'll just give Jonas a bit more time to reply then :-) . > As for the tested by "TheSaint @ ArchLinux Arm", he actually tested just > above every single version of the patch, and a whole lot more before it > was sent in - he is our ASUS Tinker Board user on arch. He doesn't > really want his email in the open, but if push comes to shove he'll > allow it. Question is do you need this for the Patch to pass? No, that is not necessary. I'll just drop the line when applying. In general for a tag to mean something we need the Name, but any tags other than Signed-off-by are optional anyway. > Heiko, I'm happy to change the sign off etc, and resent the patch (as > v4). But would be the same patch. Think the question is what is best for > you. Don't want to send unneeded email ... anyway let me know (private > email?) and I'll do whatever is best for you. No, re-sending just to correct tags is not necessary in _my_ case as I generally just fix up the relevant lines myself when applying. Just keep in mind, other maintainers may handle this differently :-) . > P.S. Eventually I'll get better at these patches , alas the day job > keeps me too busy - and I forget the rules :( Really no problem, it's always a learning experience. So don't worry too much :-) . Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel