From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7AB7DC25B06 for ; Sun, 14 Aug 2022 10:35:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WjE7Hr1m91gJ3QPs5ikE7CFAgYWL/LD0dUejkxVX9O4=; b=pYjj639Ze8BLOK AYhjU5Y42G3OR7Ftx4jitsy1LisRYafo8Raj4OuDYbbd2J+W4je0VWbnyQW5Pzbf4lNSqLzs4KPzP Qt9NNCUX9Ugqis12UC3iTghcy0gm94ND6XuO80oKAOaKurCcS0VtJl7Nq1e7Bi/YztLWY10ymG0CG YlrwKMiV79IkrgXZMuqRM0zuvDyJAorNAJHnnn0Q4HlkYqwRp8qjmBc9cjzoyIisBFPhg8yPA4BWm 0HdW1jO+9VkJOCLUzzFoT+72ArlYcmGpBXFZ/oHyLf+jHyTnt1qo6pYoEycIjo2TsKdjM4cY7n4Bg 90JxvrUqsE+1AZHU1uYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNAwh-005sec-G3; Sun, 14 Aug 2022 10:34:15 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNAwf-005sdY-39 for linux-arm-kernel@lists.infradead.org; Sun, 14 Aug 2022 10:34:14 +0000 Received: by mail-ej1-x631.google.com with SMTP id gk3so9085063ejb.8 for ; Sun, 14 Aug 2022 03:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=wzo/x007uCa6HXfMQAlfCGpeZPzzBdlngiaw5dHiDKo=; b=TRjw2/aFGxFEPk773kgZUbxVW7yh9qhMpDpQo3Y796X6EV/1Ec/ZY05nU90L3Cpt/A f1aqu+MMBpw80UIDHv6fghQCmkf75jcR/WU1g90lMwxo1xeAtlbpgotJ4YTuNKsr4Lfx s/LcbiMvKF74XhX6E9ZVKolfX5GQRnEmzf5OuN7/33R3Dt6Et8on9JXVb9G8RqpqZyzC ZsUegrj1hPQa2YARtOSh+ZxWGtnROHrkfLThuFaRzuI/3j+2waMRAA9gKW3jHivF5xRs nDsX6+rJ9vewzZETDFmhN2DYEzYK4lbZeaqEy675YWz0HdkANyrKQpF9FrgSFw04f+pV rtcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=wzo/x007uCa6HXfMQAlfCGpeZPzzBdlngiaw5dHiDKo=; b=WzQWXyCScMmTQ94Tmv3iM6YLeV8VijdN1X10ZuLWJohahFgR6UwqqyOR2FyoaJLqIV jSBXLaANjmw2J8luEziMIKevWhKTn3VDk6htmZtQ9RoFkbkP7Ka+Ca0HJF97Zaz/xlQ3 JrO+Rk7f0N/XYdT4nlR0exDODOi06Udp0D8tbz0g5Wkqh1+iRPsmaGM5J7ENui6GoI+6 DnfIcdBeovcBvhxZWWqa4mGqdM74YKL7qy5M4tTPQOyfZgYZApAKKJ25yfZYdy5yJfCG CKlbxVDMNsSc6Su7dgtajZPSyh340yd3iuOKjQn66ezx3SKLV53W7PJEzPTSBv+Rd+CR 4o/A== X-Gm-Message-State: ACgBeo33j+t6nwv3+sj2GMKLEoAvuO6lc5nQzNkOZz+csVpTsoLjSwnH eM1638xJmJOjVBW8DjXhbKQ= X-Google-Smtp-Source: AA6agR68vjtEeSmB4p3tGG238cu9MyJhZ+D4gcaOReUeNSdAs6XkWbWsaUH4Xda/O4ruBuUwqT21Rg== X-Received: by 2002:a17:907:288a:b0:730:996d:c605 with SMTP id em10-20020a170907288a00b00730996dc605mr7191809ejc.682.1660473250865; Sun, 14 Aug 2022 03:34:10 -0700 (PDT) Received: from jernej-laptop.localnet (89-212-118-115.static.t-2.net. [89.212.118.115]) by smtp.gmail.com with ESMTPSA id n11-20020a17090695cb00b0072f9dc2c246sm2764897ejy.133.2022.08.14.03.34.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Aug 2022 03:34:10 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Samuel Holland Cc: Samuel Holland , Arnd Bergmann , Hans de Goede , Icenowy Zheng , Krzysztof Kozlowski , Maxime Ripard , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 4/9] soc: sunxi: sram: Fix probe function ordering issues Date: Sun, 14 Aug 2022 12:34:09 +0200 Message-ID: <4204539.ejJDZkT8p0@jernej-laptop> In-Reply-To: <20220801030509.21966-5-samuel@sholland.org> References: <20220801030509.21966-1-samuel@sholland.org> <20220801030509.21966-5-samuel@sholland.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220814_033413_238238_1D198147 X-CRM114-Status: GOOD ( 11.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 01. avgust 2022 ob 05:05:04 CEST je Samuel Holland napisal(a): > Errors from debugfs are intended to be non-fatal, and should not prevent > the driver from probing. > > Since debugfs file creation is treated as infallible, move it below the > parts of the probe function that can fail. This prevents an error > elsewhere in the probe function from causing the file to leak. Do the > same for the call to of_platform_populate(). > > Finally, checkpatch suggests an octal literal for the file permissions. > > Fixes: 4af34b572a85 ("drivers: soc: sunxi: Introduce SoC driver to map > SRAMs") Fixes: 5828729bebbb ("soc: sunxi: export a regmap for EMAC clock > reg on A64") Signed-off-by: Samuel Holland Reviewed-by: Jernej Skrabec Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel