From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PCI: Fix logic OF logic in pci_dma_configure()
Date: Thu, 19 Nov 2015 09:23:43 +0100 [thread overview]
Message-ID: <4205822.O3dsjd4r6S@wuerfel> (raw)
In-Reply-To: <1447894192-17210-1-git-send-email-Suravee.Suthikulpanit@amd.com>
On Wednesday 18 November 2015 16:49:52 Suravee Suthikulpanit wrote:
> - if (IS_ENABLED(CONFIG_OF) && dev->dev.of_node) {
> - if (bridge->parent)
> + if (IS_ENABLED(CONFIG_OF) &&
> + bridge->parent && bridge->parent->of_node) {
> of_dma_configure(&dev->dev, bridge->parent->of_node);
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
I was wondering for a bit whether we should warn about the case where there
is no of_node pointer, as that would mean we cannot do DMA on that PCI
device, but on second thought we have to do it exactly like you do, because
we would otherwise break machines that do not use DT.
Arnd
prev parent reply other threads:[~2015-11-19 8:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 0:49 [PATCH] PCI: Fix logic OF logic in pci_dma_configure() Suravee Suthikulpanit
2015-11-19 0:54 ` Suravee Suthikulanit
2015-11-19 1:56 ` Rafael J. Wysocki
2015-11-19 8:23 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4205822.O3dsjd4r6S@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox