From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFDBBECAAD2 for ; Sun, 28 Aug 2022 11:28:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NHafw53sAP/wD3MdZTvOyzuHT5HQN43YRXrgu9LfVR4=; b=qiMwxgUgLk1mcI30lMEOHTzz65 p8+8wXcT6Xf3Zo0PUtK8TzuN0orYVNwHdfswb/4d41WTu5s2QQvGC3247//Uv5lOuEIJqjjlNoncZ IafPYlUt+4tbWObs6UEF5/C/fWaEq5bIVYUkvFQAIl9JA2d7vLXSkfeL3LLw5IBYBBLiuUi34G0jE Ygq0LCzHYFDV8rBfB/iUSOBt+BvGeRiebXbC/wdrbHmfhDSTX/hSMvP4csgWUS9r+LFb0HbXAJ8u6 77OyMwdaPrm1R1mcSyi5e4FvCnd95Uibk02DTS0UJ3MrRSTB6Xar/MF3R/a2bCdtyrLKJvk0Z19uL LZ2zEWTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSGRd-00GRYs-Et; Sun, 28 Aug 2022 11:27:13 +0000 Received: from mailout-taastrup.gigahost.dk ([46.183.139.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSGRa-00GRXM-76; Sun, 28 Aug 2022 11:27:11 +0000 Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id 9A5F018846A8; Sun, 28 Aug 2022 11:27:08 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id 8DC6425032B7; Sun, 28 Aug 2022 11:27:08 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id 788FE9EC0009; Sun, 28 Aug 2022 11:27:08 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Sun, 28 Aug 2022 13:27:08 +0200 From: netdev@kapio-technology.com To: Ido Schimmel Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Christian Marangi , Daniel Borkmann , Yuwei Wang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 net-next 2/6] net: switchdev: add support for offloading of fdb locked flag In-Reply-To: References: <20220826114538.705433-1-netdev@kapio-technology.com> <20220826114538.705433-3-netdev@kapio-technology.com> User-Agent: Gigahost Webmail Message-ID: <4206d70598694689acf6b6ec30ef6523@kapio-technology.com> X-Sender: netdev@kapio-technology.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220828_042710_436304_6F2E9AE1 X-CRM114-Status: GOOD ( 10.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-08-27 17:46, Ido Schimmel wrote: > On Fri, Aug 26, 2022 at 01:45:34PM +0200, Hans Schultz wrote: >> diff --git a/include/net/switchdev.h b/include/net/switchdev.h >> index 7dcdc97c0bc3..437945179373 100644 >> --- a/include/net/switchdev.h >> +++ b/include/net/switchdev.h >> @@ -247,7 +247,10 @@ struct switchdev_notifier_fdb_info { >> const unsigned char *addr; >> u16 vid; >> u8 added_by_user:1, >> + sticky:1, > > If mv88e6xxx reports entries with 'is_local=1, locked=1, blackhole=1', > then the 'sticky' bit can be removed for now (we will need it some day > to support sticky entries notified from the bridge). This takes care of > the discrepancy Nik mentioned here: > > https://lore.kernel.org/netdev/d1de0337-ae16-7dca-b212-1a4e85129c31@blackwall.org/ > >> is_local:1, >> + locked:1, >> + blackhole:1, >> offloaded:1; >> }; Right! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel