From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B0E1C3DA7D for ; Tue, 3 Jan 2023 13:06:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M8owXs2DSVpAcpwpVgZGH0CM7Jbh2A6a8CYeKLkEtZs=; b=BcJre2POmIuw3p oIh9llVMOduD4K0cSiNMdWgZ6O6VAAD7qjhC1QdyK59Mp1srSY9Elm+3Yo9gywv38rS2baDmP/TsO alF6DpaoqWGffMRwG+XMbO649Dq73IVdJ1xr9HiJiQh51vT53DxdF2HwLwM+1NEzvhxARmJ9iGSus nCuAYvPJLjNKVtqdZ6dWA/BaXnuGdir3l9TJG504981C30i8pcTR6LwqVpVSjNrRYmnPyQYRLZK6H w8gpAIwX8l623USZn9rN5zIj/SX1s21Xc4G3SOSL8w9xqwdDcu3eo4+BebqnTNqF0m+pSHLdPRreX o8Pzs0nm/zzSrColvdxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCgyc-001Nuz-5A; Tue, 03 Jan 2023 13:05:10 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCf1E-000rrB-R9 for linux-arm-kernel@lists.infradead.org; Tue, 03 Jan 2023 10:59:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1672743584; x=1704279584; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Gh3yRSY+KvlOYYE/yy3UxkbN3yWG+945NgZEhhGA+bM=; b=nLakzWes/KliJp381Tn+hlagt+SGAqt8gN4JjcaBdyO5kAzsM8XwTIsS u9JeDFRQKS1tEgcDnrN+lhmvm9114eA/PLrRZBuKPzvPcpQ/Hz0c1P97c Ls7U6nH1OtT1TwDyy64R7rqAazEfwMDDCSd6t8krmI2kw5NiU5p5SPF0O 2qHTalXJ0TBpIB2oOnNRHRbfplMqbXoTUCFzrDqHZ06SElwDzppGa6o9C fWAAo13NM2kb1DWjSyS5ZUm3wWvvTE+NgxjW6J4O3ZaU/8rGsfP7jZ2qb D1/vz6Hrs60m+hvnMpCIjRiTNYzJdb4e0ZT9R4uhNI3vG0nm5hen9RXvT A==; X-IronPort-AV: E=Sophos;i="5.96,296,1665439200"; d="scan'208";a="28219621" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 03 Jan 2023 11:59:40 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Tue, 03 Jan 2023 11:59:40 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Tue, 03 Jan 2023 11:59:40 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1672743580; x=1704279580; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Gh3yRSY+KvlOYYE/yy3UxkbN3yWG+945NgZEhhGA+bM=; b=JCbXz9/WxmhyxISPktlaUMG2YQAgoPJq1v4YL/pE98S8wMwPVxS90sVD kzA6Ka1KI+XjyZxvT53xZD+SNaLODfzNfP8x5MIrK3E7ryNj0oQsNrWyo WQ7XlkFnotyCzBhtFrNLSauj/TUun2NnYl2UmlYDJLLdqEcmDvnyxXcj3 PQptbQelJBbnLvm7LPvoeg/220NIR8Qd/PkeuKGIlQTUajsiuLLtkjljD ybgVzB+LC9UEmf6+VjvvcGWqdaWNU10Nv2ZIm2jnmLtMwN0qrwzOZ86Zj y07/Kta1zPpp5zhUf6moYa9/C6T5G95uIcyiQSHnlvdWXIrSzEe2o3YQd A==; X-IronPort-AV: E=Sophos;i="5.96,296,1665439200"; d="scan'208";a="28219620" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 03 Jan 2023 11:59:39 +0100 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 732EB280056; Tue, 3 Jan 2023 11:59:39 +0100 (CET) From: Alexander Stein To: Adam Ford , Marek Vasut Cc: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , "dri-devel@lists.freedesktop.org" , "linux-samsung-soc@vger.kernel.org" , Matteo Lisi , NXP Linux Team , linux-amarula , "linux-arm-kernel@lists.infradead.org" , Jagan Teki Subject: Re: [PATCH v10 00/18] drm: Add Samsung MIPI DSIM bridge Date: Tue, 03 Jan 2023 11:59:37 +0100 Message-ID: <4207863.mogB4TqSGs@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <449d03be-226f-9a90-aff3-8afee68c346d@denx.de> References: <449d03be-226f-9a90-aff3-8afee68c346d@denx.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230103_025946_576157_FEC1D50C X-CRM114-Status: GOOD ( 41.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Sonntag, 18. Dezember 2022, 23:28:20 CET schrieb Marek Vasut: > On 12/18/22 23:24, Adam Ford wrote: > > On Sat, Dec 17, 2022 at 10:33 PM Marek Vasut wrote: > >> On 12/18/22 05:23, Adam Ford wrote: > >>> On Sat, Dec 17, 2022 at 5:56 PM Marek Vasut wrote: > >>>> On 12/16/22 14:25, Alexander Stein wrote: > >>>> Hi, > >>>> > >>>> [...] > >>>> > >>>>> Oh, nice, thanks for the pointer. When setting > >>>>> > >>>>>> samsung,burst-clock-frequency = <668250000>; > >>>>> > >>>>> in imx8mm.dtsi > >>>>> I get a non-flickering display using 4 lanes. Although admittedly this > >>>>> is just random guessing. I'm not sure which clock exactly has to be > >>>>> in the range CHA_DSI_CLK_RANGE is configured to. With 4 lanes > >>>>> SN65DSI84 is configured for>>>>> > >>>>> 205-210 MHz (0x29), while I get these PLL PMS settings on DSIM: > >>>>>> samsung-dsim 32e10000.dsi: PLL freq 668250000, (p 4, m 99, s 0) > >>>>>> samsung-dsim 32e10000.dsi: hs_clk = 668250000, byte_clk = 83531250, > >>>>>> esc_clk > >>>>> > >>>>> = 16706250 > >>>> > >>>> If I recall it right, minimum PLL frequency is: > >>>> > >>>> fPMS=1.2*width*height*bpp*fps=1.2*800*480*24*60=663.5 MHz > >>>> > >>>> the link frequency is then > >>>> > >>>> fHS=fPMS/lanes/2=82.9 MHz (on the DDR clock lane) > >>>> > >>>> So DSI83 should be in the range of 80..85 MHz input clock if I > >>>> calculate > >>>> this right. Can you check what is the value of mode->clock, the > >>>> mipi_dsi_panel_format_to_bpp() return value, ctx->dsi->lanes in dsi83 > >>>> sm65dsi83_get_dsi_range() ? > >>>> > >>>>> AFAICS DSIM bridge is configurung hs_clk, byte_clk and esc_clk just > >>>>> from DT > >>>>> properties, while SN65DSI84 is using display mode and number of lanes. > >>>>> > >>>>> Is it expected that the DSIM PLL frequencies are set in DT for a > >>>>> specific > >>>>> bridge/display setup? > >>>> > >>>> No, there should be negotiation between the host and bridge/panel, I > >>>> tried to propose two variants, but they were all rejected. > >>> > >>> For one of Jagan's previous revisions, I added some code to let the > >>> PHY auto adjust the frequencies instead of being fixed. NXP had this > >>> in their downstream kernel, but with this patch and another, I was > >>> able to set a variety of pixel clocks from my HDMI monitor and my > >>> DSI83. I haven't had time to re-base my work on Jagan's latest work, > >>> but you can link to the patch I did for the older stuff here: > >>> > >>> https://github.com/aford173/linux/commit/e845274b0f22ba3b24813ffd6bb3cb8 > >>> 8ab4b67e4 and > >>> https://github.com/aford173/linux/commit/3f90057eb608f96d106029ef6398134 > >>> 75241936f > >>> > >>> I've been traveling a lot lately, so I haven't had time to evaluate > >>> his series, but I hope to get something like those re-based once the > >>> DSI stuff has been accepted. > >> > >> I have these two attempts, both rejected: > >> > >> https://patchwork.freedesktop.org/patch/475207/ > >> https://patchwork.freedesktop.org/patch/496049/ > > > > I have some patches re-based to Jagan's latest branch. It doesn't > > impact any drivers other than the new samsung-dsim driver, and it > > doesn't touch any of the drm helper functions either. It adjusts hs > > clock based on the connected device. I am not sure what the impact > > will have on the attached Exynos devices, so I am expecting some > > iterations. Right now it's working with my DSI83 chip, but I need to > > get it working with my adv7535 part as well. On the older branch, I > > was able to sync the ad7535 with a variety of resolutions using > > different pixel clock rates. > > > > Once I get it working again with my adv7535 and cleaned up, I'll > > submit the patches to the drm group, and I'll CC you, Jagan and Marek > > Szyprowski with a reference to Jagan's series so people wanting to try > > it can apply it to his branch. > > The negotiation has to happen between the host and the bridge/panel, > otherwise you won't be able to support bridge/panel devices which > require specific clock rate on the DSI. Only the bridge/panel driver > knows about such requirement. AFAICS using Adam's patch the dynamic DPHY config is done in atomic_pre_enable callback. So at this point the negotiation has to be finished already. Wouldn't it be possible to setup 'dsi->format' within a atomic_check for samsung_dsim? But I don't know how you would get the expected clock frequency from the downward bridge. Best regards, Alexander _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel