From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65D6AC433FE for ; Sun, 6 Nov 2022 08:10:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bTH05CpYCZUm4ZLJYDaj6I6Lvi+Wam84vMaZZTC0Ot0=; b=BDkgiZUtEJwsT8 vAKzqcPaZ1WxtA5XpMZzPTZKyaa02P7byC/Pdt3jwLH/yZL8oSAbgtH4IANYOrVkYofwsLnkX7Eo0 7GMkNfE6mllic9yRymVNQJ4JxBxT2xPsDoYDad0WhOhLT12iWC/Pbj0kspJtnKkkhsD+4YG0RpQ6a rhD4cLIFRmHFfypFBMsslh1KHIAja9ZjZCX8101VsCXWrvTWJj3jBliyOnX1/q8wcHFS1tVqtHN6V vfRSlIv8/DW9vbL5UErzbJgw4QQcYbetfvIGm/Jf3Sz75t1Ng6QfQ6NuvAfVpTotj4dPlD3YrdgvN 5hAvm8kmTgTWqVE9vJAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1orair-007grn-U3; Sun, 06 Nov 2022 08:09:42 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1orain-007gj2-1Z for linux-arm-kernel@lists.infradead.org; Sun, 06 Nov 2022 08:09:38 +0000 Received: by mail-ej1-x633.google.com with SMTP id ud5so22997258ejc.4 for ; Sun, 06 Nov 2022 01:09:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+pdd8CAL88lzkh5Qvct0XVSbDsIQmPY/9Ujmmsx7WLw=; b=jJ2vI+D6GzRUbKO1+A9EdmeWmj+VTvXG0zWtj5oMtDZjAuHDmet2IUdwRY49GduZhn wgfMg6TOOIdKEnVgv95roCXPG/JVkKvGBIoaogqJhQ+jyatDOCeqJEGifuiOmWY8wdNS xu4HP1Ze42PRAV3ZOJv10o4l3VWBBeygTzVnLfqRW3gOkZN0SLf4QE6ggjCCvmVSPehH B5h5CJyP6KRbCuy9a6piRwMl+4iH315V1v3vTHaVLbpH7yYysSnGRhxltxdDjAsYKeyj 9Y2uCmn5kcs3N8us3DjmDrHw0eEEJV2leb3X69VobygyEqm2oXLwjDtxjW+zwa28wBZG nCNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+pdd8CAL88lzkh5Qvct0XVSbDsIQmPY/9Ujmmsx7WLw=; b=l4U2E0bNwn8D5tghKej/WpE+1oBeXNRn2W7SovNfOr2tEXy6QVPeg/CEei7ipYfF/i jADlr1eOs1WmBsjdSepmMvX4l1vQvhh03Xsp47QuUYGVr/gnzNsxpNXcgh+vq8/c5/wb OLci4FtQP9nrNiheYmKQ2f7+b1jT5GklL1SowEARWPgJ7LCe/2XdnA6XfIHcdXTSzTMz cGoaOX+KF4wz268Y9OMGfxCpDhiFwZsuXBt2RnjsCDmhSzZz+D1NYfQSM6gSzxKf1OEg nt5qRCENoMdgmktRPNhOi/OhpfcKd4ePmX2PsJy7YF4fkOe/nBgUgj9Ya9o6YdMqaPoh 3/bQ== X-Gm-Message-State: ACrzQf2F1H+HEmbXyFcU4A/1Rf5jhXeGqsb/UrmqET3mWsc2rfXzFpOb HkRgJUQk3D/7SmhVfnjBjfQ= X-Google-Smtp-Source: AMsMyM4aMMJKBTGnjmQIfN3CXpAz5TIsD3tKoMlu9whaRzwl2Mca2l/tdFrbf27c9RaTRmxAXMka/A== X-Received: by 2002:a17:907:7e95:b0:78d:e9cf:82c7 with SMTP id qb21-20020a1709077e9500b0078de9cf82c7mr43818369ejc.724.1667722158677; Sun, 06 Nov 2022 01:09:18 -0700 (PDT) Received: from jernej-laptop.localnet (89-212-118-115.static.t-2.net. [89.212.118.115]) by smtp.gmail.com with ESMTPSA id gv57-20020a1709072bf900b007acd04fcedcsm1835308ejc.46.2022.11.06.01.09.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Nov 2022 01:09:18 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Samuel Holland , Chen-Yu Tsai , Rob Herring , Krzysztof Kozlowski , Andre Przywara Cc: devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Icenowy Zheng , Gregory CLEMENT , linux-i2c@vger.kernel.org Subject: Re: [PATCH 4/9] ARM: dts: suniv: f1c100s: add I2C DT nodes Date: Sun, 06 Nov 2022 09:09:17 +0100 Message-ID: <4223066.ejJDZkT8p0@jernej-laptop> In-Reply-To: <20221101141658.3631342-5-andre.przywara@arm.com> References: <20221101141658.3631342-1-andre.przywara@arm.com> <20221101141658.3631342-5-andre.przywara@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221106_010937_115371_A8FE8980 X-CRM114-Status: GOOD ( 16.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne torek, 01. november 2022 ob 15:16:53 CET je Andre Przywara napisal(a): > The Allwinner F1C100s series of SoCs contain three I2C controllers > compatible to the ones used in other Allwinner SoCs. > > Add the DT nodes describing the resources of the controllers. > I2C1 has only one possible pinmux, so add the pinctrl properties for > that already. > At least one board connects an on-board I2C chip to PD0/PD12 (I2C0), so > include those pins already, to simplify referencing them later. > > Signed-off-by: Andre Przywara > --- > arch/arm/boot/dts/suniv-f1c100s.dtsi | 50 ++++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/arch/arm/boot/dts/suniv-f1c100s.dtsi > b/arch/arm/boot/dts/suniv-f1c100s.dtsi index d5a6324e76465..2901c586971b4 > 100644 > --- a/arch/arm/boot/dts/suniv-f1c100s.dtsi > +++ b/arch/arm/boot/dts/suniv-f1c100s.dtsi > @@ -166,6 +166,18 @@ mmc0_pins: mmc0-pins { > drive-strength = <30>; > }; > > + /omit-if-no-ref/ > + i2c0_pd_pins: i2c0-pd-pins { > + pins = "PD0", "PD12"; > + function = "i2c0"; > + }; > + > + /omit-if-no-ref/ Above flag is meaningless if i2c1_pins is always referenced by i2c1. Anyway, I see in pinctrl driver that there are actually two possible pin assignments for i2c1. One on port D and another on port B. Best regards, Jernej > + i2c1_pins: i2c1-pins { > + pins = "PD5", "PD6"; > + function = "i2c1"; > + }; > + > spi0_pc_pins: spi0-pc-pins { > pins = "PC0", "PC1", "PC2", "PC3"; > function = "spi0"; > @@ -177,6 +189,44 @@ uart0_pe_pins: uart0-pe-pins { > }; > }; > > + i2c0: i2c@1c27000 { > + compatible = "allwinner,suniv-f1c100s-i2c", > + "allwinner,sun6i-a31-i2c"; > + reg = <0x01c27000 0x400>; > + interrupts = <7>; > + clocks = <&ccu CLK_BUS_I2C0>; > + resets = <&ccu RST_BUS_I2C0>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + > + i2c1: i2c@1c27400 { > + compatible = "allwinner,suniv-f1c100s-i2c", > + "allwinner,sun6i-a31-i2c"; > + reg = <0x01c27400 0x400>; > + interrupts = <8>; > + clocks = <&ccu CLK_BUS_I2C1>; > + resets = <&ccu RST_BUS_I2C1>; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c1_pins>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + > + i2c2: i2c@1c27800 { > + compatible = "allwinner,suniv-f1c100s-i2c", > + "allwinner,sun6i-a31-i2c"; > + reg = <0x01c27800 0x400>; > + interrupts = <9>; > + clocks = <&ccu CLK_BUS_I2C2>; > + resets = <&ccu RST_BUS_I2C2>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + > timer@1c20c00 { > compatible = "allwinner,suniv-f1c100s- timer"; > reg = <0x01c20c00 0x90>; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel