From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D3C3C4332F for ; Mon, 5 Dec 2022 20:53:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4naW4Ru0rMVpP/DNfC/z4c3+f0W0s1U0GCFyZ17wWh4=; b=ItMBfI5j+Az9ug FtR+z+6wUZiBCZaaZVY77ImhLCyMI271o968zV5RwnQXfwMXp1pj2vTdf8O8EAgBBrn4GvDO5l4HL Kobzi13Coum/KxIlLqsfqK20pKZmyz9O/nkj7dRg8xaJbOj4Q22xvARZSx615hmUvZmGOh5nN7MUW 4xsbVPrp02sgVZKQ3ADLAkEKfU/dzuxMKT9UX+Gu8XFPWkgM8Q9lCo0hIVN7k7mvlet96oMM79MIG 67g9jryF4tBytmT2kqUvxpXYOqu1CbxENj/LUAbS7uZv2roNvxYInPOz4WAK8ZpBQ0hbtvJ7vwmQF gJdvIgiKth5oa+xUnt0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2IS3-00AUbt-7n; Mon, 05 Dec 2022 20:52:35 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2IRr-00AUU3-G3 for linux-arm-kernel@lists.infradead.org; Mon, 05 Dec 2022 20:52:24 +0000 Received: by mail-ej1-x62a.google.com with SMTP id x22so1369167ejs.11 for ; Mon, 05 Dec 2022 12:52:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EUw6Hd+Tb+y6+h8IPlKOEXxbYBmUXjkCM3BqWwxBlG8=; b=Tu0y2YsPn1xteSCPzD/5LdsrIuEIAlXs+99JqYe67QKzQW9c1ZbI6s6ujYamITNDtN fNKvydO8AlCHSYhDHPCsITas0Rz0ZV6NDz3uFJW3jZgHzsm9vSzBwaE/7RWcRLaGmnSJ YBwoHkRvfYRVdNYhwRYGPgAl28cYKv77KViE+Zi9YPB/L4PrEbHivc00W0RlXJPxPDN5 12/9Gxb77g23va8VGt+558SCRm5WjlOSlseXI7EV/e61rHArn9Ww6wDZxqbKHo1dKmCd c0lSgQBBaK982lqTBd32DdwR62vZgMenBDxvWwtM2QfZK/1nJDIxOJhazKvWRJK72G3O aopQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EUw6Hd+Tb+y6+h8IPlKOEXxbYBmUXjkCM3BqWwxBlG8=; b=F6i759Xx4KhiDOA+toSifwKVsoca3kKDICHY4/7mPJsyqVCVXZPZvw4wjnBl9+sLp2 OOvIjl1Ekhl4kMcNOAJRmlyhcS90a6XDh1YCSwVv6/oxfSVKfxhH5wvV/iPPJo6II7rs NFCPOQGLR4TUl1cza02xhXolXuhxoqCT7GHFHi7Cle1y8mxilCJ/CrURr/H1okTdesS3 JGmbMn+B2XNpwz9ucZ8qqRhUJ99V69XDY5jmVr3CoTIedS57viY7yiMiDxf59MFWWN27 sqMQCASIUSn5akgV03rUKjyV8Meid/E6y4tvzHsNYGDXBPy9p4kF+qb8Xq/RcBMezIRz 61vA== X-Gm-Message-State: ANoB5plO8m6+RNVHeqkJ1fe5hsE2bCS/ETOVDfUKXzfViV3L5ifYNnB3 jX7LQDcU8PCp00gY+mPkviE= X-Google-Smtp-Source: AA0mqf5GnVmcrBfMG8tVYmiTkS2qjOw6eiBPylS67ujMkmT01we801GcaVxVM/HsmWm1ZFJQfC2r1g== X-Received: by 2002:a17:906:6dd7:b0:7a1:1c24:e564 with SMTP id j23-20020a1709066dd700b007a11c24e564mr58800700ejt.629.1670273539855; Mon, 05 Dec 2022 12:52:19 -0800 (PST) Received: from kista.localnet (82-149-19-102.dynamic.telemach.net. [82.149.19.102]) by smtp.gmail.com with ESMTPSA id s26-20020a170906285a00b007af0f0d2249sm6645367ejc.52.2022.12.05.12.52.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 12:52:19 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: paul.kocialkowski@bootlin.com, Yang Li Cc: mchehab@kernel.org, wens@csie.org, samuel@sholland.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: Re: [PATCH -next] staging: media: Remove surplus dev_err() when using platform_get_irq() Date: Mon, 05 Dec 2022 21:52:18 +0100 Message-ID: <4229852.ejJDZkT8p0@kista> In-Reply-To: <20221129012923.111691-1-yang.lee@linux.alibaba.com> References: <20221129012923.111691-1-yang.lee@linux.alibaba.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221205_125223_580944_A669CA06 X-CRM114-Status: UNSURE ( 9.42 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne torek, 29. november 2022 ob 02:29:23 CET je Yang Li napisal(a): > There is no need to call the dev_err() function directly to print a > custom message when handling an error from either the platform_get_irq() > or platform_get_irq_byname() functions as both are going to display an > appropriate error message in case of a failure. > > ./drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c:390:2-9: line 390 is > redundant because platform_get_irq() already prints an error > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3274 > Reported-by: Abaci Robot > Signed-off-by: Yang Li Acked-by: Jernej Skrabec Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel