From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F3DBC433F5 for ; Sat, 9 Apr 2022 11:37:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dMBOiRalli7OlAdNjTB3qVnSBxcwJ+IdZ4pvD1an47c=; b=CR9MPkQAy+g71f v/5sXP8qZDSilbFYGrX9a0/qUF5bcs948K0m5GdWER4HNWcKW39K5W53tDehT9Ytbtv0SlKT1TGsb vIdD94e9GZdaMA8VgqHEmPVIuWrlbO9famKnj/1vjxp9h1lHXha3gK4HxbDxT9hbWio2oihYHsn9D ZivTJArnOSpzjkZmFfOANs2sy96YM29zzIuwSVD29UbpA1gyq2SUVJyY0an4cCeu18veQez9WEjr8 RLt6o8cEUkKyixEDvxrmz+Tjzg5HZLPptvnsx8hhHW0yFFq+r5yfWfv1QnvFcAlt4aK8LelgdvHxo iYR5ANe1PcvWEi8xeT9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nd9Nr-002y1k-9P; Sat, 09 Apr 2022 11:36:03 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nd9Nn-002y0v-H1; Sat, 09 Apr 2022 11:36:00 +0000 Received: from p508fd313.dip0.t-ipconnect.de ([80.143.211.19] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nd9Nh-00011A-Gp; Sat, 09 Apr 2022 13:35:53 +0200 From: Heiko Stuebner To: Peter Geis Cc: Dan Johansen , Frank Wunderlich , Frank Wunderlich , "open list:ARM/Rockchip SoC..." , Rob Herring , Krzysztof Kozlowski , Michael Riesch , devicetree , arm-mail-list , Linux Kernel Mailing List Subject: Re: Aw: Re: Re: [PATCH] arm64: dts: rockchip: Fix clocks for rk356x usb Date: Sat, 09 Apr 2022 13:35:52 +0200 Message-ID: <4232341.5fSG56mABF@phil> In-Reply-To: References: <20220409075147.136187-1-linux@fw-web.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220409_043559_613882_638434F4 X-CRM114-Status: GOOD ( 32.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Samstag, 9. April 2022, 13:30:44 CEST schrieb Peter Geis: > On Sat, Apr 9, 2022 at 7:14 AM Peter Geis wrote: > > > > On Sat, Apr 9, 2022 at 7:01 AM Heiko Stuebner wrote: > > > > > > Am Samstag, 9. April 2022, 12:57:39 CEST schrieb Frank Wunderlich: > > > > Hi > > > > > Gesendet: Samstag, 09. April 2022 um 12:40 Uhr > > > > > Von: "Dan Johansen" > > > > > > > > > So the issue is only with usb 3 ports, not usb 2 ports? > > > > > > > > my board has no standalone usb2-ports. usb2 is integrated into the usb3 ports (dual phy). here both were not working. > > > > > > > > afaik rk3566 has standalone usb2 ports that may not be broken, but i have no such board for testing. > > > > Good Morning, > > > > > > > > As far as I understand the issue now after checking the code, this > > > patch actually fixes the usb3 series from Peter, right? > > > > > > I.e. the usb-nodes that are fixed in this patch are not yet present > > > in the main rk356x dtsi and only get added in > > > "arm64: dts: rockchip: add rk356x dwc3 usb3 nodes" [0] > > > > > > As we don't want to add broken changes, this fix should squashed > > > into a next version of the patch adding the nodes. > > > > Thank you for reporting this, I will squash this fix in and add your signed-off. > > > > However the offending patch is in fact the clock separation patch, and > > it breaks backwards compatibility with the rk3328 dtsi which is why my > > series also is broken. > > > > The rockchip,dwc3.yaml needs to be fixed to align with the > > snps,dwc3.yaml, and both the rk3328 and rk3399 clock names updated. > > Also the offending clock separation patch needs a fix to grab the old > > clock names for rk3328 backwards compatibility to be retained. > > > > This might also be a good time to look into moving rk3399 to the core > > dwc3 driver? > > > > This is a delightful mess. > > In the idea of getting this series to land, if all parties agree, I'll > submit a patch that fixes the clock separation patch with this series > and leave the naming as is for now. > The renaming of clocks and alignment of everything can be addressed in > a future series once discussion on how best to handle it has happened. > > Do you concur with this? I'm not sure about that ... i.e. adding known-broken changes (for the rk356x) feels somewhat wrong to me. Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel