From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53CD8C4167B for ; Mon, 27 Nov 2023 10:50:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oYWuxT1srkfpaaA7Nn6PjjxksEfA52TfTXYJAswk9Zw=; b=s5FFgPX1rKcCgo j7Tlo4jJKP8Hrr0bmrpX0swkwt46di783YJN5TvKRc0CNjUKbo19f38v+gEGumJg0Y0ku7Z56a9Mn n47oZwITnUmpCoTUiyQX3oRyX0lyuxY82C21mdkVZsNvPyWo7BQPWYADXrltGIsS51DiJUHKqsCCj qUSVlrGn40IHCkN6uhctQQG1cl8f6h7m+mMkuSNaMh6HPtV3a3qffWtr+bwyCLuu5gmKMSPv30Wjj tCwayR4nTXDvW6cvoRVSNep1IGchQJoI5Z5cc+/pKX/jlQxwdxcXTty9FB1w1+tFFSa5kTPcBvK44 VOA6JCjgB4UdBUaUF7NQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r7ZCB-0028jM-0M; Mon, 27 Nov 2023 10:50:31 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r7ZC7-0028iK-1Q; Mon, 27 Nov 2023 10:50:28 +0000 Received: from i53875bf8.versanet.de ([83.135.91.248] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r7ZBv-0000i7-II; Mon, 27 Nov 2023 11:50:15 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Dragan Simic Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, Krzysztof Kozlowski , Tim Lunn , Jagan Teki , Rob Herring , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Conor Dooley Subject: Re: [PATCH v2 4/9] ARM: dts: rockchip: rv1126: Add i2c2 nodes Date: Mon, 27 Nov 2023 11:50:14 +0100 Message-ID: <4234862.3Lj2Plt8kZ@diego> In-Reply-To: <4bd0ce0f496646209eb8b220dfdd80bd@manjaro.org> References: <20231122122232.952696-1-tim@feathertop.org> <4065853.CrzyxZ31qj@diego> <4bd0ce0f496646209eb8b220dfdd80bd@manjaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231127_025027_483670_BF7AE34F X-CRM114-Status: GOOD ( 17.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Montag, 27. November 2023, 11:43:05 CET schrieb Dragan Simic: > On 2023-11-27 11:29, Heiko St=FCbner wrote: > > Am Montag, 27. November 2023, 10:58:43 CET schrieb Tim Lunn: > >> On 11/27/23 20:45, Heiko St=FCbner wrote: > >>> It's different for mmc, where this naming scheme isn't normally used, > >>> so we (mostly?) migrated to them being in the board-specific alias = > >>> section. > >> = > >> What about the ethernet alias, the MAC is part of the SoC, should this > >> stay as it is in patch 6 from this series, or move to board dtsi? > > = > > I think judging from everything above (and the other modern boards > > like all rk3588 ones) the ethernet0 alias should move to the board = > > dts(i). > > = > > The gmac generally does not have this numbering scheme like i2c or = > > uarts. > = > Please note there's already an Ethernet alias defined in rk3399.dtsi, = > even despite not all RK3399-based devices using the GMAC, for example = > the Pinebook Pro. Perhaps that's something to be fixed as well. possibly :-) I guess for starters we shouldn't introduce new instances for it. All the newer SoCs already have their ethernet alias in the board dts (rk356x, rk3568) which came after we also moved the mmc aliases. Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel