From: James Tai <james.tai@realtek.com>
To: "Andreas Färber" <afaerber@suse.de>,
"Marc Zyngier" <maz@misterjones.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-realtek-soc@lists.infradead.org"
<linux-realtek-soc@lists.infradead.org>
Subject: RE: [PATCH] arm64: dts: realtek: Add Realtek rtd1619 and mjolnir
Date: Sat, 23 Nov 2019 08:40:04 +0000 [thread overview]
Message-ID: <4235c5641f0f4946beeeea8adfd74970@realtek.com> (raw)
In-Reply-To: <80d0aed8-3b85-1312-1091-0ced3ab1f5d2@suse.de>
Hi Andreas,
>
> MMIO, for GICD and GICR. It's about fixing the ranges of the /soc node:
>
> My proposed
> ranges = <0x98000000 0x98000000 0x68000000>; needs to be split, with a gap
> between r-bus and GIC for continued RAM.
>
> https://github.com/afaerber/linux/commit/1884ec6a533c9d5c2b6ca40ee138ff
> 7e8312b6c8
>
> This goes back to Rob's review of RTD1295 [1], where we then for lack of
> memory space documentation assumed that everything beyond 2 GiB would
> be potential register space. Here we're dealing with up to 4 GiB though.
>
>
> James, are you planning to send a fix-up patch here? If not, you'll need to tell
> me what values to use, e.g., is there a NOR flash region on RTD1619, and does
> RAM continue also in between and after GIC, or is there some timer register
> behind it, like on RTD1195?
>
> ranges = <0x00000000 0x00000000 0x00030000>, // ??? boot ROM size
> <0x98000000 0x98000000 0x00200000>, // r-bus
> // anything here? e.g., NOR flash?
> <0xff100000 0xff100000 0x00010000>, // GICD
> <0xff140000 0xff140000 0x000c0000>; // GICR
> // anything here? e.g., timer enable?
>
> ranges = <0x00000000 0x00000000 0x00030000>,
> <0x98000000 0x98000000 0x00200000>,
> <0xff100000 0xff100000 0x00100000>; // whole GIC?
>
Yes, I'll send a fix-up patch.
Regards,
James
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-23 8:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 8:00 [PATCH] arm64: dts: realtek: Add Realtek rtd1619 and mjolnir James Tai
2019-11-06 8:28 ` Andreas Färber
2019-11-08 15:36 ` James Tai
2019-11-08 17:17 ` Andreas Färber
2019-11-11 2:58 ` James Tai
2019-11-15 1:08 ` Andreas Färber
2019-11-17 15:39 ` James Tai
2019-11-22 9:43 ` Marc Zyngier
2019-11-22 12:48 ` Andreas Färber
2019-11-23 8:40 ` James Tai [this message]
2019-11-11 3:09 ` Andreas Färber
2019-11-19 9:11 ` Andreas Färber
2019-11-20 7:58 ` James Tai
2019-11-22 3:03 ` Andreas Färber
2019-11-23 8:51 ` James Tai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4235c5641f0f4946beeeea8adfd74970@realtek.com \
--to=james.tai@realtek.com \
--cc=afaerber@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-realtek-soc@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=maz@misterjones.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox