From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] staging/wilc: fix Kconfig dependencies, second try
Date: Mon, 19 Oct 2015 11:39:31 +0200 [thread overview]
Message-ID: <4253270.hGxaSY0VLA@wuerfel> (raw)
In-Reply-To: <5624A1AF.8080607@atmel.com>
On Monday 19 October 2015 16:54:23 Tony Cho wrote:
> Hi Arnd Bergmann,
>
> When I apply this patch, I cannot make WILC1000 module (wilc1000.ko) because CONFIG_WILC1000 is y and also I can see some link errors for the cfg80211 APIs.
>
> Can you consider this patch?
Ah, you are right. I see the same thing now and don't know what caused me
to send the patch in an incomplete state.
I hope this snippet is the last missing piece:
diff --git a/drivers/staging/wilc1000/Kconfig b/drivers/staging/wilc1000/Kconfig
index ee51b4278088..e3f109655be4 100644
--- a/drivers/staging/wilc1000/Kconfig
+++ b/drivers/staging/wilc1000/Kconfig
@@ -1,6 +1,7 @@
config WILC1000_DRIVER
- bool "WILC1000 support (WiFi only)"
+ tristate "WILC1000 support (WiFi only)"
depends on CFG80211 && WEXT_CORE && INET
+ depends on MMC || SPI
---help---
This module only support IEEE 802.11n WiFi.
@@ -35,7 +36,7 @@ choice
config WILC1000_SDIO
bool "SDIO support"
- depends on MMC
+ depends on MMC=y || (MMC=m && WILC1000_DRIVER=m)
select WILC1000
---help---
This module adds support for the SDIO interface of adapters using
I'll do a few hundred more randconfig builds with this on top and submit
it once it succeeds.
Arnd
next prev parent reply other threads:[~2015-10-19 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 20:45 [PATCH] staging/wilc: fix Kconfig dependencies, second try Arnd Bergmann
2015-10-19 7:54 ` Tony Cho
2015-10-19 9:39 ` Arnd Bergmann [this message]
2015-10-19 9:53 ` Arnd Bergmann
2015-10-20 22:42 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4253270.hGxaSY0VLA@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).