public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] ARM: vt8500: cleanup start
Date: Tue, 24 Jun 2014 12:02:05 +0200	[thread overview]
Message-ID: <4258201.EByetKsPpX@wuerfel> (raw)
In-Reply-To: <CAJ3iQcqvaCbFJ0V4ZJ_cDxA1TN=JemaghUJQgVO_LkEq=DYjbg@mail.gmail.com>

On Tuesday 24 June 2014 17:32:26 Gergely Imreh wrote:
> > > https://github.com/viaembedded/arm-soc/tree/via-header
> > >
> > > Should this be part of a larger patchset later on, or is it okay just
> > > to send any time like
> > > this? Are these changes worth doing if the functionality itself did
> > > not really change,
> > > just probably the style improves?
> >
> > I think a good start would be to split out the reset code into a
> > proper device driver. The register used for reset is part of the
> > "pmc" device that is used in the clock driver, so you can
> > add a reboot/poweroff handler there and register it with arm_pm_restart/
> > pm_power_off.
> >
> 
> I guess the examples for these that I could see are the ones in
> drivers/power/reset? Or is there a driver that does this well that
> you'd recommend learning from?

Most of them seem pretty reasonable actually

> I've seen that in drivers/power/reset there's a bunch of X-reset.c,
> X-poweroff.c, X-reboot.c: any actual pattern to these files/naming?

I think some drivers can only reboot and some can only power off.
No idea which name is preferred for a driver that does both.

	Arnd

      reply	other threads:[~2014-06-24 10:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-23 16:10 [RFC] ARM: vt8500: cleanup start Gergely Imreh
2014-05-23 16:42 ` Arnd Bergmann
2014-06-24  9:32   ` Gergely Imreh
2014-06-24 10:02     ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4258201.EByetKsPpX@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox