From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 615A5C433EF for ; Tue, 28 Jun 2022 14:28:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DtVgWTuO3S4KLLfxz8gA25u5/T3qIx9WSfIOlITYw+o=; b=YkmlJpwfRXCKRcqUNMgbZeUJe0 Sorc2SLTtvFw1vL/Iln2TOphZRzTGs/jcOgCZl4gZaI5Pt9nzRbJ2fFoU/Kb9Izcyg9CJMeKUPG09 icmmCMLJrOhKhtTXBmDk2NUM1ahZk8cwEmUUPblFsQfUzGPSb/knZMvH5frah81DmKrpS1T/DDbBs Mw0NuTBwEmhzUNzybeoq9RPqUwQcG5aBGeJNM7HnFQmyHgKfyNkBNETT9OsWDmWN0b9AJCH7wFDGs i8jzzH/G/M0Kb9K2ppNwpN4WCoXWrPBDJ744932uzxVD2ZkBIP7KtXQxqduimg0miQ2Hmj9IWHe6H rU/OJa6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6CBr-006iC0-Gk; Tue, 28 Jun 2022 14:27:43 +0000 Received: from ssl.serverraum.org ([2a01:4f8:151:8464::1:2]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6CBp-006iAL-0M for linux-arm-kernel@lists.infradead.org; Tue, 28 Jun 2022 14:27:42 +0000 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 4498222246; Tue, 28 Jun 2022 16:27:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1656426446; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JHFbXd+WNtNIJszeKeAq0pw48IrQ1dnM0j78sJ1LNLI=; b=CT1XHrctn/p9QrSCpS0yYSjSmCtZ/F8BJDs5EhDC57YFKCtnE0lH9vNzjaDEpHUM7sXzrI HiLecE56ocS4JE0BIx06jXp+yzJatOIsntln1TlfUqUzqizz1rMVzIlLn/if3Uq13lWVj6 N6iWnX086nc/79yXg2u4WAFqgky5EoA= MIME-Version: 1.0 Date: Tue, 28 Jun 2022 16:27:23 +0200 From: Michael Walle To: Yang Yingliang Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, arnd@arndb.de, shawnguo@kernel.org Subject: Re: [PATCH -next 1/2] soc: fsl: guts: fix return value check in fsl_guts_init() In-Reply-To: <20220628140249.1073809-1-yangyingliang@huawei.com> References: <20220628140249.1073809-1-yangyingliang@huawei.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <42601e860097651547fb9baecd660b5c@walle.cc> X-Sender: michael@walle.cc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_072741_258786_A4C58492 X-CRM114-Status: UNSURE ( 8.18 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 2022-06-28 16:02, schrieb Yang Yingliang: > In case of error, of_iomap() returns NULL pointer not ERR_PTR(). > The IS_ERR() test in the return value check should be replaced > with NULL test and return -ENOMEM as error value. > > Fixes: ab4988d6a393 ("soc: fsl: guts: embed fsl_guts_get_svr() in > probe()") > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang Thanks! Reviewed-by: Michael Walle _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel