From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A82FCDB465 for ; Thu, 19 Oct 2023 06:01:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NgVf5RAnMwfs1jl3xh3zeVMRLBZdSXA5q1Iu/Np0YEQ=; b=XjwL6WI55EBG4b zGavOucvu3NX9INJCPGl+QDBsp7D4bGntMH6V1eXp/dUV3vF8Nn2PdhhHao1drxy0hdiL8RN4CVyv FAdZJs37yCbHZISTs6pJ+ayCdApWuS4NMY4ZDncZ2SWEVY/3wqvi7r5VZC9olw/5p+uv4uPxWJMIT jKqBgiUmN0INrkKnjnhriLEF2WfpZulSRSSdrp/LJiBKf4jQBlBVUj+fX94i7FGLuZDvm6tZZ8MjV J/xxh+wBozT7lkco7LAcF+4vVFQqE0C4IfZOl/tTkxp+Epnp6jRHkUQ2TviZOt6P31/VNI8gx3s6l ckSc1BwHnTAqCSSGkMsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtM5h-00GRrx-2o; Thu, 19 Oct 2023 06:01:05 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qtM5a-00GRqe-2k for linux-arm-kernel@lists.infradead.org; Thu, 19 Oct 2023 06:01:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1697695259; x=1729231259; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=730YXzJM/veidNKheQX/2/WJuZLbsKNszAfJOtRDQjk=; b=HqYZ2soZh+TZaC9soiRYaE72ECs0KE0uVBnd9MJuRfUUPfiZiRxV23on ZdJSjEt+TT3E3p+dmhnkTzmN3jdLiw4GGx/Kiecrwzh2yAAwcgScIhUi0 HUwetWFEUr7PprK7Wit8BYPPoa7zMrMmZi1dvmQO3bOA7pHFtzZPheao8 2A6FGbxANjcQoeig1zCobUnP+hXwMElvSW6/CPf5I5AUgDcRDrhRrCFCr 3u4qpgGlXfrn1oyCAPpcfaee4qocYkT79hCVyiwucJNWyhDFVW/AZfO3N zQOId8hrjSIe82I3lPBtoxu0kmSTH6UUJo+5j3/6jOAmUHA3804wVtDbU Q==; X-IronPort-AV: E=Sophos;i="6.03,236,1694728800"; d="scan'208";a="33540707" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 19 Oct 2023 08:00:51 +0200 Received: from steina-w.localnet (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id A3141280082; Thu, 19 Oct 2023 08:00:51 +0200 (CEST) From: Alexander Stein To: linux-arm-kernel@lists.infradead.org Cc: l.stach@pengutronix.de, aford@beaconembedded.com, Adam Ford , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Adam Ford Subject: Re: [PATCH] arm64: dts: imx8mp: Add NPU Node Date: Thu, 19 Oct 2023 08:00:53 +0200 Message-ID: <4261115.mogB4TqSGs@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20231019022300.1588041-1-aford173@gmail.com> References: <20231019022300.1588041-1-aford173@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231018_230059_912110_5CE0ED80 X-CRM114-Status: GOOD ( 15.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Adam, thanks for the patch I tried a similar one. Am Donnerstag, 19. Oktober 2023, 04:23:00 CEST schrieb Adam Ford: > The NPU is based on the Vivante GC8000 and it enumerates as > = > etnaviv-gpu 38500000.npu: model: GC8000, revision: 8002 > = > Signed-off-by: Adam Ford > = > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index > c9a610ba4836..1ef8d17726ac 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -2012,6 +2012,25 @@ vpumix_blk_ctrl: blk-ctrl@38330000 { > interconnect-names =3D "g1", "g2", "vc8000e"; > }; > = > + npu: npu@38500000 { > + compatible =3D "vivante,gc"; > + reg =3D <0x38500000 0x20000>; Do you have some more information about the actual memory range? RM says 2M= iB, = but NPU memory map lists up to 0x664. > + interrupts =3D ; > + clocks =3D <&clk IMX8MP_CLK_NPU_ROOT>, > + <&clk IMX8MP_CLK_NPU_ROOT>, > + <&clk IMX8MP_CLK_ML_AXI>, > + <&clk IMX8MP_CLK_ML_AHB>; > + clock-names =3D "core", "shader", "bus", "reg"; > + assigned-clocks =3D <&clk IMX8MP_CLK_ML_CORE>, > + <&clk IMX8MP_CLK_ML_AXI>, > + <&clk IMX8MP_CLK_ML_AHB>; > + assigned-clock-parents =3D <&clk = IMX8MP_SYS_PLL2_1000M>, > + <&clk = IMX8MP_SYS_PLL1_800M>, > + <&clk = IMX8MP_SYS_PLL1_800M>; > + assigned-clock-rates =3D <1000000000>, = <800000000>, <400000000>; 1GHz for ML_CLK_ROOT is only available in overdrive mode, 800MHz in nominal = mode. See datasheet IMX8MPIEC Rev 2.1. I don't think it's a good idea to = configure for overdrive mode by default. Same goes for CLK_ML_AHB regarding 400 vs. 300 MHz. Best regards, Alexander > + power-domains =3D <&pgc_mlmix>; > + }; > + > gic: interrupt-controller@38800000 { > compatible =3D "arm,gic-v3"; > reg =3D <0x38800000 0x10000>, -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel