From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF2D8ECAAD3 for ; Thu, 1 Sep 2022 15:07:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NuhPjODmA1yUZPM692Zjf6ulEfh+iDm+DGrC+Kyji0A=; b=inR+PZS5WFv9rH XpU1nRmYNvA3U9S41ZWm1B7nij2SDE09ZMO97M0j3EhNQ6rtQH8IqDyXiN44QtZ64kVLUVHKtYB7/ qN+ztfYMt0YAShSHXcvOsbPf1HBZ9qNZA59zhb1xBfyV6y9A75EaqzdOhqMsiYqflQ6AOM4NdhCKT ibPsDlRheFn/DnoK6x7YRq6EjQO5x1mi4vLSaRAjuFprkWllcptvCGljgVL6sh4KlPIUCEWjFhoP2 oEJUSFMlTN7pTn7wFOEFDcuLEpy7f2UX63MV+8cYyfNnhHG824sWTHfvF/IsKiXdWD//6UBHnhkX5 Tz26rGYPJjtZryfPKARA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTllz-00Ch0W-I5; Thu, 01 Sep 2022 15:06:27 +0000 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTllw-00Cgw9-Hs for linux-arm-kernel@lists.infradead.org; Thu, 01 Sep 2022 15:06:25 +0000 Received: by mail-lj1-x22f.google.com with SMTP id bn9so18191749ljb.6 for ; Thu, 01 Sep 2022 08:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=KCbUSop3WQVL4RTWvtr+n/jabxyBXZUokjzZKHnU5M0=; b=b2G44R7KnF5fTX88ReDvkLzm45zanEpaB49cNMjgDVVrz4TNOidDzAoCL2r4Cdeosl AK20h571HggQWfg3sVDA65zRKZ6JIHxvZtXwviB4RzcyI0BPaUiA/XCT21nio9EzQvVr iLbM/DmRnb1g5z3BGcKjJ4nXHAndFu0hlun63GghH3Elgkr8a5o24Iok+VtHo4htWedC PNXwucC8haXd3P/32QCTWhQ4DQd06S5FhJVBmEfIakUHcAmtz5oSn4f6bAZLqmLALH3/ bKMmFKGLbGuflHGj3tV139uLu7gbH8pJr28PMOSitOChu39i7ikkJE9jdZ77dPjqGOKI aJUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=KCbUSop3WQVL4RTWvtr+n/jabxyBXZUokjzZKHnU5M0=; b=X8NKLHa9CQPf736aGrpWxPsnw828HRamx0uxI0vxupZUMXSDj0sNDs8fvTZH9QwY7r 3v+SLJ+1l14LuWK0kALOPTHxXbW5W/j0F7fX63RThAXRe51Yhlcwys1AUIr7htRTnMHA bgyUG/rvTGoORgdvhWMo88qtHM5BdN+ZWfD+un9ZneLZuGalsOVHojc22UZ51bn0mqBh jZVnsvubYMr2ysyoXxKxXF6oVjxuFQfmOxtmGiuuXW08JofY+HFUnk5BnnEnOXL741TB rltzBQ9Jt99qpVFdBLe8lFWWqr+4rMTasXeOLUvLhtLwLUwi+h++kJuIetwggpi+FpzL DdHg== X-Gm-Message-State: ACgBeo2Z1wV2lZ8HKuH3wOu01ncM1M8eJKbYb8mUQc+PQeam+o3tXa8y WkcIJzwp1NJDej9saiqVgZu9bw== X-Google-Smtp-Source: AA6agR4v82tzjRxzkl50GAILGvdU/4Z8/oNIC6ddy1jLimYFNB37TxV7X+A0H1YFvTJk0OU7i+85SQ== X-Received: by 2002:a05:651c:1993:b0:263:a41d:3d7b with SMTP id bx19-20020a05651c199300b00263a41d3d7bmr6374222ljb.63.1662044779237; Thu, 01 Sep 2022 08:06:19 -0700 (PDT) Received: from [192.168.28.124] (balticom-73-99-134.balticom.lv. [109.73.99.134]) by smtp.gmail.com with ESMTPSA id 11-20020ac2482b000000b00492e2918a5asm1352324lft.269.2022.09.01.08.06.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Sep 2022 08:06:18 -0700 (PDT) Message-ID: <426469c1-13cc-178b-4904-09439d7788e8@linaro.org> Date: Thu, 1 Sep 2022 18:06:17 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 1/6] dt-bindings: mfd: add binding for Apple Mac System Management Controller Content-Language: en-US To: "Russell King (Oracle)" , Arnd Bergmann , Lee Jones , Linus Walleij Cc: Alyssa Rosenzweig , asahi@lists.linux.dev, Bartosz Golaszewski , Hector Martin , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, Sven Peter , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org References: From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220901_080624_629434_6CB9F507 X-CRM114-Status: GOOD ( 14.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/09/2022 16:54, Russell King (Oracle) wrote: > Add a DT binding for the Apple Mac System Management Controller. > > Signed-off-by: Russell King (Oracle) Thank you for your patch. There is something to discuss/improve. > + > +maintainers: > + - Hector Martin > + > +description: > + Apple Mac System Management Controller implements various functions > + such as GPIO, RTC, power, reboot. > + > +properties: > + compatible: > + items: > + - enum: > + - apple,t8103-smc You miss two spaces of indentation on this level. > + - apple,t8112-smc > + - apple,t6000-smc Bring some order here - either alphabetical or by date of release (as in other Apple schemas). I think t6000 was before t8112, so it's none of that orders. > + - const: apple,smc > + > + reg: > + description: Two regions, one for the SMC area and one for the SRAM area. You need constraints for size/order, so in this context list with described items. > + > + reg-names: > + items: > + - const: smc > + - const: sram > + > + mboxes: > + description: > + A phandle to the mailbox channel Missing maxItems > + > +additionalProperties: false > + Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel