From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] dmaengine: imx-sdma: remove __init annotation on sdma_event_remap
Date: Wed, 11 Nov 2015 11:01:33 +0100 [thread overview]
Message-ID: <4267122.WHg3VAy8bL@wuerfel> (raw)
In-Reply-To: <1447233649-21464-1-git-send-email-r64343@freescale.com>
On Wednesday 11 November 2015 17:20:49 Jason Liu wrote:
> The sdma_probe function will call sdma_event_remap, but sdma_event_remap
> marked with the __init annotation which make the kbuild complains as the
> following log:
>
> WARNING: drivers/dma/built-in.o(.text+0x56fc): Section mismatch in reference
> from the function sdma_probe() to the function .init.text:sdma_event_remap()
> The function sdma_probe() references
> the function __init sdma_event_remap().
> This is often because sdma_probe lacks a __init
> annotation or the annotation of sdma_event_remap is wrong.
>
> Remove the __init annotation on sdma_event_remap to kill this build warning
>
> Signed-off-by: Jason Liu <r64343@freescale.com>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
>
Looks good. I wonder why I have not caught this with the randconfig builds yet.
Acked-by: Arnd Bergmann <arnd@arndb.de>
One hint for the future: in the patch description, write less about the
kbuild warning and more about the actual impact of the bug (calling a
discarded function if the device gets unbound and rebound later, or
if we get deferred probing).
Arnd
next prev parent reply other threads:[~2015-11-11 10:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 9:20 [PATCH 1/1] dmaengine: imx-sdma: remove __init annotation on sdma_event_remap Jason Liu
2015-11-11 10:01 ` Arnd Bergmann [this message]
2015-11-11 10:06 ` Liu Jason
2015-11-16 3:45 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4267122.WHg3VAy8bL@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).