From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6997BC48297 for ; Mon, 12 Feb 2024 15:26:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lddpD+gJQj6XKoDCOO8EWZuU+iqOVFBA+NPOKq2KZ94=; b=RyaSIPJcIf8gVK zS8UUlOpIUcWETeWrRQT4mSMgv+8GUdDc5HDQX6dKAhDNceqIsk5La9yAZr9q5G1i33FTjskwfSCC DyPUH5pF05IUwQNMmQYPIe6actAyu1AcZBaIILL3TlF9g2dO149w9S3If94QJ40uAxbtZexlyAgwH +BsvYUXyg+khcAcstr+qMjcOKvxJ/rKPqBpBVh/okNyOnhlSDCCIDvLwj8mjrPKc80wZezZUsublL Ciyv5+zRs9ejqkvR1xBe8YM+ySn9dmPZIvIiBHABhbilJ2eTZwMVfntITVKVESC/AqtV++tndxbCW 6H05KawnYjOXiXHJCacQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZYCN-00000005xK8-2BD0; Mon, 12 Feb 2024 15:26:23 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZYCK-00000005xJM-2Si8 for linux-arm-kernel@lists.infradead.org; Mon, 12 Feb 2024 15:26:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707751579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=N2p12k+7Iv9WHrlS5oisjV1mT8St8zrJofR3kq/Jzug=; b=JJ3CIZAqSWgXKr+8kzJ82Oq7oS5NJF0DL1jb16PlwKSeygvS2q7ABOih1YzrcCAYbDkUGD 5cgVpXvJQOPkHmcLtOJkX8fPsRj6bUz/DHYNgMTaeb22al3MZBhpOi5cYyTJ8OeTKVpX/9 fGJ2ERAXehB9CHm4saDNATsWfzLuX+k= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-617-g_e_ryclMxKKPTSxLmd56g-1; Mon, 12 Feb 2024 10:26:17 -0500 X-MC-Unique: g_e_ryclMxKKPTSxLmd56g-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-40fb03d8a39so19795065e9.3 for ; Mon, 12 Feb 2024 07:26:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707751576; x=1708356376; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=N2p12k+7Iv9WHrlS5oisjV1mT8St8zrJofR3kq/Jzug=; b=q3pAOpshkI2nvRTATgRiBImJfoPWzp0RPe5z7YU3d7W0ET60RBMEb1rPRyK7eEbGpb vJLxzbrMYZkhZ+PP6tZ8He2eIdjjznVAcq3MKEC9ubmyUM0ETfhZMYCIifixRbnJ+yi+ EqLBRn4oeXuLHqZYNOKuet/OLZGxSI7ICJiuUEYTgU+RzgW3kRtLudF5vKpCO4/0Y0/k FwOjyjKCij6cxn4ap5+RO7mjtqDcwmW+gossKrnoJ1boObzbQ3LdY3DSAQoNVLlqovMA mMXZ89Gig8pwJcK+kpVm2RI3AlRQnqewbyJOpSinrrCDavb8GeMfWzdgMHfJtz2rX63a mHhg== X-Gm-Message-State: AOJu0YzKWuQxeEAre85Z96hiOzQh46yhNPktjVwOKgaF5UyLWyVmYFO/ hXf0srGovgProS8AS4rdhJ75J5qo1ZtJYlOaUt+Jj2WYuoHaQbjeYQKS2AouRCZtc68KBC9rip9 I/BN2ZkWWplTVRc0EthSpjyU95VKxi5ts9xnLV2cZqT63pqZWJS/NasNWvJ/uqYjdjkh1SvE2 X-Received: by 2002:adf:cd04:0:b0:33b:68bc:6e73 with SMTP id w4-20020adfcd04000000b0033b68bc6e73mr4935570wrm.42.1707751576526; Mon, 12 Feb 2024 07:26:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IE8Dy3l/MlS4TLVpewMh1iuuVUjkOzjiTfN9qiPXXjLJWcKc6PpmPBiesnCcCKWUhmALOvtDg== X-Received: by 2002:adf:cd04:0:b0:33b:68bc:6e73 with SMTP id w4-20020adfcd04000000b0033b68bc6e73mr4935541wrm.42.1707751576101; Mon, 12 Feb 2024 07:26:16 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCV1WEE4PR/r90frq6siLvLzqbl7F4fqmxcerDEc7lFE0E775qaAjh05I/BhrVaZ3K8GaK6XPWjXB0LIq9PCoNQ/Pe0bAVQFKXMss+nzNgCQYLlHr7g+J7aC9UNeXWC2JgV/d/m3rgwCN9A1BAK94ukfhPzqL+sOuPmcmbuRIVmXWaNw3rVtFIllVMS0SJfWU7pabtZ57gIoZ8An0/098bQx7mXtZXmRNH09m4+zFDK2Qk0V9SsaMm1D89MaEPiI7sye0Kpeei8mcqklfQ2OBXSjOPRhQu4D+N9dpCdY3FgKoCPDuZTRV7j6TjpctvMLh3CbgXD7WynasnhCPJdjcBP203Jq1ln+DByCMIozt9kT3gNVtdf7H0o/xTLtHgc9dYMqQ2QMsOVyCisliT5d2mi/v+tt/1IebGiAC3fjfJ8wixDaegWvrnER6L9gXW8t1KPIpe0rQS8dRftkj+WPIn/8nicLJ0eOoTntiY0Q29eoisovAPQiQEqIwfxcIAK4Qlnt5N4lilUKBhj0xeKCpamAxXDlqtxAY9gTtuw8XhBCwqcoDueqF1Di126FVUnSvjD4fg40BSETo/b9TZG+e/tceTk10Y7MMU/ftgCnbYNGvV2tb9eTYYqs5CRKnTZOopzkJVC/4hR2eQeGe9/l+6ARwzbVbuXbWyugAW9DvPomMshlTUrUrsBdVTJn1VWWExfLSrER5Z8PRAfteN8ZOCyl+yjW42KceM+dx1kfcfXkc5r3zZKmalYrGmFLFC4p0XFkmQsDX8GeP7IHEt2MBB48ndSVIHwAPJEFaEXMShXmamX9Lak7lKFMkOupfxWzRsDaDumtB6v9l98Ukz9a0VaH0g9jgxopxnKOXsTiGIJF9Rg0/gEMOahfR7S6ug== Received: from ?IPV6:2003:cb:c730:2200:7229:83b1:524e:283a? (p200300cbc7302200722983b1524e283a.dip0.t-ipconnect.de. [2003:cb:c730:2200:7229:83b1:524e:283a]) by smtp.gmail.com with ESMTPSA id bw1-20020a0560001f8100b0033b5b6a186dsm7078296wrb.69.2024.02.12.07.26.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Feb 2024 07:26:15 -0800 (PST) Message-ID: <427ba87a-7dd0-4f3e-861f-fe6946b7cd97@redhat.com> Date: Mon, 12 Feb 2024 16:26:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 19/25] arm64/mm: Wire up PTE_CONT for user mappings To: Ryan Roberts , Mark Rutland Cc: Catalin Marinas , Will Deacon , Ard Biesheuvel , Marc Zyngier , James Morse , Andrey Ryabinin , Andrew Morton , Matthew Wilcox , Kefeng Wang , John Hubbard , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , Yang Shi , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240202080756.1453939-1-ryan.roberts@arm.com> <20240202080756.1453939-20-ryan.roberts@arm.com> <502a3ea7-fd86-4314-8292-c7999eda92eb@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <502a3ea7-fd86-4314-8292-c7999eda92eb@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240212_072621_056482_7C710105 X-CRM114-Status: GOOD ( 24.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12.02.24 15:45, Ryan Roberts wrote: > On 12/02/2024 13:54, David Hildenbrand wrote: >>>> If so, I wonder if we could instead do that comparison modulo the access/dirty >>>> bits, >>> >>> I think that would work - but will need to think a bit more on it. >>> >>>> and leave ptep_get_lockless() only reading a single entry? >>> >>> I think we will need to do something a bit less fragile. ptep_get() does collect >>> the access/dirty bits so its confusing if ptep_get_lockless() doesn't IMHO. So >>> we will likely want to rename the function and make its documentation explicit >>> that it does not return those bits. >>> >>> ptep_get_lockless_noyoungdirty()? yuk... Any ideas? >>> >>> Of course if I could convince you the current implementation is safe, I might be >>> able to sidestep this optimization until a later date? >> >> As discussed (and pointed out abive), there might be quite some callsites where >> we don't really care about uptodate accessed/dirty bits -- where ptep_get() is >> used nowadays. >> >> One way to approach that I had in mind was having an explicit interface: >> >> ptep_get() >> ptep_get_uptodate() >> ptep_get_lockless() >> ptep_get_lockless_uptodate() > > Yes, I like the direction of this. I guess we anticipate that call sites > requiring the "_uptodate" variant will be the minority so it makes sense to use > the current names for the "_not_uptodate" variants? But to do a slow migration, > it might be better/safer to have the weaker variant use the new name - that > would allow us to downgrade one at a time? Yes, I was primarily struggling with names. Likely it makes sense to either have two completely new function names, or use the new name only for the "faster but less precise" variant. > >> >> Especially the last one might not be needed. > I've done a scan through the code and agree with Mark's original conclusions. > Additionally, huge_pte_alloc() (which isn't used for arm64) doesn't rely on > access/dirty info. So I think I could migrate everything to the weaker variant > fairly easily. > >> >> Futher, "uptodate" might not be the best choice because of PageUptodate() and >> friends. But it's better than "youngdirty"/"noyoungdirty" IMHO. > > Certainly agree with "noyoungdirty" being a horrible name. How about "_sync" / > "_nosync"? I could live with ptep_get_sync() ptep_get_nosync() with proper documentation :) I don't think we use "_sync" / "_nosync" in the context of pte operations yet. Well, there seems to be "__arm_v7s_pte_sync" in iommu code, bit at least in core code nothing jumped at me. -- Cheers, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel