linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ninad Palsule <ninad@linux.ibm.com>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au,
	peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca,
	keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com,
	johannes.holland@infineon.com, linux@roeck-us.net,
	broonie@kernel.org
Cc: patrick.rudolph@9elements.com, vincent@vtremblay.dev,
	peteryin.openbmc@gmail.com, lakshmiy@us.ibm.com,
	bhelgaas@google.com, naresh.solanki@9elements.com,
	alexander.stein@ew.tq-group.com, festevam@denx.de,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-integrity@vger.kernel.org, linux-hardening@vger.kernel.org,
	geissonator@yahoo.com
Subject: Re: [PATCH v1 8/8] ARM: dts: aspeed: System1: PS, sensor and more
Date: Wed, 13 Dec 2023 20:37:50 +0100	[thread overview]
Message-ID: <427fa99c-764c-4d6a-b9f1-cd9089710d5e@linaro.org> (raw)
In-Reply-To: <44abff4a-0a8e-499b-8b98-a4a1680cb431@linux.ibm.com>

On 13/12/2023 20:02, Ninad Palsule wrote:
> Hello Krzysztof,
> 
> On 12/12/23 14:26, Krzysztof Kozlowski wrote:
>> On 12/12/2023 17:40, Ninad Palsule wrote:
>>> This drop adds following devices in the device tree.
>>> - EEPROM/VPD
>>> - Power supplies
>>> - Humidity, pressure and temperature sensors.
>>> - Trusted platform module(TPM) chip
>>>
>>> Tested:
>>>      This board is tested using the simics simulator.
>>>
>>> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
>>> ---
>> Don't mix DTS with drivers. DTS and drivers go via different subsystems
>> and cannot have dependencies, so why DTS is patch #6, then driver #7 and
>> now again DTS #7?
> 
> There is a dependency on driver code as patch #8 uses the compatibility 
> string added in driver patch #7.  I have now moved driver patch at the 
> start. Is that ok? OR you are suggesting something else?

First, there is no dependency. Second, except confusing order anyway DTS
will go via separate trees. Third, again, there is no dependency. If
there is, your patchset is broken and this needs to be fixed. Although I
don't understand how new hardware can depend on driver... it's really odd.

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-12-13 19:38 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12 16:39 [PATCH v1 0/8] Add device tree for IBM system1 BMC Ninad Palsule
2023-12-12 16:39 ` [PATCH v1 1/8] dt-bindings: arm: aspeed: add IBM system1-bmc Ninad Palsule
2023-12-12 17:09   ` Conor Dooley
2023-12-12 20:06     ` Ninad Palsule
2023-12-13 18:18   ` Jarkko Sakkinen
2023-12-13 18:36     ` Ninad Palsule
2023-12-12 16:39 ` [PATCH v1 2/8] dt-bindings: tpm: Add schema for TIS I2C devices Ninad Palsule
2023-12-12 17:14   ` Conor Dooley
2023-12-12 18:20     ` Guenter Roeck
2023-12-14 15:37       ` Ninad Palsule
2023-12-14 15:34     ` Ninad Palsule
2023-12-14 16:35       ` Conor Dooley
2023-12-14 20:13         ` Rob Herring
2023-12-13 16:13   ` Rob Herring
2023-12-14 22:23     ` Ninad Palsule
2024-01-08 19:44     ` Ninad Palsule
2023-12-13 18:20   ` Jarkko Sakkinen
2023-12-13 18:38     ` Ninad Palsule
2023-12-12 16:39 ` [PATCH v1 3/8] ARM: dts: aspeed: System1: IBM system1 BMC board Ninad Palsule
2023-12-12 20:20   ` Krzysztof Kozlowski
2023-12-14 15:06     ` Ninad Palsule
2023-12-12 16:40 ` [PATCH v1 4/8] ARM: dts: aspeed: System1: Add i2c and muxes Ninad Palsule
2023-12-12 20:21   ` Krzysztof Kozlowski
2023-12-14 18:34     ` Ninad Palsule
2023-12-15  7:35       ` Krzysztof Kozlowski
2023-12-12 16:40 ` [PATCH v1 5/8] ARM: dts: aspeed: System1: Voltage regulators Ninad Palsule
2023-12-12 20:22   ` Krzysztof Kozlowski
2023-12-14 16:30     ` Ninad Palsule
2023-12-12 16:40 ` [PATCH v1 6/8] ARM: dts: aspeed: System1: GPIO, Fan ctrl, Led Ninad Palsule
2023-12-12 20:25   ` Krzysztof Kozlowski
2024-01-08 19:56     ` Ninad Palsule
2023-12-12 16:40 ` [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings Ninad Palsule
2023-12-12 17:15   ` Conor Dooley
2023-12-12 18:00     ` Guenter Roeck
2023-12-12 18:51       ` Conor Dooley
2023-12-12 19:50         ` Guenter Roeck
2024-01-08 20:05           ` Ninad Palsule
2024-01-09 17:14             ` Conor Dooley
2024-01-09 23:55               ` Ninad Palsule
2024-01-09 23:55               ` Ninad Palsule
2024-01-10  7:50                 ` Krzysztof Kozlowski
2024-01-10 14:31                   ` Ninad Palsule
2024-01-10 15:37                     ` Krzysztof Kozlowski
2024-01-10 15:54                       ` Ninad Palsule
2024-01-10 16:23                         ` Conor Dooley
2024-01-10 17:54                         ` Krzysztof Kozlowski
2024-01-10 19:06                           ` Guenter Roeck
2024-01-10 20:34                             ` Krzysztof Kozlowski
2024-01-10 20:36                               ` Krzysztof Kozlowski
2024-01-10 21:41                               ` Guenter Roeck
2024-01-08 20:04     ` Ninad Palsule
2023-12-12 16:40 ` [PATCH v1 8/8] ARM: dts: aspeed: System1: PS, sensor and more Ninad Palsule
2023-12-12 20:26   ` Krzysztof Kozlowski
2023-12-13 19:02     ` Ninad Palsule
2023-12-13 19:37       ` Krzysztof Kozlowski [this message]
2023-12-13 19:49         ` Ninad Palsule
2023-12-14  7:24           ` Krzysztof Kozlowski
2023-12-14 14:24             ` Ninad Palsule
2023-12-14 15:04     ` Ninad Palsule

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=427fa99c-764c-4d6a-b9f1-cd9089710d5e@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=andrew@codeconstruct.com.au \
    --cc=bhelgaas@google.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@denx.de \
    --cc=geissonator@yahoo.com \
    --cc=gpiccoli@igalia.com \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=joel@jms.id.au \
    --cc=johannes.holland@infineon.com \
    --cc=keescook@chromium.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lakshmiy@us.ibm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=naresh.solanki@9elements.com \
    --cc=ninad@linux.ibm.com \
    --cc=patrick.rudolph@9elements.com \
    --cc=peterhuewe@gmx.de \
    --cc=peteryin.openbmc@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=vincent@vtremblay.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).