From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: mripard@kernel.org, wens@csie.org
Cc: robh+dt@kernel.org, codekipper@gmail.com, peron.clem@gmail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: dts: sunxi: h3/h5: Fix I2S2 node
Date: Sun, 05 Sep 2021 21:40:50 +0200 [thread overview]
Message-ID: <4281589.rpS0U0bY3j@kista> (raw)
In-Reply-To: <20210905192628.206061-1-jernej.skrabec@gmail.com>
Hi all,
Dne nedelja, 05. september 2021 ob 21:26:28 CEST je Jernej Skrabec napisal(a):
> I2S2 controller has RX DMA channel according to documentation.
>
Sorry for mistake. This is not true. Documentation doesn't have RX DMA
documented (I2S2 is connected to HDMI).
Marcus, do you remember if loopback mode actually works on H3, with DMA
enabled? Maybe DMA is there, just undocumented. Some SoCs (H6, R40) have RX
DMA channel documented, even though it's used for HDMI TX only, and others
don't (A64, H3, H5).
Anyway, I got report that I2S driver from 5.14 onwards can't register
controller anymore due to missing RX DMA channel. So either driver or DT has
to be fixed.
Please disregard this patch for now.
Best regards,
Jernej
> Add it.
>
> Fixes: cd7c897821a0 ("arm: dts: sunxi: h3/h5: Add I2S2 node")
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> ---
> arch/arm/boot/dts/sunxi-h3-h5.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-
h5.dtsi
> index c7428df9469e..bd26f2059220 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> @@ -670,9 +670,9 @@ i2s2: i2s@1c22800 {
> interrupts = <GIC_SPI 15
IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&ccu CLK_BUS_I2S2>, <&ccu
CLK_I2S2>;
> clock-names = "apb", "mod";
> - dmas = <&dma 27>;
> + dmas = <&dma 27>, <&dma 27>;
> resets = <&ccu RST_BUS_I2S2>;
> - dma-names = "tx";
> + dma-names = "tx", "rx";
> status = "disabled";
> };
>
> --
> 2.33.0
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-09-05 19:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-05 19:26 [PATCH] arm: dts: sunxi: h3/h5: Fix I2S2 node Jernej Skrabec
2021-09-05 19:40 ` Jernej Škrabec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4281589.rpS0U0bY3j@kista \
--to=jernej.skrabec@gmail.com \
--cc=codekipper@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=peron.clem@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox