From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08E7CC433F5 for ; Sun, 5 Sep 2021 19:42:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C095E60F6D for ; Sun, 5 Sep 2021 19:42:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C095E60F6D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2eWCUCI2PZZXKs0EEldZOa7hDvvc/pLf+8F6wFJDXuA=; b=yf4OZAkp4l8EmD GypG/+sJ7CMar4PJhcpIwQQ/ULInIOPyLnKkbwf+7MoWnvVFktZhv+p5R3IWnpyda2aQ7QOhEFa4D jyz/sqlres/OoAMBH2gO9tj/JYge0fx6i2ZWcOJTGydNuzQE9IGZGVv4JWvAU0PouwL0BlrHGggp9 /P5GHgdexigdTTIFXdswVuP/e8voA6a1vggXgUhCvopsMq7N2KXhoBD47+IqiDuWnQ6JGQAEAOgMz Zpgp6+qnllRAqLJg9TccyMNG/0O8pfHlsaG5qLwjYKQluh8IkR6TmaSDyFqBKs8TtaYlDi/Njg3qS 8c73PFzEH5JbeyvfL3kw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mMy0f-00GKhW-Ai; Sun, 05 Sep 2021 19:40:57 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mMy0b-00GKgj-Nc for linux-arm-kernel@lists.infradead.org; Sun, 05 Sep 2021 19:40:55 +0000 Received: by mail-ej1-x62a.google.com with SMTP id jg16so8974965ejc.1 for ; Sun, 05 Sep 2021 12:40:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ktfu/1dI5EriLXE5SDDhbia+REVwP853qU4CVNxHqiI=; b=Rxqu+vGpTbt09JrFUNrJ30s3AmbCiII568kBUn+HM9TNaW3Nup6GeXNLCRvBVD85AV uHOfgUPXJL/wvBjFiuGcTIrmKZyJ+R6pw5IKhP9gSOEDs+glsWckJ6NsGbH9w5mEu5Ir w8bdZ8EU2f4eHWxa/nLSHjIWYyKKr25er9bV38pGOY9QdIGNESJQyHdpIsdoFM9kRVBM RFVYf43E8HRO0i8oHWVEr9KxpUCkvN+6xqbQWqNZgE2JCj5gVYrwCOh3ThJnabAHcY+B Z2QZAyFg+V8WIqV8TtBhcLiTiTdUipy+THlZ3so7j8lP+hlaDCAGFeclPeBGDLLe98jp km7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ktfu/1dI5EriLXE5SDDhbia+REVwP853qU4CVNxHqiI=; b=fTXRXrBdfdJhjK+w74MrpWKUoDOZ7YMZlxtlGpmUFzK1yjrA2KPNOxOhfacFRQk+2d NT3RlUIS7VdSO1KKNUzLccfPWaSPBxmc9RNWvIwnfiblCKADXLaMSwxPODJ6eXBQ5Iir 9MNUe/UDmO6n/ehHgYL+vQx1YTTjjlwqbdj8OdWxcOYY+zcxiNDmNkoRztdXTOZTM1Gd NyNJXi1GJWWHnSD4kjvXMPoPrvxAVdACm0ehoO2gvy+jRQYZd8rabIFsBZC9fRxcuCkY zRwbEB4ORSqZg07reEgOMO+KI4rNN31znFC6Fdzf/lgAMvzX962dPr/LnRVls3ItA3oi zp3g== X-Gm-Message-State: AOAM532QymhpOdCizzglmNE+ezigVuvVmv9U4F+XV8QJfiAkyEFDVIUF kF7fwDyPeijwc9nRvTTF3LA= X-Google-Smtp-Source: ABdhPJx9zcPWC1IOubNX+p+CD/pSo0c5XPiVDRow8ByiiVq9DoQW/HLDz1WVsBR2IX2OinBEA9EdJQ== X-Received: by 2002:a17:906:1615:: with SMTP id m21mr10662315ejd.279.1630870852109; Sun, 05 Sep 2021 12:40:52 -0700 (PDT) Received: from kista.localnet (cpe-86-58-29-253.static.triera.net. [86.58.29.253]) by smtp.gmail.com with ESMTPSA id o19sm3263530edr.18.2021.09.05.12.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Sep 2021 12:40:51 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: mripard@kernel.org, wens@csie.org Cc: robh+dt@kernel.org, codekipper@gmail.com, peron.clem@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm: dts: sunxi: h3/h5: Fix I2S2 node Date: Sun, 05 Sep 2021 21:40:50 +0200 Message-ID: <4281589.rpS0U0bY3j@kista> In-Reply-To: <20210905192628.206061-1-jernej.skrabec@gmail.com> References: <20210905192628.206061-1-jernej.skrabec@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210905_124053_847205_FA74469D X-CRM114-Status: GOOD ( 17.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi all, Dne nedelja, 05. september 2021 ob 21:26:28 CEST je Jernej Skrabec napisal(a): > I2S2 controller has RX DMA channel according to documentation. > Sorry for mistake. This is not true. Documentation doesn't have RX DMA documented (I2S2 is connected to HDMI). Marcus, do you remember if loopback mode actually works on H3, with DMA enabled? Maybe DMA is there, just undocumented. Some SoCs (H6, R40) have RX DMA channel documented, even though it's used for HDMI TX only, and others don't (A64, H3, H5). Anyway, I got report that I2S driver from 5.14 onwards can't register controller anymore due to missing RX DMA channel. So either driver or DT has to be fixed. Please disregard this patch for now. Best regards, Jernej > Add it. > > Fixes: cd7c897821a0 ("arm: dts: sunxi: h3/h5: Add I2S2 node") > Signed-off-by: Jernej Skrabec > --- > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3- h5.dtsi > index c7428df9469e..bd26f2059220 100644 > --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi > +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi > @@ -670,9 +670,9 @@ i2s2: i2s@1c22800 { > interrupts = ; > clocks = <&ccu CLK_BUS_I2S2>, <&ccu CLK_I2S2>; > clock-names = "apb", "mod"; > - dmas = <&dma 27>; > + dmas = <&dma 27>, <&dma 27>; > resets = <&ccu RST_BUS_I2S2>; > - dma-names = "tx"; > + dma-names = "tx", "rx"; > status = "disabled"; > }; > > -- > 2.33.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel