From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A4FAC433DB for ; Tue, 9 Mar 2021 10:24:11 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 005D865267 for ; Tue, 9 Mar 2021 10:24:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 005D865267 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7YVcNJ/FBNtfCe2Uu1ig9yx07pnDAthhsAUp5WhOZS4=; b=DWy/Mj4497fj+HvVtrEWjfypq jIcVUEu7pW8mEeecfxEq01Ix9GyrCZJbdwK+Fw/FWjXBfG94kcwn6iWWk5B2NY+Ue2cWc2wZRVnfi 2E1hb094chBJtDhPvDyz/3+D9A2nX+KzS2PcZnj3e6UOkg7JSr84ONPrT/YQGtkUN1pFQs9xC4fbO kdhCnN37yPrMHxWiucG0yrHq8VdTczyirhTuoAU8aQR0ttB4Bgn2VJbLGjw3tfXuXl/JczB70JcL6 SQXKUNixLqmUX15fwa9eV0S5ni/bRDjrQotiIjMlGgAltHcjULwA0kdm5D3w9m3sVq5u79NWhrT4b rGBU7VYrQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJZVm-004Cbk-4I; Tue, 09 Mar 2021 10:22:46 +0000 Received: from foss.arm.com ([217.140.110.172]) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJZVe-004Cak-EA for linux-arm-kernel@lists.infradead.org; Tue, 09 Mar 2021 10:22:43 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A70FA31B; Tue, 9 Mar 2021 02:22:32 -0800 (PST) Received: from [10.37.8.8] (unknown [10.37.8.8]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 91BBD3F71B; Tue, 9 Mar 2021 02:22:29 -0800 (PST) Subject: Re: [PATCH v14 5/8] arm64: mte: Enable TCO in functions that can read beyond buffer limits To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Andrew Morton , Catalin Marinas , Will Deacon , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Branislav Rankov , Andrey Konovalov , Lorenzo Pieralisi References: <20210308161434.33424-1-vincenzo.frascino@arm.com> <20210308161434.33424-6-vincenzo.frascino@arm.com> <20210308180910.GB17002@C02TD0UTHF1T.local> From: Vincenzo Frascino Message-ID: <42b39ecc-4f97-63bf-cdab-2ba4817b8610@arm.com> Date: Tue, 9 Mar 2021 10:26:54 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210308180910.GB17002@C02TD0UTHF1T.local> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210309_102241_211530_04CE5D85 X-CRM114-Status: GOOD ( 13.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/8/21 6:09 PM, Mark Rutland wrote: >> +DECLARE_STATIC_KEY_FALSE(mte_async_mode); > Can we please hide this behind something like: > > static inline bool system_uses_mte_async_mode(void) > { > return IS_ENABLED(CONFIG_KASAN_HW_TAGS) && > static_branch_unlikely(&mte_async_mode); > } > > ... like we do for system_uses_ttbr0_pan()? > I agree, it is a cleaner solution. I will add it to v15. > That way the callers are easier to read, and kernels built without > CONFIG_KASAN_HW_TAGS don't have the static branch at all. I reckon you > can put that in one of hte mte headers and include it where needed. -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel