From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98395C46CD2 for ; Thu, 25 Jan 2024 02:35:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LVE4sc2McYEaugZnaboQ2sg4xV5MZiKNPIGUv2ZYd0w=; b=TViBxve9sers1q DBW/DgGfreE5W2MUd1hn6FlbtYSxxY/xAGJTPf/MskkPhuGLetH+BBv0b97iwKcYiEVMzMII02JXa rRO1sZxbx8lViTxU13Tue6Wg0kSLMOv+ePSl0U2tJ+p0HTeV6TT3nCLHdUxAyaUcb9O0h0+sFcofk EzJdHbepqpZh7ucrThptUfmGhP+LUhAMq1PDRxzSZQVnDXQbrfz8DDc4u/YgI1WrlxaZZ+FhNOUnq BHBgzM3+XbkjjSSyNP+CLss9rQTQhfbJH2ud8kjoRUbVIwCeBwPUdzGf8SH8nzUcPRRFEWGVdjDMd F49fyE1u35zBocejNiYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSpa9-005uiQ-39; Thu, 25 Jan 2024 02:35:09 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSpa5-005uhY-1X; Thu, 25 Jan 2024 02:35:07 +0000 X-UUID: 552c05b2bb2a11eea0bf134e88e6c2dc-20240124 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=8leEpzl/CJ3bhHWIOlQ08Y7Qc2Kf6H2DtX0XFJTK38o=; b=YkPWTFcU05mECUiCM/Y3QKGTzd/AtIlm6WGQgLcShg2zPRdOykajT1tQnz1ARET2uRVsbMQYoOL25+yx2ZsEj1pCQqiTpMXE/q8Tx2occWznC4q0frPozGmuFgmWSYHl5luBdQhfYuHqprEkPjZMdNLMfikMXQsmD7a1G+Rhkq0=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.36,REQID:2221c647-9b94-4113-ba96-a6dbb6a529cd,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:6e16cf4,CLOUDID:ee99ba7f-4f93-4875-95e7-8c66ea833d57,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:1,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1, SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULS X-UUID: 552c05b2bb2a11eea0bf134e88e6c2dc-20240124 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1473672131; Wed, 24 Jan 2024 19:34:58 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by mtkmbs13n1.mediatek.inc (172.21.101.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 25 Jan 2024 10:24:54 +0800 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Thu, 25 Jan 2024 10:24:54 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gJJZuFan0B7gs4hbD1rt83+XnnucoPNz6bNR3w+1H3hxSoHqI06cFI/V2NhON0D7xKcHNUk+O0EYMZXpzXwsubNg5JLpvfGob3hgMu9qqKLkVSBx6UIduQkmon+Iu5rXIm/uEKsrI/dkmj0qFNQzYb4pOM3dLMnrpXgRm495WQFCSd+ob7iZCwG3Vjf8lTLkNiwY7tvmI8HkshTfJOmVAyeHf/gZSlzBIYsxcNAc12AbkOYqlRQL7ekt4FdlOX+Rkj2mWkl73dW1QcoEurMwVgLe3Ns3vpIoxDrgF94lhRBOwK3mfZ3eDO6wZGu0I5nwk6bGnvPrq/45n1K8hNdIxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8leEpzl/CJ3bhHWIOlQ08Y7Qc2Kf6H2DtX0XFJTK38o=; b=jQtl/qlYCa6txhfQ/keoVlMy7+yJMJATDGV55hrOaoIcFjVsgi1tFkaqdoO3v6AsxULjxH7NidHVe9rSUwXtR+CeW30jSLrLBo1wI+4b4okl8aHAv9CRFYfuMn3OCzBaYO+NoGGXK41VhADv+9aFVqi+Z3+IRAs5gqb3feLShZjdILVAdLIRcTsPt5nb1j2xDj3zUcpHCCsdplY11g+SDiZx17kOel2lJFQpIOhokIShHS5qxi44FX+PJKnzMCZj8713CRt7ecXRSGDKi48AoiRacN+Zg52xy/bi5ONur7Dofshk+BrpCnBg5nnGzWHAgq4gc0fscNodAx0ywjoIrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8leEpzl/CJ3bhHWIOlQ08Y7Qc2Kf6H2DtX0XFJTK38o=; b=XZERNunyfult536444BTzxNU8tB+8h3PlVOKBLEoHsY1dCLg1q44SrJpMaKLga68UoTfMfWa/b3tnLbkn2ffTlS27OlBfqlxbNELTGHUE++NN21YHum/41tFpqO6F1uzC4SK0JYxf5n+dz7reOp+0jHipiuFfXPMMe76ZfNfhCQ= Received: from TYZPR03MB5566.apcprd03.prod.outlook.com (2603:1096:400:53::7) by TYZPR03MB5598.apcprd03.prod.outlook.com (2603:1096:400:5e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.25; Thu, 25 Jan 2024 02:24:53 +0000 Received: from TYZPR03MB5566.apcprd03.prod.outlook.com ([fe80::33a9:162c:3c6e:4a0d]) by TYZPR03MB5566.apcprd03.prod.outlook.com ([fe80::33a9:162c:3c6e:4a0d%7]) with mapi id 15.20.7228.023; Thu, 25 Jan 2024 02:24:52 +0000 From: =?utf-8?B?WmhpIE1hbyAo5q+b5pm6KQ==?= To: "sakari.ailus@linux.intel.com" CC: "heiko@sntech.de" , "gerald.loacker@wolfvision.net" , "robh+dt@kernel.org" , "yunkec@chromium.org" , "linux-kernel@vger.kernel.org" , "dan.scally@ideasonboard.com" , "linux-media@vger.kernel.org" , =?utf-8?B?U2hlbmduYW4gV2FuZyAo546L5Zyj55S3KQ==?= , "hdegoede@redhat.com" , "linus.walleij@linaro.org" , "andy.shevchenko@gmail.com" , =?utf-8?B?WWF5YSBDaGFuZyAo5by16ZuF5riFKQ==?= , "mchehab@kernel.org" , "jacopo.mondi@ideasonboard.com" , "jernej.skrabec@gmail.com" , "linux-mediatek@lists.infradead.org" , "bingbu.cao@intel.com" , Project_Global_Chrome_Upstream_Group , "conor+dt@kernel.org" , "10572168@qq.com" <10572168@qq.com>, "hverkuil-cisco@xs4all.nl" , "tomi.valkeinen@ideasonboard.com" , "krzysztof.kozlowski+dt@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "laurent.pinchart@ideasonboard.com" , "devicetree@vger.kernel.org" , "angelogioacchino.delregno@collabora.com" , "macromorgan@hotmail.com" Subject: Re: [PATCH v3 2/2] media: i2c: Add GC08A3 image sensor driver Thread-Topic: [PATCH v3 2/2] media: i2c: Add GC08A3 image sensor driver Thread-Index: AQHaQqOcaJSxAdVZgECzYCFgQ+2t6LDRRRWAgBig/YA= Date: Thu, 25 Jan 2024 02:24:52 +0000 Message-ID: <42cf05ea80a2413aae588b762e67c3418b9514d4.camel@mediatek.com> References: <20240109022715.30278-1-zhi.mao@mediatek.com> <20240109022715.30278-3-zhi.mao@mediatek.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR03MB5566:EE_|TYZPR03MB5598:EE_ x-ms-office365-filtering-correlation-id: f20edf70-8d04-4058-4842-08dc1d4cd04e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4Vf+ASjx4w/UAcgCoNgicn0KLUN00gfvDuiI2WWA8ymFYHPoPHzTdB9IZ96ol1kJqvbLQjSCJpn27h1Yj3OjAkZlILFhsJdkMrioHqLs+6GRFoUZoN9h5kypaDr9IZHmneSywUGnzxE0MFHZ3QwUgLVq59SUrodvd+4pkeZzGnMKjf0f6o3ze7WNQJg/mAQ6/kh5A3xLFPbtLJi1vVvaJWNZ3/DOzSyGO8rAf9I5aliZZRssKRy4x24CpWdwoA9W1LvZKTT2MpNidVkhtSBQkpTeHFvoGtpBYrxSiIsMAY10M4YOBM1KZEFs6w2QLFtp9exHP9go889/7iBlqYFSBhNyzle9eBO9PKcxywAKXkD+dixq4zIK523ct2kdEdCko0KVJxBZT3qKBIg2UHxt0pA+fNLC8dD2z+Z6nlTDz4U60HzFxznDIdq+V7zy/3eebhpOxAvM0qvZT40ezfurwz09xsrliAWlMKtYAuiU1izhNZnfLYft6AtUrZdHdciRA1FaFY9febYUphdzaCmzJN5mzK8myOMQVAOT8sCYO/j1bWG6J89KxYa6PPkItZVwV9oZes+0e1svz+4sEWmqquUmc6NdysBv2qj1U6ohVreh16O7pOY2H35wYsEOYuitlJmGcLzArWx270tft2Biug== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYZPR03MB5566.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(39860400002)(366004)(376002)(396003)(346002)(230173577357003)(230922051799003)(230273577357003)(451199024)(1800799012)(64100799003)(186009)(41300700001)(83380400001)(6512007)(38100700002)(26005)(2616005)(8676002)(4326008)(8936002)(5660300002)(7416002)(2906002)(478600001)(6506007)(966005)(6486002)(66476007)(71200400001)(66556008)(54906003)(64756008)(66446008)(66946007)(6916009)(316002)(76116006)(122000001)(38070700009)(36756003)(85182001)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZWRwYUZIN2Q3T1ZhVzlFQ3FVeU85R0lGMDhGQkFXL3FxRjhJdWVUcUZtak51?= =?utf-8?B?aWh1NVlnenFad2xlRnlwZmFyVFlGdWdETFNaclpWaUZNSGp4MkJiWWJaUlVL?= =?utf-8?B?S1JUN2FtSy95dDl4ZTh3Uk9vV2dEaE1BVmVjMSswMmVtSVAyTHFOcW1IUnh4?= =?utf-8?B?anlLaTNHbGpZVzRYT1FnbU1MMGE0Q255YmVFcDR2SThxTUlTc3YrM0RqdXFH?= =?utf-8?B?VXg5VzFtdStNZU9qaU9KRjN0NENzY1Q5N1dGNW5ib3liWkpiZ1d2NG9JYndk?= =?utf-8?B?VDNLZTZWY0JVOTRpcXRkbWMxcWwxSEc3OEdXdGlZM0pSNVphVzFhK2NJZWsz?= =?utf-8?B?K1YyVzBmRWdReTJSRTFPOTVOOExTVHBod0dhOGpNZkREZWYwYURQS0RJSTBn?= =?utf-8?B?QmtVTkY3bGxmVHFhVmRhZEQ3Q1U3VUs3WlZQcDEyWFROTWxkVWFSdXhvNG01?= =?utf-8?B?ODhPdFFzYzc5aFd0bDJlNERWUzhqd1dZSEdEaHlXOXIzS0FBTHgxTnV0VVJB?= =?utf-8?B?LzlHR00rSzhQdWZaclVCQzgxb1FCNWpQeEhkUnJTRVFjM3hITmZwUXlRNjRM?= =?utf-8?B?cXcrc2Q2aDFzTE4yUndVL0JDblA3bWdNUDl4QXhpVEszMzZRTXdEZS9HYk9M?= =?utf-8?B?Qlg1TDJtZE92dE5DT0V1MTF6U0ZEOVFISUJBQnZpbjN3ejU5Q2hXQkwrM29V?= =?utf-8?B?a1FGWW56dnlsQ0pZYXI5YjFSMS90blBkTUN4STQyWGxCU2VZTVNyelZpNEha?= =?utf-8?B?REJNU2xWYlhSYjFGdWdhUHhPQTBoc28rV2JWWDAxck1sSlBpTGg3eWpmRmJV?= =?utf-8?B?czVUc2doWUNoVG1ISUE4Q0hoUmdlbW55T1hOeXYyVVJ0dkhKNUJ1eVFMdkc1?= =?utf-8?B?QlVlYUJKTkNJaEZnUFA4Z01FNGVHd01KT1JWdXFsdlNadzBwVWpGeU9rWWVN?= =?utf-8?B?WmNLeXdGWDNYSi80aW5Dd0Q3MmVEUk5hYTMvUllCT3N1eEJVdExZWm45M1Fn?= =?utf-8?B?a1AxVlpUditLZFZTbldiVEl3cStPNWlKYVhqY1FGUnQwb3IxZUJXbWRkUEdB?= =?utf-8?B?eHNabW42cjZIVmhuNENlc2JwOE03cDNBdkpYUWtPUWkzMFlOU3YzSmdBWnpW?= =?utf-8?B?QlZEVlpUV2Zxd2JVNHRGVmlPV015ZWNma0loRGNsZmlwSnhRcVZzNzd4NGQ0?= =?utf-8?B?OHhLRDZLVXdiZUZwNFJSVnFqSDljbTJTeExhTDB4NFBlUHl2MzAvM0JNMXF1?= =?utf-8?B?TFpoU0M5RXgxTWpEU3lsYmtTTFMrM3V3UVdYVDF2L05BWmpva092RnJuWjYr?= =?utf-8?B?UzNxQU1ZVG4vSCttaFZEYzdsd1ZrNWt4MFNvdU9XeHlWaWZQN09yOWd4KzN4?= =?utf-8?B?d1Jyd29OZzFhT095bzF1bUtNL0pDQzNUVDJ4bnFoNmRCZXlJWGJvQjI0ajUy?= =?utf-8?B?ZUo5NkREVWZiWXJxaU9mQm96SXBvb0g3UjFrWmlIZVBKNnFpdENQUnRMT09t?= =?utf-8?B?dTBpTlFvSnlUQkN0Y0VKQlhuY0xhTHV1VnlSRHpZV0o3NWJjUDJsTGFFYzV2?= =?utf-8?B?ZksxUG5jRXp6ekJMU203eEJVa01ncjBsMFJrOHVyYXJ6Vk1XMDlzUi93L3FK?= =?utf-8?B?MU81dUlOK1dia2hVUjYva0RXWWlCZCtGcXlELzRhT29ZRUtMMGp2UUhMZ0JT?= =?utf-8?B?VklGejhjdkkycTQwV3hQWk00Y1hjSk94YmV2Z3NRUDBxMlYvdjQ3bkc2RW9E?= =?utf-8?B?aUlzZDc5UmQ4ZEk3ekpjTEZTYjVGVWFRUkNIS3ZFZVNUcnBsK08rZzRhajlF?= =?utf-8?B?WFRTUFc0Q0xQV1NZTEFYQzlBRjB0YlNlVWd2NUZraDUvWnJGREViVDU5MzY2?= =?utf-8?B?bjI2aUtqOWFoUTg5Q2o5ZkJXSVgwSXg1RUdMRjRURVBHbTc5bHZISS9HOTE0?= =?utf-8?B?N3BLVXZ0djcvUHhkWll4c0JRd1lmZDVXNG80ZW5zQVBRcFI1T0MzWHBHbEdj?= =?utf-8?B?dWMwTE81Z0VmYnFkWmIrTGFCcjBWK0tFUjg1ZmNuTGdsdXdsdDVRSFd0OWVv?= =?utf-8?B?WTl5bGtReGpWR0FIeEcwL2R4dlR5cDFvYS9MbXVtV0ZMU3RCOFJxbTBySkdx?= =?utf-8?Q?KhMGkV5iz9GX0hVANoIfaJ04W?= Content-ID: <963AB80C94EA0A44A160675A0B530D3E@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB5566.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f20edf70-8d04-4058-4842-08dc1d4cd04e X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2024 02:24:52.8761 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 65VgTYLudxcpuwwJOVnFuJJpFzsza7ZKGyWxm0qklvrezL8aRAs+PbITOff1vYTOpgmj5mCsCQgrLIqFnbeSOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR03MB5598 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240124_183505_576784_DF59AD87 X-CRM114-Status: GOOD ( 18.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sakari Thanks for your review code and comments. On Tue, 2024-01-09 at 10:18 +0000, Sakari Ailus wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > Hi Zhi, > > Thanks for the update. > > On Tue, Jan 09, 2024 at 10:27:15AM +0800, Zhi Mao wrote: > > Add a V4L2 sub-device driver for Galaxycore GC08A3 image sensor. > > > > Signed-off-by: Zhi Mao > > --- > > drivers/media/i2c/Kconfig | 10 + > > drivers/media/i2c/Makefile | 1 + > > drivers/media/i2c/gc08a3.c | 1467 > ++++++++++++++++++++++++++++++++++++ > > 3 files changed, 1478 insertions(+) > > create mode 100644 drivers/media/i2c/gc08a3.c > > > > +for (i = 0; i < ARRAY_SIZE(link_freq_menu_items); i++) { > > +for (j = 0; j < bus_cfg.nr_of_link_frequencies; j++) { > > +if (link_freq_menu_items[i] == > > + bus_cfg.link_frequencies[j]) > > +break; > > +} > > + > > +if (j == bus_cfg.nr_of_link_frequencies) { > > +dev_err(dev, > > +"no link frequency %lld supported, please check DT", > > +link_freq_menu_items[i]); > > +ret = -EINVAL; > > +goto done; > > +} > > +} > > Please use v4l2_link_freq_to_bitmap() available here > https://lore.kernel.org/linux-media/20240108151805.55584-2-sakari.ailus@linux.intel.com/T/#u> > ;. > We'll then merge both at the same time. > After got the latest linux kernel code base(tag: next-20240124), there seems to be not new API:v4l2_link_freq_to_bitmap() still. Would you please let me know, how about the status about this API? Thanks & Regards, Zhi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel