From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D6EFC433EF for ; Tue, 15 Feb 2022 06:49:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e+rT5v1eOCn7iST7qSjjz//BRcDEn8S0U6zeH6hQpPk=; b=e9wGepED6fct7q hAKW0tV/gT11Giu7artxamW8BdyCJ1ATeR33jh7L9Yt33nLKShXxR0ywtzmR8AjFa3a89olgykOSx GylyZwH5IGID8VUYPSqumyt6sJBLYf9aTrn9JrjUSr3236IWhmw6PKmnV5gmcHRAztlLD9wFFlWCz HUR1y8F1IToZCFg+AGdcxDvtvVpbCnIK0oD2frK/AOAwvCOdv04OfLLgudp0aHaHkAV0V1mu+0PZ2 WcoNAMsjd229VkeFlWKB00Opym+d0Q670FFbniIA9DHg8o5NVMJ7SL/V8PLcTJv4b5AV2WzHN3UVw cCcuGFFGrxo/jIu7NT0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJrd7-000qwM-20; Tue, 15 Feb 2022 06:48:05 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJrd3-000qve-QS; Tue, 15 Feb 2022 06:48:03 +0000 X-UUID: 338cb99aee08452dae53dec9899dbe24-20220214 X-UUID: 338cb99aee08452dae53dec9899dbe24-20220214 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1199404721; Mon, 14 Feb 2022 23:47:59 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 14 Feb 2022 22:37:58 -0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 15 Feb 2022 14:37:56 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 15 Feb 2022 14:37:56 +0800 Message-ID: <42d78659a50a98845e9bce47abcfe4bc3dff2c8c.camel@mediatek.com> Subject: Re: [PATCH v3 19/31] clk: mediatek: Add mtk_clk_simple_remove() From: Chun-Jie Chen To: Chen-Yu Tsai , Stephen Boyd , Michael Turquette , Matthias Brugger CC: AngeloGioacchino Del Regno , Miles Chen , , , , Date: Tue, 15 Feb 2022 14:37:56 +0800 In-Reply-To: <20220208124034.414635-20-wenst@chromium.org> References: <20220208124034.414635-1-wenst@chromium.org> <20220208124034.414635-20-wenst@chromium.org> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220214_224801_870058_29E76B38 X-CRM114-Status: GOOD ( 19.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2022-02-08 at 20:40 +0800, Chen-Yu Tsai wrote: > In commit c58cd0e40ffa ("clk: mediatek: Add mtk_clk_simple_probe() to > simplify clock providers"), a generic probe function was added to > simplify clk drivers that only needed to support clk gates. However > due > to the lack of unregister APIs, a corresponding remove function was > not > added. > > Now that the unregister APIs have been implemented, add > aforementioned > remove function to make it complete. > > Signed-off-by: Chen-Yu Tsai > Reviewed-by: Miles Chen > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> Reviewed-by: Chun-Jie Chen > --- > drivers/clk/mediatek/clk-mtk.c | 15 +++++++++++++++ > drivers/clk/mediatek/clk-mtk.h | 1 + > 2 files changed, 16 insertions(+) > > diff --git a/drivers/clk/mediatek/clk-mtk.c > b/drivers/clk/mediatek/clk-mtk.c > index 869e6ae55c82..f108786caeda 100644 > --- a/drivers/clk/mediatek/clk-mtk.c > +++ b/drivers/clk/mediatek/clk-mtk.c > @@ -374,6 +374,8 @@ int mtk_clk_simple_probe(struct platform_device > *pdev) > if (r) > goto free_data; > > + platform_set_drvdata(pdev, clk_data); > + > return r; > > free_data: > @@ -381,4 +383,17 @@ int mtk_clk_simple_probe(struct platform_device > *pdev) > return r; > } > > +int mtk_clk_simple_remove(struct platform_device *pdev) > +{ > + const struct mtk_clk_desc *mcd = > of_device_get_match_data(&pdev->dev); > + struct clk_onecell_data *clk_data = platform_get_drvdata(pdev); > + struct device_node *node = pdev->dev.of_node; > + > + of_clk_del_provider(node); > + mtk_clk_unregister_gates(mcd->clks, mcd->num_clks, clk_data); > + mtk_free_clk_data(clk_data); > + > + return 0; > +} > + > MODULE_LICENSE("GPL"); > diff --git a/drivers/clk/mediatek/clk-mtk.h > b/drivers/clk/mediatek/clk-mtk.h > index 3c3a934f53cd..4fa658f5d934 100644 > --- a/drivers/clk/mediatek/clk-mtk.h > +++ b/drivers/clk/mediatek/clk-mtk.h > @@ -202,5 +202,6 @@ struct mtk_clk_desc { > }; > > int mtk_clk_simple_probe(struct platform_device *pdev); > +int mtk_clk_simple_remove(struct platform_device *pdev); > > #endif /* __DRV_CLK_MTK_H */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel