From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A922ECD1288 for ; Wed, 3 Apr 2024 03:29:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kZeIGeQcDQ6Y/+p1g/UvD9uo3UVlWlyqmgEwMcaTLvs=; b=hclMQnbCM6BQ3Y Wmk+W0P2ZBI9vAmKGFMjBXZJftZOC6AuPeF7yrxNMj+2pue8fz86pLpPno5z/Dtw8OVmOQ7nxcHAA slTvWtnhfcEIaAX/1cH70FsnYsTFQ8jlJIpjMvJu8+ZgNjTtz4QHRRjmRBVj4RA0KC0jCm8UbrIRA GLiQwYGTVZ9Nx8DikOHVNGJxj2w+vaFM0jYRargqF5Un3RrWU1pRVWwgze69Q/6OCPvql4kOAX3Kr q2f/LhqT/eA0g79Hp1qzKb40CrXk1R3U/1XCKrXF3Koym/T+BorL2nEFFAriAdaVhu38Of/shr5mh cSpokVxTSq1fuPYCGV0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrrJf-0000000DmZ2-0jaF; Wed, 03 Apr 2024 03:29:35 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrrJb-0000000DmY6-4AnN for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2024 03:29:33 +0000 Received: from [192.168.68.112] (ppp118-210-182-70.adl-adc-lon-bras34.tpg.internode.on.net [118.210.182.70]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id BF8CF20075; Wed, 3 Apr 2024 11:29:18 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1712114969; bh=1EIgt9ACWXed19+CaCKn14yKWR326KDE1bbmos0k4nQ=; h=Subject:From:To:Date:In-Reply-To:References; b=WM/sePX4JC/BBusJTYbStdbfybWmQb6z2+R9oPr1BMeNxlNrdw5bi0fYd8PdI7ycT 6H8szIlqqZs8NWFXbe+6ZCHY0l1gcQwuzTnIja7f46/h26kG7rDSwKcDIp3dJvODGg XXO9GKtObUHJCX4YPJXN5FllsBTKhoiVzBbfJcL8lM3JUW6x69IEjM8tuqrUDXYCd8 7OCM/5BxRwaaEsLPMsoamm8Qd1pQi92Vl/aMhPujUv/rXA3+u67j+pQLEwofxC66w6 /pDKlcOnnUDt9pR+0w94bfUgsOXdlCnLHazyMvuNUIoCl/SAL7OJghdsC8Kd1pDjko lHGvD8/TY40/Q== Message-ID: <42e91dc2bccdcac96abd729def8a05b2612488a7.camel@codeconstruct.com.au> Subject: Re: [PATCH 2/3] ARM: dts: Disable unused ADC channels for Asrock X570D4U BMC From: Andrew Jeffery To: Renze Nicolai , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org, arnd@arndb.de, olof@lixom.net, soc@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au, andrew@aj.id.au Date: Wed, 03 Apr 2024 13:59:17 +1030 In-Reply-To: <20240329130152.878944-3-renze@rnplus.nl> References: <20240329130152.878944-1-renze@rnplus.nl> <20240329130152.878944-3-renze@rnplus.nl> User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_202932_247970_60FCB872 X-CRM114-Status: UNSURE ( 7.05 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Renze, On Fri, 2024-03-29 at 14:01 +0100, Renze Nicolai wrote: > This commit disables unused ADC channels and labels the ADC channels used with their function. Please run this through checkpatch and address the warnings. Also, the submitting patches documentation[1] suggests using the imperative mood - instead of "This commit disables ...", use "Disable ...". The change subject is phrased the expected way. [1]: https://docs.kernel.org/process/submitting-patches.html Taking the subject and the description together, the description feels a little redundant. Maybe it could be trimmed back to > Also, label the ADC channels used with their function. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel