From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA7F7C2BA18 for ; Thu, 20 Jun 2024 23:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:Subject:From:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pmtddJthMQKvJgmwUwcCqsfsT87mXd0DUJUxKPzoExg=; b=m3ylDHxbqa5OgjRwj76TQ6wi9X BB27Agn2Xv1nmmfEbeCZfpzWX8zchzjfJ412OQ42SVZFpCtRAN+lF8NFtsQMEjqvyMdlN0P1VTyYo 7azOG2RxaCjuve/eefyKvMLnWYlCw1ZR69+icgNt/84fNj83+GVX4cZ8VX1lc4SoT33cgmZwd0HDE rXFu13jOB+jQ8Opwpk0/BLSoAKgnCBf3FEaYlhmjBYy0KmUbIu3dRFHseawBC3igqYqkK+kpyymqW 9RlOgsK9ohmKJ+AiFBBR8HFs23tR8Pt3y0j4hQFRv6vTQYR0niMonHGFj3r1dZgvNBwaNQ8vJ3c1L O+jdumdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKRan-00000007A1c-2Ndq; Thu, 20 Jun 2024 23:53:25 +0000 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKRaj-00000007A0E-16LM for linux-arm-kernel@lists.infradead.org; Thu, 20 Jun 2024 23:53:22 +0000 Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-652fd0bb5e6so1155836a12.0 for ; Thu, 20 Jun 2024 16:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718927600; x=1719532400; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=pmtddJthMQKvJgmwUwcCqsfsT87mXd0DUJUxKPzoExg=; b=RHWNUURqzGYYZuOpY7+sq50Ge22yMO0whqHuD2Jo2iA5iJjxO0MEqVm2UXKrEVwblw FlyoVnDkdLXe0vVzkMFAdtDeCvbJBLe1bgDL0pGPWpHh4sTOA6xrf0vUh87mPS0i+4Na u4mBD35GXlal2x/CdseIqngEfy6+NTwLwzfFlaUUFzxch0ixvX5AFL55aRPtqEiHCBFW KL+0M2jAPe1FLBE5HwKCr1ebrYbteBV29ozIFbS2NLSuyDKW9EG+weeNWf7rBK39seWg iqMbyYG7Vz8GwZW1GpZ3dMv4vuHnq3s61v4PLZ+cjMHW+kt3bRvoFQkIxbRojODtlYWu EPSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718927600; x=1719532400; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pmtddJthMQKvJgmwUwcCqsfsT87mXd0DUJUxKPzoExg=; b=W5au0ABrSOTcQxTbN5DcDdz3KdbwYnnt/pfU3QAS0cycOO78Z9jxB2RVzmLUniGA2O I773bH3xOBvidv7aSOTKeg1HnPd7asvBk6KNVa1J353AsLE58ZVsLwFTD2HGkXLwwCis cuFe0YYfS0FP0nP/updZHZ3zM745JVX8i8FfCZfgGsXbqSGbi4sU9D0sQ2rus5nqwWQm hr8DOdJSTf/spA8LMqWVKc7qiYnF0MgjrhGLhpnTM542yMV8/UxfwKHcEXL2Ox2sxBEe H3VSQtLsK8cOnnL3mvQ58q3mdH6W1kR+uDyz503xbmIeQ5XqI63dqqCi+JHDE5VyofPp tn7g== X-Forwarded-Encrypted: i=1; AJvYcCXzasXg1tUQ8DULihtQH+uCevCuiiRXUgV+Tw5yHSoLEtf8AlvwkhmORDazv+Wb8d8VPNMdIG2gp6l7ThHvt4kdTYv+ZpBwiAqVvtaEx4ADTenPbxw= X-Gm-Message-State: AOJu0Yx9lmhoO5HlDeWvKGnR1q7+pYWLOGXqhs2gMe23MqTaBbXXGWCX XW5n4VM3KBnZ0NudcTj+aY6tzRTZ9JqV72lANdAwqNou7Z32NJHFyCU9Zn4kJz4= X-Google-Smtp-Source: AGHT+IFl3mGlSWyDautXUIxFZI07Ej5Fg9/SYd7TZo9A403tsBfjofIAmHGJpKVRmou+OtVc2sq2jA== X-Received: by 2002:a05:6a20:47dd:b0:1b6:f34c:95b3 with SMTP id adf61e73a8af0-1bcbb60fca3mr6195673637.59.1718927599987; Thu, 20 Jun 2024 16:53:19 -0700 (PDT) Received: from [172.19.1.51] (60-250-192-107.hinet-ip.hinet.net. [60.250.192.107]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9ebbc8efbsm1769175ad.306.2024.06.20.16.53.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jun 2024 16:53:19 -0700 (PDT) Message-ID: <42ec842e-84c0-40fd-b6fc-e59d25ede89f@gmail.com> Date: Fri, 21 Jun 2024 07:53:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Shan-Chun Hung Subject: Re: [PATCH 1/2] dt-bindings: mmc: nuvoton,ma35d1-sdhci: Document MA35D1 SDHCI controller To: Krzysztof Kozlowski , ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, adrian.hunter@intel.com, p.zabel@pengutronix.de, pbrobinson@gmail.com, serghox@gmail.com, mcgrof@kernel.org, prabhakar.mahadev-lad.rj@bp.renesas.com, forbidden405@outlook.com, tmaimon77@gmail.com, andy.shevchenko@gmail.com, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com References: <20240619054641.277062-1-shanchun1218@gmail.com> <20240619054641.277062-2-shanchun1218@gmail.com> <3d193f01-2c8b-4d6c-8139-11f2d9a34d2d@kernel.org> Content-Language: en-US In-Reply-To: <3d193f01-2c8b-4d6c-8139-11f2d9a34d2d@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240620_165321_329783_8A7C1605 X-CRM114-Status: GOOD ( 18.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dear Krzysztof, Thanks for you review On 2024/6/19 下午 03:29, Krzysztof Kozlowski wrote: > On 19/06/2024 07:46, Shan-Chun Hung wrote: >> Add binding for Nuvoton MA35D1 SDHCI controller. >> >> Signed-off-by: schung > Since this was not tested, only limited review follows. Please test your > future patches. > >> --- >> .../bindings/mmc/nuvoton,ma35d1-sdhci.yaml | 106 ++++++++++++++++++ >> 1 file changed, 106 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mmc/nuvoton,ma35d1-sdhci.yaml >> >> diff --git a/Documentation/devicetree/bindings/mmc/nuvoton,ma35d1-sdhci.yaml b/Documentation/devicetree/bindings/mmc/nuvoton,ma35d1-sdhci.yaml >> new file mode 100644 >> index 000000000000..173449360dea >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mmc/nuvoton,ma35d1-sdhci.yaml >> @@ -0,0 +1,106 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id:http://devicetree.org/schemas/mmc/nuvoton,ma35d1-sdhci.yaml# >> +$schema:http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Nuvoton MA35D1 SD/SDIO/MMC Controller >> + >> +maintainers: >> + - Shan-Chun Hung >> + >> +description: | > Do not need '|' unless you need to preserve formatting. I will remove '|' >> + This controller on Nuvoton MA35 family SoCs provides an interface for MMC, SD, and >> + SDIO types of memory cards. >> + >> +properties: >> + compatible: >> + oneOf: > Drop I will remove oneof. >> + - enum: >> + - nuvoton,ma35d1-sdhci > Blank line I will fix it. >> + reg: >> + maxItems: 1 >> + description: The SDHCI registers > Drop I will remove description. >> + >> + interrupts: >> + maxItems: 1 >> + >> + pinctrl-names: >> + description: >> + Should at least contain default and state_uhs. > ? Contradicts constraints. I will modify the description to "Should at least contain default. state_uhs is mandatory in this scenario." >> + minItems: 1 >> + items: >> + - const: default >> + - const: state_uhs >> + >> + pinctrl-0: >> + description: >> + Should contain default/high speed pin ctrl. >> + maxItems: 1 >> + >> + pinctrl-1: >> + description: >> + Should contain uhs mode pin ctrl. >> + maxItems: 1 >> + >> + clocks: >> + minItems: 1 > No, maxItems instead. I will fix it. >> + description: The SDHCI bus clock > Drop I will remove it. >> + >> + resets: >> + maxItems: 1 >> + description: >> + Phandle and reset specifier pair to softreset line of sdhci. > Drop I will remove it. >> + >> + nuvoton,sys: > 1. too generic, what is sys? > >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: >> + Phandle to the syscon that configure sdhci votage stable I will modify description as follows:   nuvoton,sys:     $ref: /schemas/types.yaml#/definitions/phandle     description: phandle to access GCR (Global Control Register) registers. >> 2. typo: voltage I will fix it. >> 3. Which syscon? same as 1. >> 4. Why you are not implementing regulators? >> I will add "vqmmc-supply = <&sdhci1_vqmmc_regulator>;" in the examples. This requlator is used by regulator-gpio driver. >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - clocks >> + - pinctrl-names >> + - pinctrl-0 >> + >> +unevaluatedProperties: false > Hm? And where is ref to MMC schema? I will add as follows: allOf:   - $ref: sdhci-common.yaml# >> + >> +examples: >> + - | >> + #include >> + #include >> + #include >> + >> + soc { >> + #address-cells = <2>; >> + #size-cells = <2>; > Fix your indentation. > > Use 4 spaces for example indentation. I will fix it. >> + sdhci0: sdhci@40180000 { > Drop label I will fix it. >> + compatible = "nuvoton,ma35d1-sdhci"; >> + reg = <0x0 0x40180000 0x0 0x2000>; >> + interrupts = ; >> + clocks = <&clk SDH0_GATE>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_sdhci0>; >> + bus-width = <4>; >> + max-frequency = <100000000>; >> + no-1-8-v; >> + status = "disabled"; > Drop I will fix it. >> + }; >> + >> + sdhci1: sdhci@40190000 { > Drop this example. One is enough. > > > > Best regards, > Krzysztof OK , I will remove one. Best Regards Shan-Chun