From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB9B1C43603 for ; Mon, 16 Dec 2019 18:33:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E65C207FF for ; Mon, 16 Dec 2019 18:33:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oxIWx/l+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EPNmuv7M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E65C207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KGS/qd0UsvMc4XRSn9t20RZChrV/5hH6JIw6rSfNnc4=; b=oxIWx/l+X1g05j w0t7Bc83NjBy3wZHMNTFP+bAtxeZ3bsL1a+orJxpsaEXrYvKdf4zk1RAi7G4ZJ7Yzf96up6FZn9Yy Zpr0kVCajMTgUl5b9IqGDyryKexkM2CVOwWZQczTtZehDtkUTPMaXQVpAeCZqREjub6D/RVUUKvMn il5zYE3ojwzU7MHl7YKlqmaUUSNwBOqmZrr/D6EUZTKPb0LEKfH7QAY2RCCFjRFMGP9PHKfsfsJ4t BPXSamaQn6xMOMvACxPH2rwLYl9tqFqDe0/EEiDH5bQxztua+skjh+x3nR1q+xNDKqYTsjMWKpG2T rj9v6SYC5SuqNqWga9dg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1igvBA-0001zz-Rw; Mon, 16 Dec 2019 18:33:12 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1igvAy-0001pK-Rw for linux-arm-kernel@lists.infradead.org; Mon, 16 Dec 2019 18:33:02 +0000 Received: by mail-pg1-x544.google.com with SMTP id z124so4171722pgb.13 for ; Mon, 16 Dec 2019 10:33:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LsjRazNxwIjB/kfHtlv+QoNeEmV3wJwVhLTpn5ed/GQ=; b=EPNmuv7MqNfortefo8XxuPcLZY3v2+0pE/+qs5Mn/GhZSLiGYUEIFwOATXAMBhey5i evD1gcEeThnipE0cQo9oRKVuW70omJvIx4KGpA+ONYBCnaayq7479PtwTiK8fkQd9PJp jXXnQczA3ti83FYCWD7QEfUngm2rHMWv3dj0nz4B5fYnwVA2FhEQA5kQXsvZPTj65Zpq W4d6W2uJkoTEJDk4HWbJ3J89oMQwwpfoBnsuSos7jCnUphCmRT2XJDKGYAlDyApOzjHy zx0KYeSXpgtcgoy0tJWJ6OZa0xqM3icfHeXZLiRB3vfkEhC0TzBI/R7nPp4RYRIcGvyz 5J3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LsjRazNxwIjB/kfHtlv+QoNeEmV3wJwVhLTpn5ed/GQ=; b=PqPRxzldwXtgjamZ9PQveTwPZYWS5aGEoVk5vplVBNpB2Cn+CgokITtGhXtB9s3DsD q+nljTq4hpwPo/uCkWRgd31R+MNkgAi7iEPqVgb0oUOI0SPzcQiyqxMh+ertU5y99PET B20ALnGyFbCoh4eeKzzIkkrxXuYNnSdCTV+t+x3oBfnI3pxMNGyRyIJ9Dqqf7sx7jWWE rkqbKuWUeBwuyy9aiBo559kl5UHp2k6dNAf0q2EDbKQru1sGsmcyWrVHmiijEhyBqbU7 vo+Dh/qe084XuSBh2TXrHo2ifBSwdGgeSN4S04h9FXR+3QZhXVjvOEz5x4WA0cOHTav4 o5og== X-Gm-Message-State: APjAAAXW3RKDVS8baAIRlP6mEgRuG1EstSAtGMF8mAnyGjwZZMrOhBBn 5clC/P/wPdizgtAy6wrTIqPflgUQ X-Google-Smtp-Source: APXvYqywyd+9sNBYjD8oNqLxF1Md9OVBnbnTKmYuQP3g7+J+J1BRsdzZYnneQ8i6drfpJFAw5/qcJg== X-Received: by 2002:a63:d62:: with SMTP id 34mr20598440pgn.268.1576521180321; Mon, 16 Dec 2019 10:33:00 -0800 (PST) Received: from localhost.localdomain (c-73-241-114-122.hsd1.ca.comcast.net. [73.241.114.122]) by smtp.gmail.com with ESMTPSA id d65sm23400738pfa.159.2019.12.16.10.32.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2019 10:32:59 -0800 (PST) From: Richard Cochran To: netdev@vger.kernel.org Subject: [PATCH net-next 1/3] net: axienet: Propagate registration errors during probe. Date: Mon, 16 Dec 2019 10:32:54 -0800 Message-Id: <42ed0fb7ef99101d6fd8b799bccb6e2d746939c2.1576520432.git.richardcochran@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191216_103300_899393_BCF6B607 X-CRM114-Status: GOOD ( 12.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Radhey Shyam Pandey , David Miller , linux-arm-kernel@lists.infradead.org, Michal Simek Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org The function, axienet_mdio_setup(), calls of_mdiobus_register() which might return EDEFER_PROBE. However, this error is not propagated to the driver's probe method, and so deferred registration cannot happen. This patch fixes the issue by handling the error code properly. Signed-off-by: Richard Cochran --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 20746b801959..53644abe52da 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -1835,9 +1835,10 @@ static int axienet_probe(struct platform_device *pdev) } ret = axienet_mdio_setup(lp); - if (ret) - dev_warn(&pdev->dev, - "error registering MDIO bus: %d\n", ret); + if (ret) { + dev_err(&pdev->dev, "error registering MDIO bus\n"); + goto free_netdev; + } } lp->phylink_config.dev = &ndev->dev; -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel