* [PATCH v2] arm: s3c: use string choices helper
@ 2025-06-17 23:40 Kuninori Morimoto
2025-06-18 6:16 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Kuninori Morimoto @ 2025-06-17 23:40 UTC (permalink / raw)
To: Alim Akhtar, Krzysztof Kozlowski, Russell King, linux-arm-kernel
We can use string choices helper, let's use it.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
- add commit message
arch/arm/mach-s3c/pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-s3c/pm.c b/arch/arm/mach-s3c/pm.c
index 5698cbceaf7a..6ef037dcb641 100644
--- a/arch/arm/mach-s3c/pm.c
+++ b/arch/arm/mach-s3c/pm.c
@@ -47,7 +47,7 @@ int s3c_irqext_wake(struct irq_data *data, unsigned int state)
return -ENOENT;
printk(KERN_INFO "wake %s for irq %d\n",
- state ? "enabled" : "disabled", data->irq);
+ str_enabled_disabled(state), data->irq);
if (!state)
s3c_irqwake_eintmask |= bit;
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm: s3c: use string choices helper
2025-06-17 23:40 [PATCH v2] arm: s3c: use string choices helper Kuninori Morimoto
@ 2025-06-18 6:16 ` Krzysztof Kozlowski
2025-06-18 22:52 ` Kuninori Morimoto
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-18 6:16 UTC (permalink / raw)
To: Kuninori Morimoto, Alim Akhtar, Russell King, linux-arm-kernel
On 18/06/2025 01:40, Kuninori Morimoto wrote:
> We can use string choices helper, let's use it.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> v1 -> v2
> - add commit message
Did you read the feedback? Not much improved.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm: s3c: use string choices helper
2025-06-18 6:16 ` Krzysztof Kozlowski
@ 2025-06-18 22:52 ` Kuninori Morimoto
2025-06-19 5:57 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Kuninori Morimoto @ 2025-06-18 22:52 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: Alim Akhtar, Russell King, linux-arm-kernel
Hi Krzysztof
Thank you for your review
> > We can use string choices helper, let's use it.
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> > v1 -> v2
> > - add commit message
> Did you read the feedback? Not much improved.
Ah, I have been mis-understood. Will post v3
Thank you for your help !!
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm: s3c: use string choices helper
2025-06-18 22:52 ` Kuninori Morimoto
@ 2025-06-19 5:57 ` Krzysztof Kozlowski
2025-06-19 6:03 ` Kuninori Morimoto
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-19 5:57 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: Alim Akhtar, Russell King, linux-arm-kernel
On 19/06/2025 00:52, Kuninori Morimoto wrote:
>
> Hi Krzysztof
>
> Thank you for your review
>
>>> We can use string choices helper, let's use it.
>>>
>>> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>>> ---
>>> v1 -> v2
>>> - add commit message
>> Did you read the feedback? Not much improved.
>
> Ah, I have been mis-understood. Will post v3
Why v3? Feedback was don't do it unless you provide good reasons why...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-06-19 6:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-17 23:40 [PATCH v2] arm: s3c: use string choices helper Kuninori Morimoto
2025-06-18 6:16 ` Krzysztof Kozlowski
2025-06-18 22:52 ` Kuninori Morimoto
2025-06-19 5:57 ` Krzysztof Kozlowski
2025-06-19 6:03 ` Kuninori Morimoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox