public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: cq93vc: fix cq93vc_get_regmap build error
@ 2014-04-30  9:06 Arnd Bergmann
  2014-04-30  9:21 ` Li.Xiubo at freescale.com
  2014-05-01  1:23 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2014-04-30  9:06 UTC (permalink / raw)
  To: linux-arm-kernel

49101a25acd69c "ASoC: cq93vc: Remove the set_cache_io() entirely from
ASoC probe" introduced the cq93vc_get_regmap function that has an
obvious build error referring to the 'codec' variable that is not
declared anywhere"

sound/soc/codecs/cq93vc.c: In function 'cq93vc_get_regmap':
sound/soc/codecs/cq93vc.c:157:34: error: 'codec' undeclared (first use in this function)
  struct davinci_vc *davinci_vc = codec->dev->platform_data;
                                  ^

This changes the code to compile again, presumably in the way it was
intended. Not tested.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Xiubo Li <Li.Xiubo@freescale.com>

diff --git a/sound/soc/codecs/cq93vc.c b/sound/soc/codecs/cq93vc.c
index 5ee48c8..537327c 100644
--- a/sound/soc/codecs/cq93vc.c
+++ b/sound/soc/codecs/cq93vc.c
@@ -154,7 +154,7 @@ static int cq93vc_remove(struct snd_soc_codec *codec)
 
 static struct regmap *cq93vc_get_regmap(struct device *dev)
 {
-	struct davinci_vc *davinci_vc = codec->dev->platform_data;
+	struct davinci_vc *davinci_vc = dev->platform_data;
 
 	return davinci_vc->regmap;
 }

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] ASoC: cq93vc: fix cq93vc_get_regmap build error
  2014-04-30  9:06 [PATCH] ASoC: cq93vc: fix cq93vc_get_regmap build error Arnd Bergmann
@ 2014-04-30  9:21 ` Li.Xiubo at freescale.com
  2014-05-01  1:23 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Li.Xiubo at freescale.com @ 2014-04-30  9:21 UTC (permalink / raw)
  To: linux-arm-kernel


> Subject: [PATCH] ASoC: cq93vc: fix cq93vc_get_regmap build error
> 
> 49101a25acd69c "ASoC: cq93vc: Remove the set_cache_io() entirely from
> ASoC probe" introduced the cq93vc_get_regmap function that has an
> obvious build error referring to the 'codec' variable that is not
> declared anywhere"
> 
> sound/soc/codecs/cq93vc.c: In function 'cq93vc_get_regmap':
> sound/soc/codecs/cq93vc.c:157:34: error: 'codec' undeclared (first use in this
> function)
>   struct davinci_vc *davinci_vc = codec->dev->platform_data;
>                                   ^
> 
> This changes the code to compile again, presumably in the way it was
> intended. Not tested.
> 

Reviewed-by: Xiubo Li <Li.Xiubo@freescale.com>

Thanks,


> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Xiubo Li <Li.Xiubo@freescale.com>
> 
> diff --git a/sound/soc/codecs/cq93vc.c b/sound/soc/codecs/cq93vc.c
> index 5ee48c8..537327c 100644
> --- a/sound/soc/codecs/cq93vc.c
> +++ b/sound/soc/codecs/cq93vc.c
> @@ -154,7 +154,7 @@ static int cq93vc_remove(struct snd_soc_codec *codec)
> 
>  static struct regmap *cq93vc_get_regmap(struct device *dev)
>  {
> -	struct davinci_vc *davinci_vc = codec->dev->platform_data;
> +	struct davinci_vc *davinci_vc = dev->platform_data;
> 
>  	return davinci_vc->regmap;
>  }

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] ASoC: cq93vc: fix cq93vc_get_regmap build error
  2014-04-30  9:06 [PATCH] ASoC: cq93vc: fix cq93vc_get_regmap build error Arnd Bergmann
  2014-04-30  9:21 ` Li.Xiubo at freescale.com
@ 2014-05-01  1:23 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-05-01  1:23 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Apr 30, 2014 at 11:06:29AM +0200, Arnd Bergmann wrote:
> 49101a25acd69c "ASoC: cq93vc: Remove the set_cache_io() entirely from
> ASoC probe" introduced the cq93vc_get_regmap function that has an
> obvious build error referring to the 'codec' variable that is not
> declared anywhere"

Applied, thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140430/1eea7104/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-05-01  1:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-30  9:06 [PATCH] ASoC: cq93vc: fix cq93vc_get_regmap build error Arnd Bergmann
2014-04-30  9:21 ` Li.Xiubo at freescale.com
2014-05-01  1:23 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox