From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A93DCC7EE23 for ; Tue, 30 May 2023 12:09:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dY+rvVo+l6nM7KFdT4Qq2UwpmVJi49FA4slPeClRsqM=; b=gdU6QLVwE+bWJ2 Dsrs6Lcr81JU55BWJncCdx7pdNYeZ8qm2XYmBGpL/yvxkt4iACulh/T50Tz28uGguJeTtTDKD+axN 6aOi/LP6gC0ltnNg53ob0gXA0UvshfJVy8YRf9EiPcyMcAV8UFaqcqaHeMmEQPugqqxjya9R+AU3M NKxx+0b+crO3/ywTU4/Q/WveWgBqL4Id2lJqN6nMS8T3bsn5NmJK7bAzhIvJSUjkmfsJTZ/+IDKN8 NR3JV8MB2u7HqN38BTrz1x/UVoopiqaja9q5rgfmbqyK9a6jTDfmi+xEKixe9ALbq9KD96GedfDMn I8RtwzvavCWcycaHRORQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q3y9l-00DnQ8-2B; Tue, 30 May 2023 12:08:53 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q3y9i-00DnO8-0F for linux-arm-kernel@lists.infradead.org; Tue, 30 May 2023 12:08:52 +0000 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34UC4pTN018239; Tue, 30 May 2023 14:08:32 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=eUMt/DGvSnsVrLlt9wTQ7XbXUJ6l9bqRdAwrT9NXRl4=; b=gpY60mVqFAHm5rhYyUhnApTQy+VI+kpHjEhL+RL0V2FdWiHUyjZb48b4pLS6qiNbGX2e 8xG4XR6+yUNpNSeUxA4EXa5JjMMkmNjj5IK73Vel8PP7cYDEwSL0b7/tylFqnodu4hur fbTNPB4qVeEaXOjcwJERDAbMS+VHSlHWumhHWNtGtSfgWnexxbyY9outi7zR0CxkGOB4 PPVL1rjtBiY/OfGpBt6JBbHG3PcHaoPvvt9Zf3zcy80AcRq+f+/mewrlw4x+tQTT9vFl zWUaCpiAUxiejXCqZ3+nZTRv+EaoIv/xBqq7cZpZoZgOpY4PQaXDVZztTUYO6JQAj1Yq hw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3qwdm5hhgj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 May 2023 14:08:32 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 5F0C610002A; Tue, 30 May 2023 14:08:30 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 3839E21ED5D; Tue, 30 May 2023 14:08:30 +0200 (CEST) Received: from [10.201.21.93] (10.201.21.93) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 30 May 2023 14:08:29 +0200 Message-ID: <4308327f-d2e2-e9a2-6add-5e0352d3f1e2@foss.st.com> Date: Tue, 30 May 2023 14:08:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 02/11] pinctrl: stm32: add stm32mp257 pinctrl support Content-Language: en-US To: Conor Dooley CC: Conor Dooley , , , Conor Dooley , Linus Walleij , Catalin Marinas , Will Deacon , Arnd Bergmann , Olof Johansson , , , , , , References: <20230529162034.20481-1-alexandre.torgue@foss.st.com> <20230529162034.20481-3-alexandre.torgue@foss.st.com> <20230529-enrich-clammy-14b498baf09f@spud> <879b7689-5663-28b5-9431-2fdd243ffff2@foss.st.com> <20230530-payday-gravity-45a26bd7f2dc@wendy> From: Alexandre TORGUE In-Reply-To: <20230530-payday-gravity-45a26bd7f2dc@wendy> X-Originating-IP: [10.201.21.93] X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-05-30_08,2023-05-30_01,2023-05-22_02 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230530_050850_706236_ACF08AB7 X-CRM114-Status: GOOD ( 20.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/30/23 10:56, Conor Dooley wrote: > On Tue, May 30, 2023 at 10:38:30AM +0200, Alexandre TORGUE wrote: >> Hi Conor >> >> On 5/29/23 20:04, Conor Dooley wrote: >>> On Mon, May 29, 2023 at 06:20:25PM +0200, Alexandre Torgue wrote: >>>> Add stm32mp257 pinctrl support. >>>> diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.h b/drivers/pinctrl/stm32/pinctrl-stm32.h >>>> index e0c31c4c8bca..5e5de92ddd58 100644 >>>> --- a/drivers/pinctrl/stm32/pinctrl-stm32.h >>>> +++ b/drivers/pinctrl/stm32/pinctrl-stm32.h >>>> @@ -24,6 +24,9 @@ >>>> #define STM32MP_PKG_AB BIT(1) >>>> #define STM32MP_PKG_AC BIT(2) >>>> #define STM32MP_PKG_AD BIT(3) >>>> +#define STM32MP_PKG_AI BIT(8) >>>> +#define STM32MP_PKG_AK BIT(10) >>>> +#define STM32MP_PKG_AL BIT(11) >>> >>> Mainly out of curiosity, why have you go duplicate defines for these? >> >> Mainly to fit with available packages for various STM32 MPU. Currently MP1 >> SoCs are available with packages AB/AC/AD and MP2 series with AI/AK/AL but >> in the future we could have package AB/AC/AD/AI available for a particular >> SoC and then I need to anticipate this case. > > Sorry, what I meant was "why have you got defines for these in this > header, when there is an existing set in > include/dt-bindings/pinctrl/stm32-pinfunc.h?". Ok, I see. To be honest I do it as we did in the past for STM32 MCU and MP1 products. We had this discussion maybe 5 or 6 years ago about the fact to include or not the "dt-bindings" file in the stm32 drivers. I don't remember exactly the rational behind our choice. It is something that we could improve for all our STM32 products. Sorry for this imprecise answer. Alex > > Cheers, > Conor. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel