From: elfring@users.sourceforge.net (SF Markus Elfring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] [media] c8sectpfe: Improve two size determinations in c8sectpfe_frontend_attach()
Date: Fri, 15 Sep 2017 18:02:14 +0200 [thread overview]
Message-ID: <432261cc-ecf1-0673-b8e2-9ca317ceb772@users.sourceforge.net> (raw)
In-Reply-To: <3e5fcfbe-828a-8c15-12d4-c74e8a1f20f1@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 15 Sep 2017 17:30:38 +0200
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c
index 1b23b188cd65..c3b09a9e30ec 100644
--- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c
+++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c
@@ -164,12 +164,10 @@ int c8sectpfe_frontend_attach(struct dvb_frontend **fe,
tda18212 = devm_kzalloc(c8sectpfe->device,
- sizeof(struct tda18212_config),
+ sizeof(*tda18212),
GFP_KERNEL);
if (!tda18212)
return -ENOMEM;
- memcpy(tda18212, &tda18212_conf,
- sizeof(struct tda18212_config));
-
+ memcpy(tda18212, &tda18212_conf, sizeof(*tda18212));
tda18212->fe = (*fe);
tda18212_info.platform_data = tda18212;
--
2.14.1
prev parent reply other threads:[~2017-09-15 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 16:00 [PATCH 0/2] [media] C8SECTPFE: Adjustments for c8sectpfe_frontend_attach() SF Markus Elfring
2017-09-15 16:01 ` [PATCH 1/2] [media] c8sectpfe: Delete an error message for a failed memory allocation in c8sectpfe_frontend_attach() SF Markus Elfring
2017-09-15 16:02 ` SF Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=432261cc-ecf1-0673-b8e2-9ca317ceb772@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).