From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA392C433EF for ; Thu, 25 Nov 2021 19:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O4fEPKKq3ahok4OiwJbPE44nlQXG8jXOmmzcjsgbew8=; b=QO5LjJOTcjoRx2 5boQorCUBsgpev0OzVCq3TxVPV00pPL+poW9QBweKqzORVs7lpS+wZAo4+ynEIe1PjsPHJzdi86T3 9o6fkgX18NgVr2RNXAKufB9v+7LoRkczQZzfXTl20nqMaPPCGwA1nfr4VcFUG7hjqVb/Gvy/S+Q3H SV3FteI6S6Elc2UnPx7jyheJUtoalql38HeIAwbIEcLbk4qQCtYc6npNopMzdVwAiVxn+wWXmEozO +O4f66XkfMtDArDPwy5QDJ9dMfjqtMcitJwiIkoDJ3tWtvkLK9a95OMm3vfuvhjiJPyUp39+/fQS9 dCzG9wmjRPkcfgGX7W0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqKS2-008XJt-3h; Thu, 25 Nov 2021 19:30:34 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqKRx-008XJL-QF; Thu, 25 Nov 2021 19:30:31 +0000 Received: from ip5f5b2004.dynamic.kabel-deutschland.de ([95.91.32.4] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqKRs-0005mw-Ts; Thu, 25 Nov 2021 20:30:24 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Nicolas Frattaroli , Rob Herring , Johan Jonker Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] arm64: dts: rockchip: rk356x: Add HDMI audio nodes Date: Thu, 25 Nov 2021 20:30:24 +0100 Message-ID: <4335378.eiKhv840gI@diego> In-Reply-To: <08774d87-97e0-6afa-2816-bf78949e4e68@gmail.com> References: <20211125100836.423808-1-frattaroli.nicolas@gmail.com> <20211125100836.423808-2-frattaroli.nicolas@gmail.com> <08774d87-97e0-6afa-2816-bf78949e4e68@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211125_113029_885364_0E84EDE4 X-CRM114-Status: GOOD ( 23.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Donnerstag, 25. November 2021, 20:07:21 CET schrieb Johan Jonker: > Hi Nicolas, > > Some comments... > > On 11/25/21 11:08 AM, Nicolas Frattaroli wrote: > > This adds the i2s0 node and an hdmi-sound sound device to the > > rk356x device tree. On the rk356[68], the i2s0 controller is > > connected to HDMI audio. > > > > Signed-off-by: Nicolas Frattaroli > > --- > > arch/arm64/boot/dts/rockchip/rk356x.dtsi | 32 ++++++++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > > index 3c09cf6d4c37..ad4053402eef 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > > @@ -614,6 +614,21 @@ hdmi_in_vp2: endpoint@2 { > > }; > > }; > > > > > + hdmi_sound: hdmi-sound { > > Some DT sort rules: > > For nodes: > Sort things without reg alphabetical first, > then sort the rest by reg address. > > > + compatible = "simple-audio-card"; > > simple-audio-card,name = "HDMI"; > > > + simple-audio-card,format = "i2s"; > > + simple-audio-card,mclk-fs = <256>; > > > + simple-audio-card,name = "hdmi-sound"; > > Exceptions: > Sort simple-audio-card,name above other simple-audio-card properties. > > Shouldn't we standardize to SPDIF, HDMI and Analog similar to rk3318/rk3328? > Make a shorter label without spaces or special chars, so that chars > don't get removed? > See "aplay -l" screen print. > > Maybe rename to "HDMI"? > > > + status = "disabled"; > > + > > + simple-audio-card,cpu { > > + sound-dai = <&i2s0_8ch>; > > + }; > > Add empty line between nodes. > > Not sure if Heiko cares, but when alphabetical sort I get this: > simple-audio-card,codec > simple-audio-card,cpu Hehe ... I do care, but would normally just (silently) re-sort these things when applying ;-) . Heiko > > + simple-audio-card,codec { > > + sound-dai = <&hdmi>; > > + }; > > + }; > > + > > qos_gpu: qos@fe128000 { > > compatible = "rockchip,rk3568-qos", "syscon"; > > reg = <0x0 0xfe128000 0x0 0x20>; > > @@ -789,6 +804,23 @@ spdif: spdif@fe460000 { > > status = "disabled"; > > }; > > > > + i2s0_8ch: i2s@fe400000 { > > + compatible = "rockchip,rk3568-i2s-tdm"; > > + reg = <0x0 0xfe400000 0x0 0x1000>; > > + interrupts = ; > > + assigned-clocks = <&cru CLK_I2S0_8CH_TX_SRC>, <&cru CLK_I2S0_8CH_RX_SRC>; > > + assigned-clock-rates = <1188000000>, <1188000000>; > > + clocks = <&cru MCLK_I2S0_8CH_TX>, <&cru MCLK_I2S0_8CH_RX>, <&cru HCLK_I2S0_8CH>; > > + clock-names = "mclk_tx", "mclk_rx", "hclk"; > > + dmas = <&dmac1 0>; > > + dma-names = "tx"; > > + resets = <&cru SRST_M_I2S0_8CH_TX>, <&cru SRST_M_I2S0_8CH_RX>; > > + reset-names = "tx-m", "rx-m"; > > + rockchip,grf = <&grf>; > > + #sound-dai-cells = <0>; > > + status = "disabled"; > > + }; > > + > > i2s1_8ch: i2s@fe410000 { > > compatible = "rockchip,rk3568-i2s-tdm"; > > reg = <0x0 0xfe410000 0x0 0x1000>; > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel