From mboxrd@z Thu Jan 1 00:00:00 1970 From: d-gerlach@ti.com (Dave Gerlach) Date: Fri, 13 Apr 2018 09:06:31 -0500 Subject: [PATCH] ARM: omap2: Fix build when using split object directories In-Reply-To: References: <20180411211543.7923-1-d-gerlach@ti.com> <20180412082157.GB4002@localhost.localdomain> Message-ID: <4343a047-18b1-409d-ccda-94e72ea63e2a@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Tony, On 04/12/2018 04:08 AM, Masahiro Yamada wrote: > 2018-04-12 17:21 GMT+09:00 Anders Roxell : >> On 2018-04-11 16:15, Dave Gerlach wrote: >>> The sleep33xx and sleep43xx files should not depend on a header file >>> generated in drivers/memory. Remove this dependency and instead allow >>> both drivers/memory and arch/arm/mach-omap2 to generate all macros >>> needed in headers local to their own paths. >>> >>> This fixes an issue where the build fail will when using O= to set a >>> split object directory and arch/arm/mach-omap2 is built before >>> drivers/memory with the following error: >>> >>> .../drivers/memory/emif-asm-offsets.c:1:0: fatal error: can't open drivers/memory/emif-asm-offsets.s for writing: No such file or directory >>> compilation terminated. >>> >>> Fixes: 41d9d44d7258 ("ARM: OMAP2+: pm33xx-core: Add platform code needed for PM") >>> Acked-by: Tony Lindgren >>> Reviewed-by: Masahiro Yamada >>> Signed-off-by: Dave Gerlach >> >> Tested-by: Anders Roxell >> >> Maybe we can remove drivers/memory/Makefile.asm-offsets and move those >> changes into drivers/memory/Makefile ? > > Agree! > This is the version of this patch that we want to use, will this go through you? Regards, Dave > > >