From: Alim Akhtar <alim.akhtar@samsung.com>
To: Stanley Chu <stanley.chu@mediatek.com>,
linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
avri.altman@wdc.com, pedrom.sousa@synopsys.com
Cc: marc.w.gonzalez@free.fr, andy.teng@mediatek.com,
chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com,
evgreen@chromium.org, linux-mediatek@lists.infradead.org,
peter.wang@mediatek.com, matthias.bgg@gmail.com,
linux-arm-kernel@lists.infradead.org, beanhuo@micron.com
Subject: Re: [PATCH v2 3/3] scsi: ufs: Use re-factored Auto-Hibernate function
Date: Mon, 20 May 2019 11:11:18 +0530 [thread overview]
Message-ID: <434c1d39-943d-a05b-5366-dddf3064f180@samsung.com> (raw)
In-Reply-To: <1557912988-26758-4-git-send-email-stanley.chu@mediatek.com>
On 5/15/19 3:06 PM, Stanley Chu wrote:
> Use re-factored ufshcd_is_auto_hibern8_supported() function
> in ufshcd_init() instead to make code more cleaner.
>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index e6a86223a0d4..17af157c2cc1 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -8340,7 +8340,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq)
> UIC_LINK_HIBERN8_STATE);
>
> /* Set the default auto-hiberate idle timer value to 150 ms */
> - if (hba->capabilities & MASK_AUTO_HIBERN8_SUPPORT & !hba->ahit) {
> + if (ufshcd_is_auto_hibern8_supported(hba) & !hba->ahit) {
After fixing the typo in above line (as pointed by Avri in patch 1),
feel free to add
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> hba->ahit = FIELD_PREP(UFSHCI_AHIBERN8_TIMER_MASK, 150) |
> FIELD_PREP(UFSHCI_AHIBERN8_SCALE_MASK, 3);
> }
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-20 6:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 9:36 [PATCH v2 0/3] scsi: ufs: Add error handling of Auto-Hibernate Stanley Chu
2019-05-15 9:36 ` [PATCH v2 1/3] scsi: ufs: Do not overwrite Auto-Hibernate timer Stanley Chu
2019-05-20 5:05 ` Alim Akhtar
2019-05-20 5:47 ` Avri Altman
2019-05-20 5:50 ` Stanley Chu
2019-05-15 9:36 ` [PATCH v2 2/3] scsi: ufs: Add error-handling of Auto-Hibernate Stanley Chu
2019-05-15 10:03 ` [EXT] " Bean Huo (beanhuo)
2019-05-20 5:37 ` Alim Akhtar
2019-05-15 9:36 ` [PATCH v2 3/3] scsi: ufs: Use re-factored Auto-Hibernate function Stanley Chu
2019-05-15 10:05 ` [EXT] " Bean Huo (beanhuo)
2019-05-20 5:41 ` Alim Akhtar [this message]
2019-05-20 1:15 ` [PATCH v2 0/3] scsi: ufs: Add error handling of Auto-Hibernate Stanley Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=434c1d39-943d-a05b-5366-dddf3064f180@samsung.com \
--to=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=chun-hung.wu@mediatek.com \
--cc=evgreen@chromium.org \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=pedrom.sousa@synopsys.com \
--cc=peter.wang@mediatek.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox