From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9E03C04AB5 for ; Mon, 3 Jun 2019 14:45:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D49627B26 for ; Mon, 3 Jun 2019 14:45:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CV9RsbQe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D49627B26 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W1HdKtsoWlYeL/ocSQ7AyhG7KZK0BpXuju22rsHpsPw=; b=CV9RsbQetI8TAl KWJDrBktUG++tHFdGaCni2svItPE9d/5GcFhpZQRUOgTDpNnAbJRc+vfguw8DNsgSFqIN0mjA7f9D qF63BjOuJZscmNRtCY3WZRFBEFRfqwme7Yo0/CsB2hAeUNPS5erJRrxs5LhHaJQJavdWzdeAtX8qz 9UlyGZ3kG1yES/wWlq8egui378BRmu+EwmK+YiS15ZiqmpwfqkU4w907xA4GvPk6gWQHgHRFjwJ70 4eqfeJjXtrcNmxlRwpEbdE/6KDqcGDtJEwFkwAgYLLG7Qi6yu+hVEmxU+iIJvk/xx0dA+NRhgxHNo 0UlbIwEcRAdoB9ZJwNoA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXoCo-0004Te-Hp; Mon, 03 Jun 2019 14:44:58 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXoCm-0004TA-3Q; Mon, 03 Jun 2019 14:44:57 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id 5A81B28A185 Message-ID: <435028daafebcf23425dd5b9338dc3126fac8b89.camel@collabora.com> Subject: Re: [PATCH] arm64: dts: rockchip: fix isp iommu clocks and power domain From: Ezequiel Garcia To: Helen Koike , linux-rockchip@lists.infradead.org Date: Mon, 03 Jun 2019 11:44:43 -0300 In-Reply-To: <20190603142214.24686-1-helen.koike@collabora.com> References: <20190603142214.24686-1-helen.koike@collabora.com> Organization: Collabora User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190603_074456_269139_6C59F68D X-CRM114-Status: GOOD ( 16.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Philipp Tomsich , Heiko Stuebner , Tony Xie , Viresh Kumar , Randy Li , linux-kernel@vger.kernel.org, Vicente Bergas , Marc Zyngier , Rob Herring , Klaus Goger , laurent.pinchart@ideasonboard.com, manivannan.sadhasivam@linaro.org, Matthias Brugger , kernel@collabora.com, linux-arm-kernel@lists.infradead.org, Christoph Muellner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2019-06-03 at 11:22 -0300, Helen Koike wrote: > isp iommu requires wrapper variants of the clocks. > noc variants are always on and using the wrapper variants will activate > {A,H}CLK_ISP{0,1} due to the hierarchy. > > Also add the respective power domain. > > Refer: > RK3399 TRM v1.4 Fig. 2-4 RK3399 Clock Architecture Diagram > RK3399 TRM v1.4 Fig. 8-1 RK3399 Power Domain Partition > > Signed-off-by: Helen Koike > > --- > Hello, > > I tested this using the isp patch set (which is not upstream > yet). Without this patch, streaming from the isp stalls. > > I'm also enabling the power domain and removing the disable status, > please let me know if this should be done in a separated patch. > I think you might want to put the comments about enabling power domain and removing disable status on the commit log. It's useful information :-) Thanks, Eze > Thanks > Helen > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index 196ac9b78076..89594a7276f4 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -1706,11 +1706,11 @@ > reg = <0x0 0xff914000 0x0 0x100>, <0x0 0xff915000 0x0 0x100>; > interrupts = ; > interrupt-names = "isp0_mmu"; > - clocks = <&cru ACLK_ISP0_NOC>, <&cru HCLK_ISP0_NOC>; > + clocks = <&cru ACLK_ISP0_WRAPPER>, <&cru HCLK_ISP0_WRAPPER>; > clock-names = "aclk", "iface"; > #iommu-cells = <0>; > + power-domains = <&power RK3399_PD_ISP0>; > rockchip,disable-mmu-reset; > - status = "disabled"; > }; > > isp1_mmu: iommu@ff924000 { > @@ -1718,11 +1718,11 @@ > reg = <0x0 0xff924000 0x0 0x100>, <0x0 0xff925000 0x0 0x100>; > interrupts = ; > interrupt-names = "isp1_mmu"; > - clocks = <&cru ACLK_ISP1_NOC>, <&cru HCLK_ISP1_NOC>; > + clocks = <&cru ACLK_ISP1_WRAPPER>, <&cru HCLK_ISP1_WRAPPER>; > clock-names = "aclk", "iface"; > #iommu-cells = <0>; > + power-domains = <&power RK3399_PD_ISP1>; > rockchip,disable-mmu-reset; > - status = "disabled"; > }; > > hdmi_sound: hdmi-sound { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel