From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A665C52D73 for ; Wed, 7 Aug 2024 17:19:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9UOg4TXxLIdzN4lKT+Ty1+k+5yhLc9zZZCgyhu736aY=; b=ftrGbSSK1ilL9B1CgcjTLlu1eQ xv1B7j1NyNkJyJNibtSuSToRW3BRLSkvSwB4GSgwTWWpQNM9NB2LaYNlXqM0O2bMoAJjNv8rid79B 4IVoQTNi//a+H5o1yCLEn++0kz5dHwqGY6dKrViwrm2k/IITjqnPMfr5RUoEtDx6M/kcjwdWZPv3Q EpOJADKi11JgJD31Vcyv9Y6k3eIyrMmLRE30KEAzf8icPaMCkgWwlGs0iXbWIx8sDJxg/t35QbcBP sbzeuHYlHRJEqhIpVhfDfrevHm6TSfV+peROhSSb27IvjUUexkxSGPLwFG1BKcPHi5wtO9fV0XHr2 8FoCr6DQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbkJF-00000005nlC-1qNm; Wed, 07 Aug 2024 17:18:49 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbkIg-00000005ngY-2657; Wed, 07 Aug 2024 17:18:16 +0000 Received: from i53875a9f.versanet.de ([83.135.90.159] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sbkII-0002MU-H9; Wed, 07 Aug 2024 19:17:50 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Florian Klink , Dragan Simic Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Kever Yang , Muhammed Efe Cetin , FUKAUMI Naoki , =?utf-8?B?VGFtw6FzIFN6xbFjcw==?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: rockchip: add rfkill node for M.2 E wifi on orangepi-5-plus Date: Wed, 07 Aug 2024 19:17:49 +0200 Message-ID: <4364452.rE2NhlSrgm@diego> In-Reply-To: References: <20240807162001.1737829-1-flokli@flokli.de> <20240807170030.1747381-1-flokli@flokli.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240807_101814_622463_5594893B X-CRM114-Status: GOOD ( 16.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Florian, Am Mittwoch, 7. August 2024, 19:15:03 CEST schrieb Dragan Simic: > On 2024-08-07 19:00, Florian Klink wrote: > > This follows the same logic as 82d40b141a4c ("arm64: dts: rockchip: add > > rfkill node for M.2 Key E WiFi on rock-5b"). > > > > On the orangepi-5-plus, there's also a GPIO pin connecting the WiFi > > enable signal inside the M.2 Key E slot. > > > > The exact GPIO PIN can be validated in the Armbian rk-5.10-rkr4 kernel > > rk3588-orangepi-5-plus.dtsi file [1], which contains a `wifi_disable` > > node referencing RK_PC4 on &gpio0. > > > > Signed-off-by: Florian Klink > > Tested-by: Florian Klink > > Link: > > https://github.com/armbian/linux-rockchip/blob/9fbe23c9da24f236c6009f42d3f02c1ffb84c169/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts > > [1] > > Unfortunately, this isn't how the "Link: ..." tag is to be used, or how > a reference is to be provided. Please see the patch submission linked > below for a correct example of providing links as references. > > https://lore.kernel.org/linux-rockchip/4449f7d4eead787308300e2d1d37b88c9d1446b2.1717308862.git.dsimic@manjaro.org/T/#u please also don't post v2 patches as replies to v1. Instead start a new mail thread please. A lot of tooling cannot really find the correct version in such multiversion threads. Heiko