linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 0/3] ARM: rockchip: fix the SMP
Date: Tue, 09 Jun 2015 22:04:08 +0200	[thread overview]
Message-ID: <4374173.2rp7Jv3Cd5@diego> (raw)
In-Reply-To: <1433843400-24831-1-git-send-email-wxt@rock-chips.com>

Hi Caesar,


Am Dienstag, 9. Juni 2015, 17:49:56 schrieb Caesar Wang:
> Verified on url =
>    
> https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-> 3.14 Tested by 179200 cycles are pass with CPU up/dowm test scripts.
> 
> Changes in v6:
> - As Russell suggestion, detect whether of_reset_control_get() failed
> - add the comment for 1ms delay.
> Series-changes: 5
> - back to v2 cpu on/off flow, As Heiko point out in patch v3.
> - delay more time in rockchip_boot_secondary().
>   From CPU up/down tests, Needed more time to complete CPU process.
>   In order to ensure a more, Here that be delayed 1ms.
> Series-changes: 4
> - Add reset_control_put(rstc) for the non-error case.
> Series-changes: 3
> - FIx the PATCH v2, it doesn't work on chromium 3.14.
> Series-changes: 2
> - As Heiko suggestion, re-adjust the cpu on/off flow.
>   CPU off:
>     reset_control_assert
>     regmap_update_bits(pmu, PMU_PWRDN_CON, BIT(pd), BIT(pd))
>     wait_for_power_domain_to_turn_off
>   CPU on:
>     regmap_update_bits(pmu, PMU_PWRDN_CON, BIT(pd), 0)
>     wait_for_power_domain_to_turn_on
>     reset_control_deassert
> - Fix the delay 1ms describing.
> Series-changes: 5
> - Fix the patch decription.
> - Add the changelog.
> Series-changes: 2
> - As Kever points out, Fix the subject typo WFI/WFE.
> - fix the commnet Unified format.
> Series-changes: 5
> - Add the changelog.
> Series-changes: 2
> - Use the checkpatch.pl -f --subjective to check.
> 
> Caesar Wang (3):
>   ARM: rockchip: fix the CPU soft reset
>   ARM: rockchip: ensure CPU to enter WFI/WFE state
>   ARM: rockchip: fix the SMP code style

the series looks good to me now. I'll give it another day or so before 
applying, just in case Russell wants to provide additional comments.


Heiko

  parent reply	other threads:[~2015-06-09 20:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-09  9:49 [PATCH v6 0/3] ARM: rockchip: fix the SMP Caesar Wang
2015-06-09  9:49 ` [PATCH v6 1/3] ARM: rockchip: fix the CPU soft reset Caesar Wang
2015-06-09 18:16   ` Doug Anderson
2015-06-10  5:58   ` Kever Yang
2015-06-09  9:49 ` [PATCH v6 2/3] ARM: rockchip: ensure CPU to enter WFI/WFE state Caesar Wang
2015-06-09 18:13   ` Doug Anderson
2015-06-10  5:59   ` Kever Yang
2015-06-09  9:49 ` [PATCH v6 3/3] ARM: rockchip: fix the SMP code style Caesar Wang
2015-06-09 18:17   ` Doug Anderson
2015-06-10  5:59   ` Kever Yang
2015-06-09 20:04 ` Heiko Stübner [this message]
2015-06-13 21:02 ` [PATCH v6 0/3] ARM: rockchip: fix the SMP Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4374173.2rp7Jv3Cd5@diego \
    --to=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).