public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 4/8] ARM: shmobile: r7s72100: Add MTU2 device to DT
Date: Tue, 15 Jul 2014 13:55:25 +0200	[thread overview]
Message-ID: <4380270.nzol65dDjU@avalon> (raw)
In-Reply-To: <20140715114741.GB25333@verge.net.au>

Hi Simon,

On Tuesday 15 July 2014 20:47:41 Simon Horman wrote:
> On Wed, Jul 09, 2014 at 03:12:40PM +0200, Laurent Pinchart wrote:
> > Add the MTU2 counter to the r7s72100 device tree and make it disabled by
> > default.
> > 
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >  arch/arm/boot/dts/r7s72100.dtsi | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/r7s72100.dtsi
> > b/arch/arm/boot/dts/r7s72100.dtsi index bdee225..c902b0b 100644
> > --- a/arch/arm/boot/dts/r7s72100.dtsi
> > +++ b/arch/arm/boot/dts/r7s72100.dtsi
> > @@ -229,6 +229,16 @@
> >  		status = "disabled";
> >  	};
> > 
> > +	mtu2: timer at fcff0000 {
> > +		compatible = "renesas,mtu2";
> > +		reg = <0xfcff0000 0x400>;
> > +		interrupts = <0 139 IRQ_TYPE_LEVEL_HIGH>;
> > +		interrupt-names = "tgi0a";
> > +		clocks = <&mstp3_clks R7S72100_CLK_MTU2>;
> > +		clock-names = "fck";
> > +		status = "disabled";
> > +	};
> > +
> >  	scif0: serial at e8007000 {
> >  		compatible = "renesas,scif-r7s72100", "renesas,scif";
> >  		reg = <0xe8007000 64>;
> 
> I believe that I claimed to have tested this in the past but that
> my testing was by booting a config to userspace that as it happens
> did not require to timer to get that far.
> 
> I now believe there is a minor error: the interrupt number should be
> (139 - 32 =) 107 rather than 139.
> 
> This allows a system with this and the related genmai patch applied
> on top of renesas-next-v3.16-rc3-20140715 to boot to uerspace
> when compiled with shmobile_defconfig (+ an initrd).
> Without the irq number change the boot gets stuck in
> ip_auto_config (which presumably sleeps).
> 
> Laurent, should I squash the following in and queue-up the result?

Please do, and sorry for the mistake.

> diff --git a/arch/arm/boot/dts/r7s72100.dtsi
> b/arch/arm/boot/dts/r7s72100.dtsi index c902b0b..1d28d01 100644
> --- a/arch/arm/boot/dts/r7s72100.dtsi
> +++ b/arch/arm/boot/dts/r7s72100.dtsi
> @@ -232,7 +232,7 @@
>  	mtu2: timer at fcff0000 {
>  		compatible = "renesas,mtu2";
>  		reg = <0xfcff0000 0x400>;
> -		interrupts = <0 139 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
>  		interrupt-names = "tgi0a";
>  		clocks = <&mstp3_clks R7S72100_CLK_MTU2>;
>  		clock-names = "fck";

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2014-07-15 11:55 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-09 13:12 [PATCH v5 0/8] Enable timers DT devices for Marzen, Genmai, Lager and Koelsch Laurent Pinchart
2014-07-09 13:12 ` [PATCH v5 1/8] ARM: shmobile: r8a7790: Add CMT devices to DT Laurent Pinchart
2014-07-09 13:12 ` [PATCH v5 2/8] ARM: shmobile: r8a7791: " Laurent Pinchart
2014-07-09 13:12 ` [PATCH v5 3/8] ARM: shmobile: r8a7779: Add TMU " Laurent Pinchart
2014-07-09 13:12 ` [PATCH v5 4/8] ARM: shmobile: r7s72100: Add MTU2 device " Laurent Pinchart
2014-07-10  9:53   ` Wolfram Sang
2014-07-15 11:47   ` Simon Horman
2014-07-15 11:55     ` Laurent Pinchart [this message]
2014-07-15 12:23       ` Simon Horman
2014-07-15 12:28         ` Simon Horman
2014-07-09 13:12 ` [PATCH v5 5/8] ARM: shmobile: lager-reference: Enable CMT0 in device tree Laurent Pinchart
2014-07-09 13:12 ` [PATCH v5 6/8] ARM: shmobile: koelsch-reference: " Laurent Pinchart
2014-07-09 13:12 ` [PATCH v5 7/8] ARM: shmobile: marzen-reference: Enable TMU0 " Laurent Pinchart
2014-07-09 13:12 ` [PATCH v5 8/8] ARM: shmobile: genmai-reference: Enable MTU2 " Laurent Pinchart
2014-07-10  9:54   ` Wolfram Sang
2014-07-15  8:54     ` Simon Horman
2014-07-15  8:58       ` Simon Horman
2014-07-15 11:36         ` Simon Horman
2014-07-15 12:28           ` Simon Horman
2014-07-15  5:01 ` [PATCH v5 0/8] Enable timers DT devices for Marzen, Genmai, Lager and Koelsch Simon Horman
2014-07-15  8:55   ` Simon Horman
2014-07-15 11:35     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4380270.nzol65dDjU@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox