From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de,
Benjamin Gaignard <benjamin.gaignard@collabora.com>
Cc: mchehab@kernel.org, nicolas@ndufresne.ca,
hverkuil-cisco@xs4all.nl, gregkh@linuxfoundation.org,
wens@csie.org, samuel@sholland.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: Re: [RFC PATCH 0/8] media: hantro: Add 10-bit support
Date: Tue, 05 Apr 2022 20:40:38 +0200 [thread overview]
Message-ID: <4386971.LvFx2qVVIh@jernej-laptop> (raw)
In-Reply-To: <b6987a9a-56af-f63f-b60a-37df141d6e89@collabora.com>
Hi Benjamin!
Dne torek, 05. april 2022 ob 18:07:41 CEST je Benjamin Gaignard napisal(a):
> Le 27/02/2022 à 15:49, Jernej Skrabec a écrit :
> > First two patches add 10-bit formats to UAPI, third extends filtering
> > mechanism, fourth fixes incorrect assumption, fifth moves register
> > configuration code to proper place, sixth and seventh enable 10-bit
> > VP9 decoding on Allwinner H6 and last increases core frequency on
> > Allwinner H6.
> >
> > I'm sending this as RFC to get some comments:
> > 1. format definitions - are fourcc's ok? are comments/descriptions ok?
> > 2. is extended filtering mechanism ok?
> >
> > I would also like if these patches are tested on some more HW.
> > Additionally, can someone test tiled P010?
> >
> > Please take a look.
>
> Hi Jernej,
>
> I have create a branch to test this series with VP9 and HEVC:
> https://gitlab.collabora.com/benjamin.gaignard/for-upstream/-/tree/10bit_imx
> 8m Feel free to pick what I may need in it.
>
> That doesn't improve fluster scores, I think more dev are still needed in
> GST before getting something fully functional.
> Anyway I able to select P010 pixel format if the input is a 10bit bitstream.
What kind of improvements do you expect? Actually, this series is designed to
change nothing for platforms, where 10-bit format is not added into the list
of supported formats. I think reasons are quite obvious. First, not every
device may support 10-bit output. Second, as you might already figured it out,
registers in this series are set only for legacy cores. I have no idea, what
needs to be done for newer ones, since I don't have them. Anyway, I tested
this with fluster and only one additional test passes, because it is the only
one for 10-bit YUV420.
Best regards,
Jernej
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-05 18:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 14:49 [RFC PATCH 0/8] media: hantro: Add 10-bit support Jernej Skrabec
2022-02-27 14:49 ` [RFC PATCH 1/8] media: Add P010 tiled format Jernej Skrabec
2022-02-27 14:49 ` [RFC PATCH 2/8] media: Add P010 format Jernej Skrabec
2022-02-28 12:48 ` Nicolas Dufresne
2022-02-28 16:32 ` Jernej Škrabec
2022-02-28 17:02 ` Nicolas Dufresne
2022-04-04 0:04 ` Ezequiel Garcia
2022-04-04 9:02 ` Benjamin Gaignard
2022-02-27 14:49 ` [RFC PATCH 3/8] media: hantro: Support format filtering by depth Jernej Skrabec
2022-04-05 16:09 ` Benjamin Gaignard
2022-04-05 18:41 ` Jernej Škrabec
2022-02-27 14:49 ` [RFC PATCH 4/8] media: hantro: postproc: Fix buffer size calculation Jernej Skrabec
2022-04-04 0:16 ` Ezequiel Garcia
2022-02-27 14:49 ` [RFC PATCH 5/8] media: hantro: postproc: Fix legacy regs configuration Jernej Skrabec
2022-04-04 0:24 ` Ezequiel Garcia
2022-02-27 14:49 ` [RFC PATCH 6/8] media: hantro: Store VP9 bit depth in context Jernej Skrabec
2022-02-27 14:49 ` [RFC PATCH 7/8] media: hantro: sunxi: Enable 10-bit decoding Jernej Skrabec
2022-02-27 14:49 ` [RFC PATCH 8/8] media: hantro: sunxi: Increase frequency Jernej Skrabec
2022-02-27 17:03 ` [RFC PATCH 0/8] media: hantro: Add 10-bit support Jernej Škrabec
2022-04-05 16:07 ` Benjamin Gaignard
2022-04-05 18:40 ` Jernej Škrabec [this message]
2022-04-06 6:54 ` Benjamin Gaignard
2022-04-06 17:21 ` Jernej Škrabec
2022-04-06 17:50 ` Nicolas Dufresne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4386971.LvFx2qVVIh@jernej-laptop \
--to=jernej.skrabec@gmail.com \
--cc=benjamin.gaignard@collabora.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-sunxi@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=p.zabel@pengutronix.de \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).