Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/6] pinctrl: exynos: Handle suspend/resume of GPIO EINT registers
Date: Wed, 22 May 2013 15:32:36 +0200	[thread overview]
Message-ID: <4391865.a7p9jbyZ7B@amdc1227> (raw)
In-Reply-To: <CAD=FV=VYhBP+V6SQt5SkFZszdVxSJ6AZk-C-zx1Di-RZBYhGvw@mail.gmail.com>

On Tuesday 21 of May 2013 21:46:35 Doug Anderson wrote:
> Tomasz,
> 
> On Tue, May 21, 2013 at 10:05 AM, Tomasz Figa <t.figa@samsung.com> wrote:
> >         return 0;
> > 
> > +
> > +err_domains:
> > +       bank = d->ctrl->pin_banks;
> > +       for (undo = 0; undo < i; ++undo) {
> 
> ++bank is missing, I think.  This will free the same bank many times.

Shit, this is what happens when you post patches so late and in a hurry. Will 
send something sane in a while.

> optional: could also avoid extra 'undo' variable and remove in reverse
> order by changing i to signed and counting down to 0.

Sure.

Best regards,
Tomasz

> -Doug
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
> in the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2013-05-22 13:32 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-17 16:24 [PATCH 0/6] Fix suspend/resume issues created by pinmux on exynos, part 2 Tomasz Figa
2013-05-17 16:24 ` [PATCH 1/6] pinctrl: exynos: Add support for set_irq_wake of wake-up EINTs Tomasz Figa
2013-05-17 19:17   ` Doug Anderson
2013-05-21 11:25   ` Linus Walleij
2013-05-17 16:24 ` [PATCH 2/6] ARM: EXYNOS: Fix EINT wake-up mask configuration when pinctrl is used Tomasz Figa
2013-05-17 19:22   ` Doug Anderson
2013-05-17 19:49     ` Tomasz Figa
2013-05-21 11:27   ` Linus Walleij
2013-05-17 16:24 ` [PATCH 3/6] ARM: SAMSUNG: pm: Adjust for pinctrl- and DT-enabled platforms Tomasz Figa
2013-05-17 19:24   ` Doug Anderson
2013-05-17 20:23     ` Tomasz Figa
2013-05-17 20:56       ` Doug Anderson
2013-05-17 21:07         ` Tomasz Figa
2013-05-21 11:29           ` Linus Walleij
2013-05-21 13:15             ` Tomasz Figa
2013-05-21 17:06               ` Tomasz Figa
2013-06-10 14:45   ` Tomasz Figa
2013-06-10 16:13     ` Linus Walleij
2013-06-11  7:45       ` Olof Johansson
2013-06-11  8:21         ` Olof Johansson
2013-06-12  0:15           ` Tomasz Figa
2013-06-12  0:20             ` Olof Johansson
2013-05-17 16:24 ` [PATCH 4/6] pinctrl: samsung: Add support for SoC-specific suspend/resume callbacks Tomasz Figa
2013-05-17 19:24   ` Doug Anderson
2013-05-17 20:51     ` Tomasz Figa
2013-05-24  9:07   ` Linus Walleij
2013-05-24  9:20     ` Tomasz Figa
2013-05-17 16:24 ` [PATCH 5/6] pinctrl: samsung: Allow per-bank SoC-specific private data Tomasz Figa
2013-05-17 19:24   ` Doug Anderson
2013-05-24  9:09   ` Linus Walleij
2013-05-17 16:24 ` [PATCH 6/6] pinctrl: exynos: Handle suspend/resume of GPIO EINT registers Tomasz Figa
2013-05-17 19:25   ` Doug Anderson
2013-05-17 20:34     ` Tomasz Figa
2013-05-17 21:18       ` Doug Anderson
2013-05-21 17:05         ` [PATCH v2 " Tomasz Figa
2013-05-22  4:46           ` Doug Anderson
2013-05-22 13:32             ` Tomasz Figa [this message]
2013-05-22 14:03             ` [PATCH v3 " Tomasz Figa
2013-05-22 15:57               ` Doug Anderson
2013-05-24  9:12               ` Linus Walleij
2013-05-24  9:23                 ` Tomasz Figa
2013-05-20  9:35 ` [PATCH 0/6] Fix suspend/resume issues created by pinmux on exynos, part 2 Tushar Behera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4391865.a7p9jbyZ7B@amdc1227 \
    --to=t.figa@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox