From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD26DEB64C8 for ; Sat, 7 Sep 2024 14:35:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gG2BH1+dXG7ZoJOt2ZX2FJLzrZcgshauVLlXVmZq6sM=; b=G5fzUGqicAi++ZXEARwHixLHnf E98rCibtdn/G3JneVYBkFN7PPxbTnqisLG7xV2bBIV/a+JxlMDizt259g/AvKfz38AOqYHlx5ryYu 0JHs8Cubss9cvc1OW++GO1I6SlRt7xT/uXGRwyIQ+3WD40kbZvxId9UtsGE4uNeXANkUmOF2HPiRI 4O3ERZTYjty5Z3O9uhM//0uKWbTdKDDbIqNYbvhUV6LUIZiMnGW76fb1iU3e0pg4X1UU7dAxK7sHl XPDwn83yl86Cd/7JxAt/F0UR8CUGNJSGFEBleLFn3Te91yhJZnUi1C2j7sNqybcYuvV1ObIkxfWRz 8mqeFHtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smwWk-0000000F9lI-1owe; Sat, 07 Sep 2024 14:35:02 +0000 Received: from [129.204.178.38] (helo=classfun.cn) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smwVj-0000000F9e8-3jPG; Sat, 07 Sep 2024 14:34:01 +0000 Received: from [192.168.0.160] (unknown [14.155.100.110]) (Authenticated sender: bigfoot) by classfun.cn (Postfix) with ESMTPSA id 2278778A01; Sat, 7 Sep 2024 22:33:56 +0800 (CST) DKIM-Filter: OpenDKIM Filter v2.11.0 classfun.cn 2278778A01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=classfun.cn; s=default; t=1725719638; bh=gG2BH1+dXG7ZoJOt2ZX2FJLzrZcgshauVLlXVmZq6sM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DSNlpm8Vqtpho/RR7/MrKCNIEHFUFwwo/5l+BjIiUEgoS/ohM5XFx/jEygmd6VrWX Ficq4hrX/KNy045+dpBwYrC5HAtq1+QfDxuRCBmvXQ8b82WTjXTLr797wpeVzIyaVz 0LwzUe5E6XCPOlgoplXM/RpP0R2GK63DfSfLnJsU= Message-ID: <43918eda-c4e8-471a-9de4-ea72bb090803@classfun.cn> Date: Sat, 7 Sep 2024 22:33:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/9] mfd: Add driver for Photonicat power management MCU To: Markus Elfring , devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Cc: LKML , Alexandre Belloni , Chukun Pan , Conor Dooley , =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Jean Delvare , Krzysztof Kozlowski , Lee Jones , Pavel Machek , Rob Herring , Sebastian Reichel , Wim Van Sebroeck References: <20240906093630.2428329-2-bigfoot@classfun.cn> Content-Language: en-US From: Junhao Xie In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240907_073400_105858_4B481B5C X-CRM114-Status: UNSURE ( 5.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024/9/7 16:44, Markus Elfring wrote: > … >> +++ b/include/linux/mfd/photonicat-pmu.h >> @@ -0,0 +1,86 @@ > … >> +#ifndef _PHOTONICAT_PMU_H >> +#define _PHOTONICAT_PMU_H > … > > I suggest to omit leading underscores from such identifiers. > https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier > > Regards, > Markus Thanks for your suggestion, does this look better? #ifndef MFD_PHOTONICAT_PMU_H #define MFD_PHOTONICAT_PMU_H Best regards, Junhao