From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 381BAC3ABA3 for ; Fri, 2 May 2025 13:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=urhCQsQe8eTfkJp1UT0pMIiPPoJG2XRADwwlaxMzk0U=; b=oPgmptHPfpMfI/XCYB8cIAgCSY zvzrRhLnHIKp8Zgm9IyDL+qCMR4/EgWhRkKTFmV/tE/WGuwHqZHGSpR9M9FMOSriIQQ1q0Mx6Wutm GnTJFWhgBxbzaKn/mSbl88qqqGznLkz/G6Zkggrx0eo7BLJ26DnnCAQ6X+7DznD93civvXCym5Gw5 bof5JqVJofFjYYtXozB0EDenkfegfZgHZsJKWhqwuys/8RhSVklX40rvnlMp0DiCG14fxKcCD9d5F hrcFUeDJmldMniZ/3nwafIuOm4hju3QACovDdumdfjQBqgePURTDxbIUbpUidCG/cBp0WwqgN+Pr9 DPk4+e8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uAqCu-000000020hH-0Yh1; Fri, 02 May 2025 13:13:36 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uAqAw-000000020H9-1VF5 for linux-arm-kernel@lists.infradead.org; Fri, 02 May 2025 13:11:36 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 013131688; Fri, 2 May 2025 06:11:22 -0700 (PDT) Received: from [10.1.196.40] (e121345-lin.cambridge.arm.com [10.1.196.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2A5333F66E; Fri, 2 May 2025 06:11:25 -0700 (PDT) Message-ID: <43e85d6a-ef99-4d61-910e-1d62814fd9ed@arm.com> Date: Fri, 2 May 2025 14:11:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 10/14] dma-contiguous: export dma_contiguous_default_area To: Jens Wiklander , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, op-tee@lists.trustedfirmware.org, linux-arm-kernel@lists.infradead.org Cc: Olivier Masse , Thierry Reding , Yong Wu , Sumit Semwal , Benjamin Gaignard , Brian Starkey , John Stultz , "T . J . Mercier" , =?UTF-8?Q?Christian_K=C3=B6nig?= , Sumit Garg , Matthias Brugger , AngeloGioacchino Del Regno , azarrabi@qti.qualcomm.com, Simona Vetter , Daniel Stone , Rouven Czerwinski , Marek Szyprowski , iommu@lists.linux.dev References: <20250502100049.1746335-1-jens.wiklander@linaro.org> <20250502100049.1746335-11-jens.wiklander@linaro.org> From: Robin Murphy Content-Language: en-GB In-Reply-To: <20250502100049.1746335-11-jens.wiklander@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250502_061134_537139_1A0FF7AB X-CRM114-Status: GOOD ( 11.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02/05/2025 10:59 am, Jens Wiklander wrote: > Export the global variable dma_contiguous_default_area so > dev_get_cma_area() can be called a module. What dma_map_ops implementation is in a module? Without any other context, I can't help thinking this smells of something sketchy. Thanks, Robin. > Cc: Marek Szyprowski > Cc: Robin Murphy > Cc: iommu@lists.linux.dev > Signed-off-by: Jens Wiklander > --- > kernel/dma/contiguous.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/dma/contiguous.c b/kernel/dma/contiguous.c > index 8df0dfaaca18..eb361794a9c5 100644 > --- a/kernel/dma/contiguous.c > +++ b/kernel/dma/contiguous.c > @@ -53,6 +53,7 @@ > #endif > > struct cma *dma_contiguous_default_area; > +EXPORT_SYMBOL(dma_contiguous_default_area); > > /* > * Default global CMA area size can be defined in kernel's .config.